Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #27713 from coreyward/module_freeze_parent_name | Rafael França | 2017-01-17 | 3 | -32/+41 |
|\ | | | | | Module#parent_name broken for frozen classes | ||||
| * | Adjust `Module.parent_name` to work when frozen; fixes #27637 | Corey Ward | 2017-01-17 | 3 | -32/+41 |
| | | |||||
* | | Merge pull request #27718 from kamipo/remove_internal_public_methods | Rafael França | 2017-01-17 | 6 | -23/+18 |
|\ \ | | | | | | | Remove `initialize_schema_migrations_table` and `initialize_internal_metadata_table` internal public methods | ||||
| * | | Remove `initialize_schema_migrations_table` and ↵ | Ryuta Kamizono | 2017-01-18 | 6 | -23/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `initialize_internal_metadata_table` internal public methods These internal methods accidentally appeared in the doc, and so almost useless. It is enough to create these internal tables directly, and indeed do so in several places. https://github.com/rails/rails/blob/v5.0.1/activerecord/lib/active_record/schema.rb#L55 https://github.com/rails/rails/blob/v5.0.1/activerecord/lib/active_record/railties/databases.rake#L6 https://github.com/rails/rails/blob/v5.0.1/activerecord/lib/active_record/tasks/database_tasks.rb#L230 | ||||
* | | | Merge pull request #27706 from y-yagi/allow_to_pass_describe_option_to_rake | Rafael França | 2017-01-17 | 3 | -3/+5 |
|\ \ \ | |/ / |/| | | allow to pass describe option to rake | ||||
| * | | allow to pass describe option to rake | yuuji.yaginuma | 2017-01-17 | 3 | -3/+5 |
| | | | | | | | | | | | | | | | | | | Since `Thor::HELP_MAPPINGS` contains `-D`, so `bin/rails -D` show rails's help. But, in Rails 5.0.1, `bin/rails -D` show the description of rake task. I think that it is better to have the same behavior. | ||||
* | | | Fix all rubocop violations | Rafael Mendonça França | 2017-01-17 | 4 | -19/+16 |
| | | | |||||
* | | | Merge pull request #27697 from toshimaru/rubocop-update | Rafael Mendonça França | 2017-01-17 | 3 | -7/+7 |
|\ \ \ | | | | | | | | | | | | | Update rubocop | ||||
| * | | | Rename AlignWith to EnforcedStyleAlignWith | toshimaru | 2017-01-16 | 1 | -1/+1 |
| | | | | |||||
| * | | | update rubocop to 0.47 | toshimaru | 2017-01-16 | 2 | -6/+6 |
| | | | | |||||
* | | | | Merge pull request #27717 from JunichiIto/fix-byebug-platform | Rafael França | 2017-01-17 | 2 | -1/+5 |
|\ \ \ \ | | | | | | | | | | | Install Byebug gem as default in Windows (mingw and x64_mingw) platform. | ||||
| * | | | | Change `platform` to `platforms` | Junichi Ito | 2017-01-18 | 1 | -1/+1 |
| | | | | | |||||
| * | | | | Install Byebug gem as default in Windows (mingw and x64_mingw) platform. | Junichi Ito | 2017-01-18 | 2 | -1/+5 |
| | | | | | |||||
* | | | | | Merge pull request #27716 from kenta-s/remove-unused-variable-regex | Rafael França | 2017-01-17 | 1 | -1/+1 |
|\ \ \ \ \ | |_|_|_|/ |/| | | | | Remove unused variable 'regex' | ||||
| * | | | | Remove unused variable 'regex' | kenta-s | 2017-01-18 | 1 | -1/+1 |
|/ / / / | |||||
* | | | | Merge pull request #27712 from coreyward/resolve_decode_test_warning | Rafael França | 2017-01-17 | 1 | -2/+7 |
|\ \ \ \ | | | | | | | | | | | Use appropriate assertion based on expectation | ||||
| * | | | | Use appropriate assertion based on expectation | Corey Ward | 2017-01-17 | 1 | -2/+7 |
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | This resolves a stern Minitest “warning” about an upcoming behavior change in MiniTest 6 that will result in the test failing. https://github.com/seattlerb/minitest/issues/666 | ||||
* | | | | Move config reset to ensure block | Andrew White | 2017-01-17 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | We don't want to leak the extra migration path to other railties tests. | ||||
* | | | | Move config reset to ensure block | Andrew White | 2017-01-17 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | We don't want to leak the extra migration path to other railties tests. | ||||
* | | | | Merge pull request #27674 from kjg/migration_generator_honor_path_config | Andrew White | 2017-01-17 | 5 | -2/+42 |
|\ \ \ \ | | | | | | | | | | | Generate migrations at path set by `config.paths["db/migrate"]` | ||||
| * | | | | Generate migrations at path set by `config.paths["db/migrate"]` | Kevin Glowacz | 2017-01-16 | 5 | -2/+42 |
| | | | | | |||||
* | | | | | Merge pull request #27700 from kenta-s/remove-meaningless-line-from-adapter-test | Andrew White | 2017-01-17 | 1 | -1/+0 |
|\ \ \ \ \ | | | | | | | | | | | | | Remove meaningless line from adapter_test.rb | ||||
| * | | | | | Remove meaningless line from adapter_test.rb | kenta-s | 2017-01-16 | 1 | -1/+0 |
| | |_|/ / | |/| | | | |||||
* | | | | | Merge pull request #24743 from kamipo/sqlite_foreing_key_support | Andrew White | 2017-01-17 | 8 | -38/+87 |
|\ \ \ \ \ | | | | | | | | | | | | | SQLite: Foreign Key Support | ||||
| * | | | | | SQLite: Foreign Key Support | Ryuta Kamizono | 2017-01-17 | 6 | -30/+81 |
| | | | | | | | | | | | | | | | | | | | | | | | | https://www.sqlite.org/foreignkeys.html | ||||
| * | | | | | Should work foreign key in test schema without `if supports_foreign_keys?` ↵ | Ryuta Kamizono | 2017-01-17 | 2 | -8/+6 |
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | statement If an adapter does not support foreign key feature, should be noop. https://github.com/rails/rails/blob/v5.0.0.rc1/activerecord/test/cases/migration/foreign_key_test.rb#L288-L294 https://github.com/rails/rails/blob/v5.0.0.rc1/activerecord/test/cases/migration/references_foreign_key_test.rb#L208-L214 | ||||
* | | | | | Be a bit more explicit rather than relying on the default task | David Heinemeier Hansson | 2017-01-17 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Make yarn install available as a rake task via yarn:install so we can use ↵ | David Heinemeier Hansson | 2017-01-17 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | | | | | that as a dependency for assets:precompile | ||||
* | | | | | Don't pollute Object with rubinius_skip and jruby_skip | Akira Matsuda | 2017-01-17 | 6 | -55/+55 |
| | | | | | | | | | | | | | | | | | | | | we call them only in the tests | ||||
* | | | | | All currently supported rubies already have LoadError#path | Akira Matsuda | 2017-01-17 | 1 | -12/+0 |
| | | | | | |||||
* | | | | | :golf: else + if = elsif | Akira Matsuda | 2017-01-17 | 1 | -10/+8 |
|/ / / / | |||||
* | | | | Merge pull request #27704 from kmcphillips/transliterate-exception | Rafael França | 2017-01-16 | 3 | -0/+25 |
|\ \ \ \ | |_|_|/ |/| | | | Raise ArgumentError if attempting to transliterate nil | ||||
| * | | | CHANGELOG: Raise ArgumentError when calling transliterate on anything other ↵ | Kevin McPhillips | 2017-01-16 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | than a string | ||||
| * | | | Raise ArgumentError if attempting to transliterate anything that is not a string | Kevin McPhillips | 2017-01-16 | 2 | -0/+20 |
| | |/ | |/| | |||||
* | | | s/perfomed/performed/ | Akira Matsuda | 2017-01-17 | 1 | -1/+1 |
| | | | | | | | | | | | | [ci skip] | ||||
* | | | Missing require for strip_heredoc | Akira Matsuda | 2017-01-17 | 1 | -0/+1 |
|/ / | |||||
* | | Add CHANGELOG entry for #27701 | Andrew White | 2017-01-16 | 1 | -0/+4 |
| | | |||||
* | | Merge pull request #27701 from kamipo/translate_foreign_key_violation | Andrew White | 2017-01-16 | 2 | -45/+74 |
|\ \ | | | | | | | Translate Foreign Key violation to the specific exception for SQLite3 adapter | ||||
| * | | Translate Foreign Key violation to the specific exception for SQLite3 adapter | Ryuta Kamizono | 2017-01-16 | 2 | -45/+74 |
| | | | | | | | | | | | | | | | | | | Raise `ActiveRecord::InvalidForeignKey` when a record cannot be inserted or updated because it references a non-existent record for SQLite3 adapter. | ||||
* | | | Merge pull request #27692 from y-yagi/make_render_work_with_ac_params | Eileen M. Uchitelle | 2017-01-16 | 2 | -2/+5 |
|\ \ \ | | | | | | | | | make `render` work with AC::Params | ||||
| * | | | make `render` work with AC::Params | yuuji.yaginuma | 2017-01-15 | 2 | -2/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 4.2, since AC::Params inherited `Hash`, processing in the case of `Hash` was done. But in 5.x, since AC::Params does not inherit `Hash`, need to add care for AC::Params. Related to 00285e7cf75c96553719072a27c27e4ab7d25b40 | ||||
* | | | | Merge pull request #27695 from metaskills/sqlserver-testparticipation | Eileen M. Uchitelle | 2017-01-16 | 3 | -4/+4 |
|\ \ \ \ | | | | | | | | | | | Allow SQLServerAdapter To Opt Into A Few Tests | ||||
| * | | | | Allow SQLServerAdapter to opt into a few tests. | Ken Collins | 2017-01-16 | 3 | -4/+4 |
| | |/ / | |/| | | |||||
* | | | | Merge pull request #27699 from kenta-s/update-comment-for-scrubber-usage | Kasper Timm Hansen | 2017-01-16 | 1 | -6/+4 |
|\ \ \ \ | |/ / / |/| | | | Update comment for Scrubber usage [ci skip] | ||||
| * | | | Update comment for Scrubber usage [ci skip] | kenta-s | 2017-01-16 | 1 | -6/+4 |
| | |/ | |/| | |||||
* | | | Added test to ensure that we dont break #to_h again when trying to restore ↵ | David Heinemeier Hansson | 2017-01-16 | 1 | -0/+5 |
| | | | | | | | | | | | | the speed-up from 26dd9b26ab7317f94fd285245879e888344143b2 (cc: @fxn) | ||||
* | | | Revert "significant speedup of AC::Parameters#permit" ↵ | David Heinemeier Hansson | 2017-01-16 | 2 | -8/+1 |
| | | | | | | | | | | | | [26dd9b26ab7317f94fd285245879e888344143b2] as it broke Parameters#to_h on at least fields_for-style nested params. | ||||
* | | | Add missing require | David Heinemeier Hansson | 2017-01-16 | 1 | -0/+1 |
|/ / | | | | | | | This was preventing the test suite from being run in isolation | ||||
* | | Should do nothing here | Akira Matsuda | 2017-01-16 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #27683 from eugeneius/update_counters_empty_touch_test | Kasper Timm Hansen | 2017-01-15 | 1 | -0/+9 |
|\ \ | | | | | | | Add test for update_counters with empty touch array |