| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Avoid bundler 1.16.0 for now
|
| |
| |
| |
| |
| | |
It's causing bug report template tests to fail. https://travis-ci.org/rails/rails/jobs/295520851
This seems an issue of bundler. Ref: https://github.com/bundler/bundler/issues/6072
|
| |
| |
| |
| | |
https://travis-ci.org/rails/rails/jobs/295470534#L2133
|
|/
|
|
| |
Follow up of #31004.
|
|\
| |
| | |
Address incorrect number of queries executed at Oracle enhanced adapter
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This pull request addresses these 17 failures when tested with Oracle enhanced adapter.
All of these failures are due to the incorrect number of queries. Here is the first one.
```ruby
$ ARCONN=oracle bin/test test/cases/nested_attributes_test.rb:1086
Using oracle
Run options: --seed 27985
F
Finished in 0.874514s, 1.1435 runs/s, 1.1435 assertions/s.
1) Failure:
TestHasManyAutosaveAssociationWhichItselfHasAutosaveAssociations#test_circular_references_do_not_perform_unnecessary_queries [/home/yahonda/git/rails/activerecord/test/cases/nested_attributes_test.rb:1086]:
6 instead of 3 queries were executed.
Queries:
select us.sequence_name from all_sequences us where us.sequence_owner = :owner and us.sequence_name = :sequence_name
INSERT INTO "SHIPS" ("NAME", "ID") VALUES (:a1, :a2)
select us.sequence_name from all_sequences us where us.sequence_owner = :owner and us.sequence_name = :sequence_name
INSERT INTO "SHIP_PARTS" ("NAME", "SHIP_ID", "UPDATED_AT", "ID") VALUES (:a1, :a2, :a3, :a4)
select us.sequence_name from all_sequences us where us.sequence_owner = :owner and us.sequence_name = :sequence_name
INSERT INTO "TREASURES" ("LOOTER_ID", "LOOTER_TYPE", "SHIP_ID", "ID") VALUES (:a1, :a2, :a3, :a4).
Expected: 3
Actual: 6
1 runs, 1 assertions, 1 failures, 0 errors, 0 skips
$
```
Since https://github.com/rsim/oracle-enhanced/pull/1490 Oracle enhanced adapter drops its own schema caching called OracleEnhancedAdapter.cache_columns` to use Rails scehema cache
generated by `db:schema:cache:dump`.
By this change some extra sql statements executed at ActiveRecord unit test, which can be
fixed by adding the sql statement to `oracle_ignored`.
* All 17 failures fixed by this pull request:
```ruby
ARCONN=oracle bin/test test/cases/nested_attributes_test.rb:1086
ARCONN=oracle bin/test test/cases/locking_test.rb:308
ARCONN=oracle bin/test test/cases/locking_test.rb:365
ARCONN=oracle bin/test test/cases/dirty_test.rb:351
ARCONN=oracle bin/test test/cases/dirty_test.rb:334
ARCONN=oracle bin/test test/cases/autosave_association_test.rb:192
ARCONN=oracle bin/test test/cases/associations/has_many_associations_test.rb:950
ARCONN=oracle bin/test test/cases/associations/has_many_associations_test.rb:1059
ARCONN=oracle bin/test test/cases/autosave_association_test.rb:627
ARCONN=oracle bin/test test/cases/autosave_association_test.rb:607
ARCONN=oracle bin/test test/cases/autosave_association_test.rb:617
ARCONN=oracle bin/test test/cases/autosave_association_test.rb:641
ARCONN=oracle bin/test test/cases/associations/has_many_through_associations_test.rb:546
ARCONN=oracle bin/test test/cases/associations/has_many_through_associations_test.rb:297
ARCONN=oracle bin/test test/cases/associations/has_many_through_associations_test.rb:586
ARCONN=oracle bin/test test/cases/associations/has_many_through_associations_test.rb:172
ARCONN=oracle bin/test test/cases/associations/has_many_through_associations_test.rb:269
```
|
|/
|
| |
Closes #31018
|
|\
| |
| | |
Prevent source line wrapping in rescue layout
|
|/
|
|
|
|
| |
Long source lines cause line wrapping in the extracted
source section of the rescue handler page which can make
the line numbers not match up with the source lines.
|
|\
| |
| | |
Remove redundant return statements
|
| | |
|
|\ \
| | |
| | | |
Remove unused `MissingRequestError`
|
| | |
| | |
| | |
| | | |
`MissingRequestError` is no longer used since 1e2b0ce.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`join_scopes` in `PolymorphicReflection` is passed aliased `table`, so
it should be respected for `source_type_scope`.
Closes #13969.
Fixes #13920.
Fixes #15190.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Call Rails.ajax without beforeSend
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip]Update the documentation about the primary key type
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
Replace the primary key type `integer` in docs with `bigint`.
ref #26266
|
|\ \ \ \
| | | | |
| | | | | |
5_1_release_notes include more removals [ci skip]
|
| | |/ /
| |/| |
| | | |
| | | | |
:nothing in render
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Removed unnecessary semicolons
|
| | |_|/
| |/| | |
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Add load hook for `ActionDispatch::SystemTestCase`
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is useful to extend `SystemTestCase`.
Also, since other test classes already have load hooks, should also be
in `SystemTestCase`.
Ref: 0510208dd1ff23baa619884c0abcae4d141fae53
|
|\ \ \
| | | |
| | | | |
Remove mention of X-Post-Data-Format header [ci skip]
|
| | |/
| |/|
| | |
| | |
| | | |
Support for this header was removed when `actionpack-xml_parser` was
extracted, and has since been dropped from the gem.
|
|/ /
| |
| | |
See: https://github.com/teamcapybara/capybara/blob/7d693f068c44f6a460336da70fb6e9e5f94f3db9/lib/capybara.rb#L450
|
| |
| |
| |
| |
| | |
- It is present in Rails 5.1.3 already.
- Backport commit https://github.com/rails/rails/commit/9efa0b70a638dcfdc05b30ab530f89f2847bb9c2
|
| |
| |
| |
| |
| |
| |
| | |
```
% git grep -n trough
activerecord/test/cases/associations/has_many_through_associations_test.rb:1253: def test_has_many_trough_with_scope_that_has_joined_same_table_with_parent_relation
```
|
| | |
|
|\ \
| | |
| | | |
delegate scope_for on PolymorphicReflection
|
| |/ |
|
|\ \
| |/
|/| |
fix initial count
|
|/ |
|
|\
| |
| | |
Allow passing a Proc or Symbol as an argument to length validator values
|
|/
|
|
|
| |
This brings the Length validator in line with the Numericality
validator, which currently supports Proc & Symbol arguments
|
|\
| |
| | |
Remove mention about Evented Redis [ci skip]
|
| |
| |
| |
| | |
Evented Redis adapter was removed in 48766e32d31651606b9f68a16015ad05c3b0de2c.
|
|\ \
| |/
|/| |
remove incorrect comment about serializable transactions [ci skip]
|
|/
|
| |
using serializable isolation would prevent the duplicate insert as done in the example from happening
|
|\
| |
| | |
Remove unused `secrets.yml` template
|
| |
| |
| |
| |
| | |
`secrets.yml` no longer used since #30067.
Together, removed `app_secret` method that only used in `secrets.yml`
|
| | |
|
|\ \
| | |
| | | |
Move `extensions` to `PostgreSQL::SchemaDumper`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
and abstract `SchemaDumper#extensions` is now an empty method.
Since #30337, every database adapter has its own `SchemaDumper`.
`extensions` are only supported by PostgreSQL database and postgresql database adapter.
|
| | |
| | |
| | | |
- Backport commit: https://github.com/rails/rails/commit/7122a2cdc3634e170129f8b6cabd1e8fbed13c3d
|
|\ \ \
| | | |
| | | |
| | | | |
Wrap accepted nested attributes params
|
| | | |
| | | |
| | | |
| | | | |
as well
|