| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| | |
Fix rails guides markdown.rb and renderer.rb to use custom header id
|
| | |
|
|\ \
| | |
| | | |
Improve phrasing of one sentence in the contributing guide
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Eagerly define attribute methods in production
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The attribute methods for a model are currently defined lazily the first
time that model is instantiated, even when `config.eager_load` is true.
This means the first request to use each model incurs the cost, which
usually involves a database round trip to fetch the schema definition.
By defining the attribute methods for all models while the application
is booting, we move that work out of any individual request. When using
a forking web server, this also reduces the number of times the schema
definition is queried by doing it once in the parent process instead of
from each forked process during their first request.
|
|\ \ \
| |/ /
|/| | |
update mini_magick to the latest version
|
|/ /
| |
| |
| |
| |
| |
| | |
v 4.9.2 avoids some warnings that show in our tests.
Although Gemfile.lock currently specifies 4.8.0, the CI already runs 4.9.2
so 4.8.0 warnings do not show in our CI logs.
|
| |
| |
| |
| | |
Similar to Action View's and Action Controller's instrument helpers.
|
| | |
|
|\ \
| | |
| | | |
Encode Content-Disposition filenames on send_data and send_file
|
| | | |
|
|\ \ \
| | | |
| | | | |
Remove private def
|
| | | | |
|
|\ \ \ \
| |_|_|/
|/| | | |
Added mandatory region and bucket
|
| |/ /
| | |
| | | |
The 'setup' section was misleadingly leaving out :bucket and :region in the sample, but servers don't start without them.
|
|\ \ \
| |/ /
|/| | |
Enable `Performance/UnfreezeString` cop
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In Ruby 2.3 or later, `String#+@` is available and `+@` is faster than `dup`.
```ruby
# frozen_string_literal: true
require "bundler/inline"
gemfile(true) do
source "https://rubygems.org"
gem "benchmark-ips"
end
Benchmark.ips do |x|
x.report('+@') { +"" }
x.report('dup') { "".dup }
x.compare!
end
```
```
$ ruby -v benchmark.rb
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]
Warming up --------------------------------------
+@ 282.289k i/100ms
dup 187.638k i/100ms
Calculating -------------------------------------
+@ 6.775M (± 3.6%) i/s - 33.875M in 5.006253s
dup 3.320M (± 2.2%) i/s - 16.700M in 5.032125s
Comparison:
+@: 6775299.3 i/s
dup: 3320400.7 i/s - 2.04x slower
```
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before this change this test was passing even if we revert #31135. The
reason for that is that `app 'development'` will load the environment in
the test process and it is happening before db_create_and_drop is
called.
This was not asserting that the environment was loaded in the db:create
task itself.
To test it we enhance the db:create task with a block that writes to a
tmp file the value of the config. If the environment is loaded before
that task enhancement runs the content of the file will have "true"
insteand of "false".
|
| | |
|
|\ \
| | |
| | | |
Let escape_javascript handle conversion to string
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This brings `escape_javascript` in line with the behavior of `json_escape` and
allows other value types to be output without needing explicit casting in the
view template.
Example:
<%= javascript_tag do %>
var locale = '<%== j I18n.locale %>'; // locale is a symbol
<% end %>
|
| | | |
|
|\ \ \
| | | |
| | | | |
[close #33907] Error when using "recyclable" cache keys with a store that does not support it
|
| | | |
| | | |
| | | |
| | | |
| | | | |
- Moving the `supports_cache_versioning?` check to a class method.
- Shorten the method doc.
- Expand on the error message.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
does not support it
If you are using the "in cache versioning" also known as "recyclable cache keys" the cache store must be aware of this scheme, otherwise you will generate cache entries that never invalidate.
This PR adds a check to the initialization process to ensure that if recyclable cache keys are being used via
```
config.active_record.cache_versioning = true
```
Then the cache store needs to show that it supports this versioning scheme. Cache stores can let Rails know that they support this scheme by adding a method `supports_in_cache_versioning?` and returning true.
|
|\ \ \ \
| | | | |
| | | | | |
Replace line items with chapters [ci skip]
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
Line items are a holdover from when orders were used in the examples
instead of books.
|
|\ \ \ \
| | | | |
| | | | | |
Add missing test case for `redirect_to` when request includes a port.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
schneems/schneems/collection-caching-easier-to-understand
[ci skip] document collection_caching.rb
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix missing curly brace in documentation
|
|/ / / / / /
| | | | | |
| | | | | | |
This example was just missing a closing curly brace to complete the closure 😄
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
Ignore psqlrc files when executing psql commands
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
psqlrc files can affect the execution of commands in ways that can hold
up execution by blocking or otherwise cause unexpected side effects and
should best be ignored when using psql programmatically.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Correct spelling in "Contributing to Ruby on Rails" guide [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
ambigity -> ambiguity
Related to #33891
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Make sure `assert_enqueued_with()` & `assert_performed_with()` work reliably with hash arguments
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The test helpers now treat `{ a: 1, b: 2 }` and `{ b: 2, a: 1 }` as equals
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Contributing to Ruby on Rails Guide: standardize git remote names [ci skip].
|
| | | | | | | |
|
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | | |
Since #33875, Rails dropped supporting MySQL 5.1 which does not support
utf8mb4. We no longer need to use legacy utf8 (utf8mb3) conservatively.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
CI against PostgreSQL 10
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- Replace port number 5433 to 5432 (default value) which Active Record unit tests expect
- Restart PostgreSQL 10 service after changing port number
- PostgreSQL 10 is a addon for the current Travis CI. Installing
PostgreSQL 10 would cause longer CI to getting additional apt packages
Refer https://docs.travis-ci.com/user/database-setup/#PostgreSQL
- Use `sudo: required` for railties CI expecting PostgreSQL is up and running
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Make a deep copy of the _default_attributes in column_defaults
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
When column_defaults is called it calls `value` on each instance of
Attribute inside the _default_attributes set. Since value is memoized in
the Attribute instance and that Attribute instance is shared across all
instances of a model the next call to the default value will be memozied
not running the proc defined by the user.
Fixes #33031.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Update MySQL server version and character set in Rails Guide [skip ci]
|
| | |/ / / / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | | |
Related to #33853
|