Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | PERF: more Hash + map changes | Santiago Pastorino | 2010-10-03 | 1 | -3/+3 |
| | |||||
* | PERF: more changes from inject({}) to Hash + map | Santiago Pastorino | 2010-10-03 | 1 | -1/+1 |
| | |||||
* | PERF: Don't create unnecessary objects | Santiago Pastorino | 2010-10-03 | 1 | -1/+1 |
| | |||||
* | PERF: change inject({}) with Hash + map | Santiago Pastorino | 2010-10-03 | 1 | -1/+1 |
| | |||||
* | PERF: Hash[] + map is faster than this silly inject, and var[1..-1] is ↵ | Santiago Pastorino | 2010-10-03 | 1 | -3/+3 |
| | | | | faster than var.sub('@', '') | ||||
* | Rename _assigns to view_assigns in AV::TC | David Chelimsky | 2010-10-03 | 2 | -9/+52 |
| | | | | | | | | | - also add tests - also deprecate _assigns [#5751 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Be more explicit about what is deprecated. | José Valim | 2010-10-02 | 1 | -1/+1 |
| | |||||
* | Deprecate generators in Railties. You should use app_generators instead. | José Valim | 2010-10-02 | 3 | -30/+32 |
| | |||||
* | :'' is not valid ruby. | José Valim | 2010-10-02 | 1 | -1/+1 |
| | |||||
* | added test for form_for with search_field | Aditya Sanghi | 2010-10-02 | 1 | -0/+15 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fixing search_field to remove object attribute from options hash [#5730 ↵ | Aditya Sanghi | 2010-10-02 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | reload_routes! is part of the public API and should not be removed. | José Valim | 2010-10-02 | 3 | -3/+16 |
| | |||||
* | Fix a routing test. Reorganize middleware tests. | José Valim | 2010-10-02 | 7 | -151/+180 |
| | |||||
* | Refactor AssociationCollection#include? with objects in memory | Carlos Antonio da Silva | 2010-10-02 | 1 | -4/+3 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Perf: refactor _assign method to avoid inject and defining unneeded ↵ | José Valim | 2010-10-02 | 1 | -1/+5 |
| | | | | | | | | local var." _assigns must return a hash. This reverts commit e66c1cee86aba1c81152f3d0872313e65cec85a9. | ||||
* | removing more duplicate code. :'( | Aaron Patterson | 2010-10-01 | 1 | -13/+1 |
| | |||||
* | fixing warnings with regexps on assert_match | Aaron Patterson | 2010-10-01 | 1 | -2/+2 |
| | |||||
* | removing more duplicate code | Aaron Patterson | 2010-10-01 | 3 | -30/+17 |
| | |||||
* | delete repeated code | Aaron Patterson | 2010-10-01 | 3 | -36/+18 |
| | |||||
* | remove another lolinject | Aaron Patterson | 2010-10-01 | 1 | -1/+1 |
| | |||||
* | use a method that actually exists | Aaron Patterson | 2010-10-01 | 1 | -1/+1 |
| | |||||
* | speed up index_by by removing a lolinject | Aaron Patterson | 2010-10-01 | 1 | -4/+1 |
| | |||||
* | removing AS::Testing::Default in favor of just undefing default_test | Aaron Patterson | 2010-10-01 | 4 | -20/+2 |
| | |||||
* | brings csrf_meta_tags back to the generated layout | Xavier Noria | 2010-10-02 | 2 | -2/+2 |
| | | | | | | | | | | After more discussion, it has be agreed that this kind of changes within reasonable margins are OK for 3.1. That is, it is fine to change a little bit the generators even if that means examples in existing books won't be exact. (Note that the singular csrf_meta_tag exists as an alias and thus those outdated examples will run, same for existing applications.) | ||||
* | Arel::Sql::Engine.new does not do anything anymore | Aaron Patterson | 2010-09-30 | 2 | -2/+2 |
| | |||||
* | type_name should check for blank because people may have messed up databases | Aaron Patterson | 2010-09-30 | 2 | -1/+15 |
| | |||||
* | build_where should be private | Aaron Patterson | 2010-09-30 | 1 | -2/+2 |
| | |||||
* | type_name is never a blank string, so use faster .nil? call | Aaron Patterson | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | AssociationCollection#include? working properly for objects added with build ↵ | Marcelo Giorgi | 2010-09-30 | 4 | -0/+39 |
| | | | | method [#3472 state:resolved] | ||||
* | speeding up object instantiation by eliminating instance_eval | Aaron Patterson | 2010-09-30 | 1 | -7/+21 |
| | |||||
* | changing map and include to find | Aaron Patterson | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | [#5441 state:resolved] refactoring code to determine aggregate column | Aaron Patterson | 2010-09-30 | 1 | -11/+14 |
| | |||||
* | group clause must be more specific | Aaron Patterson | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | Tests proving #5441 | oleg dashevskii | 2010-09-30 | 1 | -1/+11 |
| | |||||
* | Fix 'rake db:create' is ignore encoding when using postgres [#5717 ↵ | yalab | 2010-09-30 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | no need to check for nil | Neeraj Singh | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | assert on empty array is always true. fixing test. | Neeraj Singh | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | Revert "removing crazy finalizer code until there is proof that we need it" | José Valim | 2010-09-30 | 1 | -0/+11 |
| | | | | This reverts commit a40e3c1a9604ab3737ad2465c8f6a6db0fe0cc78. | ||||
* | Add more information to comments. | José Valim | 2010-09-30 | 1 | -3/+5 |
| | |||||
* | Merge remote branch 'drogus/engines' | José Valim | 2010-09-30 | 11 | -47/+289 |
|\ | |||||
| * | Try to guess application's directory while trying to run the server, but ↵ | Piotr Sarnacki | 2010-09-30 | 1 | -0/+5 |
| | | | | | | | | only if config.ru is not present in current dir | ||||
| * | Moved Rails::RoutesReloader to Rails::Application::RoutesReloader | Piotr Sarnacki | 2010-09-30 | 3 | -56/+57 |
| | | |||||
| * | Allow running generators for Engine with usage of other application. | Piotr Sarnacki | 2010-09-30 | 1 | -1/+11 |
| | | | | | | | | | | | | | | | | After that commit, developers can set ENGINE_PATH in ENGINE/scripts/rails file and load application's ./script/rails (most of the time it will be dummy application used for testing). When running ./script/rails g it will use application to boot up, but then it will use Engine's root and configuration for generators. | ||||
| * | Added config.app_generators to allow configuring application's generators ↵ | Piotr Sarnacki | 2010-09-30 | 5 | -5/+58 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from railties. With config.generators becomes a way to configure generators for current instance only. For example: module Blog class Engine < Rails::Engine config.generators do |g| g.orm :active_record end config.app_generators do |g| g.test_framework :rspec end end end such definition sets :active_record as orm for engine and :rspec as test_framework for application. The values set with app_generators can be overwritten in application using config.generators as you would normally do: module MyApp class Application < Rails::Application config.generators do |g| g.test_framework :test_unit end end end | ||||
| * | Move routes_reloader to a class: RoutesReloader | Piotr Sarnacki | 2010-09-30 | 3 | -23/+57 |
| | | |||||
| * | Properly reload routes defined in class definition | Piotr Sarnacki | 2010-09-30 | 4 | -6/+63 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sometimes it's easier to define routes inside Engine or Application class definition (e.g. one file applications). The problem with such case is that if there is a plugin that has config/routes.rb file, it will trigger routes reload on application. Since routes definition for application is not in config/routes.rb file routes_reloader will fail to reload application's routes properly. With this commit you can pass routes definition as a block to routes method, which will allow to properly reload it: class MyApp::Application < Rails::Application routes do resources :users end end | ||||
| * | Allow mounting engines at '/' | Piotr Sarnacki | 2010-09-30 | 2 | -17/+78 |
| | | | | | | | | | | Without that commit script_name always become '/', which results in paths like //posts/1 instead of /posts/1 | ||||
| * | Do not overwrite _railtie method on namespace while creating isolated engine ↵ | Piotr Sarnacki | 2010-09-30 | 2 | -12/+33 |
|/ | | | | | | | | | or application. In order to run Engine as standalone application, you will need Rails::Application instance in the same namespace that engine one. It's very important to leave _railtie bound to whatever used "namespace" method first. | ||||
* | Use .find here as it is simpler and faster. | José Valim | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | avoid creating a block if possible | Aaron Patterson | 2010-09-29 | 1 | -2/+2 |
| |