| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| |
| | |
Fix issue with reaping_frequency type.
|
| |
| |
| |
| |
| |
| |
| |
| | |
When using DATABASE_URL to configure ActiveRecord, :reaping_frequency
does not get converted from a string to a numeric value. This value is
eventually passed to 'sleep' and must be numeric to avoid exceptions.
This commit converts :reaping_frequency to a float when present.
|
| |
| |
| |
| |
| | |
This constant may be define for auxiliar gems like rails-html-sanitizer
and these methods call will fail.
|
| | |
|
|\ \
| | |
| | | |
Add --skip-action-mailer (or -M) to rails generate
|
|/ / |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This code was there just to convert entries generated in Rails
4.0.0.beta1 applications to a supported format.
It is almost unlikely that any existent application have this cache
entry format in their caches at the point that Rails 5 will be released
so we don't need this code anymore.
|
| |
| |
| |
| |
| |
| |
| | |
We should convert when @v is defined not @value.
The test was calling value first that already converts the entry so we
are not catching this bug.
|
| |
| |
| |
| | |
So we can change the arity later.
|
| |
| |
| |
| |
| |
| |
| |
| | |
A few of the tests weren't testing anything of value. The IP Address
tests are testing the type, not behavior of the connection adapter.
There are two CVE regression tests which are important, but don't have a
good place to go, so I've left them alone for now, as they call `quote`
and the focus right now is removing `column` from `type_cast`
|
| |
| |
| |
| |
| |
| | |
The column itself has no actual impact on the return value. These were
actually testing the behavior of the type object, which is sufficiently
covered elsewhere.
|
| |
| |
| |
| |
| | |
The behavior tested by the removed lines is sufficiently covered
elsewhere.
|
| |
| |
| |
| |
| |
| | |
The string encoding test wasn't using the types for anything. The
boolean casting test included logic that should be in the tests for the
types, and the string test was legitimately not testing anything useful.
|
| | |
|
| |
| |
| |
| | |
The validator has access to richer type information
|
| |
| |
| |
| | |
SQL has mechanisms we can use to copy data from one table into another.
|
| |
| |
| |
| |
| |
| | |
As we move towards removing the types from the column objects, any
remaining places which have access to richer type information should be
using it.
|
| |
| |
| |
| |
| | |
The column is no longer used for anything besides type casting, which is
what we're trying to remove from the column entirely.
|
|\ \
| | |
| | | |
Update copyright notices to 2015 [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
Correctly use the response's status code calling head
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Commit 20fece1 introduced the `_status_code` method to fix calls to
`head :ok`. This method has been added on both ActionController::Metal
and ActionDispatch::Response.
As for the latter, this method is just equivalent to the `response_code`
one so commit aefec3c removed it from the `Reponse` object so call to
the `_status_code` method on an ActionController::Base instance would be
handled by the `Metal` class (which `Base` inherits from) but the status
code is not updated according to the response at this level.
The fix is to actually rely on `response_code` for ActionController::Base
instances but this method doesn't exist for bare Metal controllers so we
need to define it.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Indent the list content by 4 spaces instead of 2 to match the other
changelog files. Also wrap the lines around 80 chars.
Finally update the documentation example with nit-picky things.
|
|\ \ \ \
| | | | |
| | | | | |
Fixed typo in ActiveJob CHANGELOG [ci skip]
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix warning: assigned but unused variable - post
|
| |/ / / |
|
|\ \ \ \
| |_|/ /
|/| | | |
fix rake command typo in Testing guide [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Fix spell life cycle on activejob docs [ci skip]
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
Update Getting Started guide to reflect foreign key in migration [ci skip]
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
ActiveJob is not ActionJob [ci skip] :smile:
|
|/ / / |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Raise a better exception for renaming long indexes for mysql adapters
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
ActiveJob testing improvements
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
1. The :test adapter wasn't going through a full cycle of
serialize/deserialize when performing jobs. Now it does
2. Regular AJ tests were not run for the :test adapter. Now they are
3. ActiveJob::TestHelper uses assert_valid_keys but doesn’t requires
the file that implements that method. Now it does
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This error only happens when the foreign key is missing.
Before this fix the following exception was being raised:
NoMethodError: undefined method `val' for #<Arel::Nodes::BindParam:0x007fc64d19c218>
Now the message is:
ActiveRecord::UnknownAttributeError: unknown attribute 'foreign_key' for Model.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
ActiveJob: delegate deserialization to the job class
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
encapsulate env in the request so that we can eventually move away from
the env hash
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
this will help decouple us from using the rack env hash
|