aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Allow passing interpolations to `#default_i18n_subject`, e.g.:Olek Janiszewski2013-01-244-3/+31
| | | | | | | | | | | | | | | # config/locales/en.yml en: user_mailer: welcome: subject: 'Hello, %{username}' # app/mailers/user_mailer.rb class UserMailer < ActionMailer::Base def welcome(user) mail(subject: default_i18n_subject(username: user.name)) end end
* Remove warning by using a custom coderAndrew White2013-01-231-2/+16
| | | | | | | | | | | | | | The native JSON library bypasses the `to_json` overrides in active_support/core_ext/object/to_json.rb by calling its native implementation directly. However `ActiveRecord::Store` uses a HWIA so `JSON.dump` will call our `to_json` instead with a `State` object for options rather than a `Hash`. This generates a warning when the `:encoding`, `:only` & `:except` keys are accessed in `Hash#as_json` because the `State` object delegates unknown keys to `instance_variable_get` in its `:[]` method. Workaround this warning in the test by using a custom coder that calls `ActiveSupport::JSON.encode` directly.
* Merge pull request #9035 from adomokos/aligning_testsCarlos Antonio da Silva2013-01-231-0/+8
|\ | | | | Adding the route_key and param_key tests
| * Adding the route_key and param_key testsAttila Domokos2013-01-221-0/+8
| | | | | | This way all the tests are testing the same fields
* | A test case name needs to start with "test_"Akira Matsuda2013-01-231-1/+1
| |
* | Fix some wrong String extensions testsAkira Matsuda2013-01-231-7/+9
| | | | | | | | | | | | * ASCII_STRING was not an ASCII String * BYTE_STRING was not an in valid UTF-8 String * added an assertion for non-UTF-8 String
* | Test String#dasherizeAkira Matsuda2013-01-231-0/+6
| |
* | Test that rescue_from accepts a class name in StringAkira Matsuda2013-01-231-2/+1
| |
* | Test Kernel#quietlyAkira Matsuda2013-01-231-0/+12
| |
* | Test try! with a blockAkira Matsuda2013-01-231-0/+4
| |
* | Test that DeprecatedConstantProxy does not warn when accessing its classAkira Matsuda2013-01-231-0/+1
| |
* | Missing AS::Deprecation::DeprecatedObjectProxy testAkira Matsuda2013-01-231-0/+5
| |
* | Test that a DateTime acts_like_dateAkira Matsuda2013-01-231-0/+4
|/
* Merge pull request #9031 from virusman/doc-no-asset-concatGuillermo Iguaran2013-01-222-125/+0
|\ | | | | Remove old asset tags API from docs
| * Remove old asset tags API from docs, reflecting changes from #7900virusman2013-01-232-125/+0
| |
* | Less strict activerecord-deprecated_finders versionRafael Mendonça França2013-01-221-1/+1
| |
* | Revert "Round usec when writing timestamp attribute."Andrew White2013-01-222-28/+5
| | | | | | | | | | | | | | | | | | | | This reverts commit e9d2ad395ec2ef929d74752f3d71c80674044fbe. Closes #8460 Conflicts: activerecord/lib/active_record/attribute_methods/time_zone_conversion.rb activerecord/test/cases/dirty_test.rb
* | Add failing test case for #8460Andrew White2013-01-221-0/+14
| | | | | | | | Add a test case to ensure that fractional second updates are detected.
* | Merge pull request #9027 from carlosantoniodasilva/revert-localeSteve Klabnik2013-01-225-37/+24
|\ \ | | | | | | Revert locale
| * | Revert "Merge pull request #7873 from steveklabnik/update_initializer"Carlos Antonio da Silva2013-01-222-9/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 43e14f8ff203c21646f733d35bdde4e68da70a3b, reversing changes made to bb17a0f085aba40a1952612f6c98b2a5804a1152. Conflicts: railties/lib/rails/generators/rails/app/templates/config/application.rb railties/lib/rails/generators/rails/app/templates/config/initializers/locale.rb Reason: setting the Time.zone in an after_initialize block can become a problem for people upgrading, since it's not going to be available when config/initializers run, and people might be relying on it. An example that I noticed was with the Chronic gem, for date/time parsing. It requires us to configure the time class to be Time.zone, and doing that in an initializer no longer worked with these changes, so reverting is the safer path for now.
| * | Revert "Set the default timezone after the initialization since the ↵Carlos Antonio da Silva2013-01-222-27/+15
| | | | | | | | | | | | | | | | | | configuration" This reverts commit 39374aa925a7d670b039c0c0c9aa9f4aef19466b.
| * | Revert "updating i18n guide with locale config location."Carlos Antonio da Silva2013-01-221-1/+1
| |/ | | | | | | This reverts commit 46902908910c041e268429d674bbe084399cc664.
* | Lets kepp using Ruby 1.9 syntaxRafael Mendonça França2013-01-222-37/+37
| |
* | Only check for unpermmited parameters ifRafael Mendonça França2013-01-221-1/+1
|/ | | | action_on_unpermitted_parameters is present
* avoid creating an object in every callXavier Noria2013-01-221-1/+2
| | | | This was a suggestion of @carlosantoniodasilva, thanks!
* Merge pull request #9026 from tricknotes/remove-unnecessary-requireXavier Noria2013-01-221-1/+0
|\ | | | | Remove unnecessary require
| * Remove unnecessary requireRyunosuke SATO2013-01-221-1/+0
|/ | | | `require 'rubygems'` is already required in Ruby 1.9 or later.
* Re-do Getting Started application with Rails 4.Steve Klabnik2013-01-2276-301/+404
| | | | | | | The sample application with the Getting Started Guide was very out of date. I've re-done it on edge (as of 51b9def5bf108fb566e) so it should be good to go with Rails 4. It's also in synch with what the guide actually says.
* fixing link to validations guide in getting started guideSteve Klabnik2013-01-221-4/+5
|
* Getting Started Guide: strong_parametersSteve Klabnik2013-01-222-8/+33
| | | | | Stuff didn't work because of strong_parameters. Now the right calls are in place.
* Fix images in getting started guide.Steve Klabnik2013-01-225-0/+0
| | | | | We changed the error style, so they're all wrong. Now they're right. :smile:
* Remove tabs, use spaces :scissors:Carlos Antonio da Silva2013-01-221-2/+2
| | | | [ci skip]
* Whitespaces :scissors:Rafael Mendonça França2013-01-222-19/+16
| | | | [ci skip]
* Merge pull request #8557 from timraymond/add_back_engines_and_deprecateRafael Mendonça França2013-01-225-5/+46
|\ | | | | | | | | | | | | Adding Back Rails::Engine::Railties#engines Conflicts: railties/CHANGELOG.md
| * Adding Back Rails::Engine::Railties#enginesTim Raymond2013-01-035-5/+46
| | | | | | | | | | Removing it breaks functionality with gems such as Thinking Sphinx. This restores it with a deprecation warning. Closes #8551
* | Merge branch 'isolating_tests'Akira Matsuda2013-01-227-28/+47
|\ \ | | | | | | | | | Now we're almost ready to remove this: https://github.com/rails/rails/blob/5294ad8/activesupport/lib/active_support/test_case.rb#L29
| * | Just ignore all PRAGMA queriesAkira Matsuda2013-01-221-1/+1
| | |
| * | Reset SchemaMigration after updatingAkira Matsuda2013-01-221-0/+1
| | |
| * | Restore I18n.locale after running testsAkira Matsuda2013-01-221-1/+7
| | |
| * | Make sure to reset default_url_optionsAkira Matsuda2013-01-221-1/+5
| | |
| * | Preload some join table schemasAkira Matsuda2013-01-221-0/+9
| | |
| * | Ignore schema queries on SQLite 3 as wellAkira Matsuda2013-01-221-1/+2
| | |
| * | Be sure to clear schema cacheAkira Matsuda2013-01-221-0/+3
| | |
| * | Ignore "SHOW search_path" when counting PostgreSQL queriesAkira Matsuda2013-01-221-1/+1
| | |
| * | Reset table_name_{prefix,suffix}, and table_name after each testAkira Matsuda2013-01-221-11/+4
| | | | | | | | | | | | because some tests were not resetting them, and thus the tests were order dependent
| * | Missing repair_validationsAkira Matsuda2013-01-221-12/+14
| | |
* | | Stylistic pass at form_helper_testRafael Mendonça França2013-01-211-286/+362
| | |
* | | Capture block so content won't leak.José Mota2013-01-213-4/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The [following pull request](https://github.com/rails/rails/pull/8916) fixed the block being passed to the appropriate helper method. However, the content being passed into the block is generating repeated markup on the page due to some weird ERb evaluation. This commit tries to capture the block's generated output so the page isn't flooded with markup. [Rafael França + José Mota] Closes #8936
* | | Update actionpack's CHANGELOG for 445f14ePiotr Sarnacki2013-01-211-0/+5
| | |
* | | Merge pull request #9021 from drogus/fix-asset-pathGuillermo Iguaran2013-01-212-2/+10
|\ \ \ | |/ / |/| | Fix asset_path in mounted engine
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-17 06:34:55 +0000