aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use run_callbacks; the generated _run_<name>_callbacks method is not a ↵John Firebaugh2011-01-3114-31/+28
| | | | | | public interface. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Run BulkAlterTableMigrationsTest only when the adapter supports themPratik Naik2011-01-311-97/+99
|
* Add :bulk => true option to change_tablePratik Naik2011-01-317-65/+316
|
* Make use of helpers in AssociationReflectionJon Leighton2011-01-301-4/+4
|
* Has many through - It is not necessary to manually merge in the conditions ↵Jon Leighton2011-01-304-6/+16
| | | | hash for the through record, because the creation is done directly on the through association, which will already handle setting the conditions.
* @join_table_name is no longer usedJon Leighton2011-01-301-2/+1
|
* Make AssociationCollection#include? a bit more readableJon Leighton2011-01-301-4/+10
|
* Don't use method_missing when we don't have toJon Leighton2011-01-301-2/+2
|
* AssociationCollection#clear can basically just use #delete_all, except it ↵Jon Leighton2011-01-302-16/+13
| | | | should return self.
* AssociationCollection#to_ary should definitely dup the target! Also changed ↵Jon Leighton2011-01-302-3/+10
| | | | #replace which was previously incorrect, but the test passed due to the fact that to_a was not duping.
* Just use primary_key here, AR::Relation will resolve the ambiguity before it ↵Jon Leighton2011-01-301-1/+1
| | | | is converted to SQL
* Call sum on the scope directly, rather than relying on method_missing and ↵Jon Leighton2011-01-301-2/+2
| | | | calculate
* Condense first_or_last a bit moreJon Leighton2011-01-301-7/+5
|
* Get rid of separate reset_target! and reset_scopes_cache! methodsJon Leighton2011-01-301-26/+17
|
* target is always an arrayJon Leighton2011-01-301-5/+0
|
* load_target will return the target. it also will not load if loaded? is true.Jon Leighton2011-01-301-2/+1
|
* DRY up first/last and hence make last benefit from the bugfix in firstJon Leighton2011-01-302-15/+19
|
* Use scoped.find directly rather than having a find_by_sql methodJon Leighton2011-01-301-5/+1
|
* Use scoped.first and scoped.last instead of find(:first, ...) and ↵Jon Leighton2011-01-301-2/+2
| | | | find(:last, ...)
* Try to make fetch_first_or_last_using_find? more readableJon Leighton2011-01-301-2/+20
|
* load_target returns the targetJon Leighton2011-01-301-2/+1
|
* Rename AssociationProxy#loaded to loaded! as it mutates the associationJon Leighton2011-01-306-10/+10
|
* Abstract load_target conditional logicJon Leighton2011-01-302-6/+7
|
* Remove unused methods conditions, sql_conditions and sanitize_sqlJon Leighton2011-01-301-12/+0
|
* Don't pass around conditions as strings in ThroughAssociationJon Leighton2011-01-301-30/+25
|
* Indent methods under private/protected sectionsJon Leighton2011-01-302-115/+115
|
* Let's be less blasé about method visibility on association proxiesJon Leighton2011-01-309-117/+135
|
* We shouldn't be using scoped.scoping { ... } to build associated records, as ↵Jon Leighton2011-01-306-17/+57
| | | | this can affect validations/callbacks/etc inside the record itself [#6252 state:resolved]
* Merge branch 'fix-gitignore' of https://github.com/telemachus/rails into ↵Mikel Lindsaar2011-01-301-1/+1
|\ | | | | | | telemachus-fix-gitignore
| * Minor fix to gitignore syntaxPeter Aronoff2011-01-141-1/+1
| |
* | Test non zero exit code and that a message still appears when generating ↵Philip Arndt2011-01-291-0/+11
| | | | | | | | inside an existing Rails directory.
* | Dir.chdir is not useful in this test, that was for another one I am planning ↵Philip Arndt2011-01-291-4/+3
| | | | | | | | to do.
* | Added test to ensure non zero exit codes when generating an application with ↵Philip Arndt2011-01-291-0/+7
| | | | | | | | | | | | a reserved name. Unfortunately, I can't find out how to suppress its output so we see ....Invalid application name test. Please give a name which does not match one of the reserved rails words.....................................
* | Exit with non-zero to signal failure.Philip Arndt2011-01-291-1/+1
| |
* | Use exit(1) instead of exit(false)Philip Arndt2011-01-291-2/+2
| |
* | Use Thor's self.exit_on_failure? to exit whenever accessing the generators ↵Philip Arndt2011-01-291-0/+12
| | | | | | | | from the CLI and a Thor::Error is raised.
* | Apply exit code 1 when commands don't succeed so that other libraries can ↵Philip Arndt2011-01-291-0/+2
| | | | | | | | properly detect the failure.
* | always return the identity function from type_cast_codeAaron Patterson2011-01-281-1/+1
| |
* | use an identity conversion to avoid conditional codesAaron Patterson2011-01-282-4/+4
| |
* | Fixing incorrectly writtent testcaseAlexey Nayden2011-01-281-2/+2
| |
* | Nested attributes and in-memory changed values #first and #[] behaviour ↵Alexey Nayden2011-01-281-1/+1
| | | | | | | | consistency fix
* | test_first_and_array_index_zero_methods_return_the_same_value_when_nested_at ↵Alexey Nayden2011-01-281-0/+9
| | | | | | | | tributes_are_set_to_update_existing_record added
* | make sure we play nicely when syck is activatedAaron Patterson2011-01-282-5/+30
| |
* | Psych correctly gets visitor for SafeBuffer from superclassbrainopia2011-01-281-2/+5
| |
* | Remove unneeded yaml_as declarationbrainopia2011-01-281-2/+0
| |
* | load psych by default if possibleAaron Patterson2011-01-281-0/+5
| |
* | Bump mail version upSantiago Pastorino2011-01-281-1/+1
| |
* | render_to_string must ensure that response_bodyNeeraj Singh2011-01-252-1/+11
| | | | | | | | | | | | | | | | is nil [ #5875 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | If I want to set respond_body to nil then itNeeraj Singh2011-01-251-1/+1
| | | | | | | | | | | | | | should be nil and not [nil]. If anything other than nil then wrap it in array Signed-off-by: José Valim <jose.valim@gmail.com>
* | A patch so that http status codes are still included in logs even during an ↵Doug Fales2011-01-252-1/+20
| | | | | | | | | | | | exception [#6333 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 21:14:42 +0000