aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix rendering of HTML partials inside JS templates [#4197 status:resolved]José Valim2010-03-163-3/+23
|
* fisting uninitialized ivar warnings. [#4198 state:resolved]Aaron Patterson2010-03-164-18/+21
| | | | Signed-off-by: wycats <wycats@gmail.com>
* translation method of TranslationHelper module returns always SafeBuffer ↵Santiago Pastorino2010-03-163-2/+10
| | | | | | [#4194 status:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* adds tests for #flush_output_bufferXavier Noria2010-03-161-2/+37
| | | | | | [#4196 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* adds tests for #captureXavier Noria2010-03-161-0/+23
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* clean up more warnings, remove unnecessary methods, fix eval line numbers. ↵Aaron Patterson2010-03-165-12/+13
| | | | | | [#4193 state:resolved] Signed-off-by: wycats <wycats@gmail.com>
* Some more tweaks on <% %>.Carlhuda2010-03-164-8/+8
| | | | * The cache helper is now semantically "mark this region for caching" * As a result, <% x = cache do %> no longer works
* Improve performance of multibyte utils.James Golick2010-03-161-1/+1
| | | | | | | Switch from using String#match to using String#=~. There's no need to generate a MatchData for each iteration since we're not using it. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Change functional tests to make use of a setup block.José Valim2010-03-161-5/+9
|
* Change array entries to safe doesn't worth then the array is joined as a ↵Santiago Pastorino2010-03-161-1/+1
| | | | | | string losing the safe property of his entries [#4134 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Deprecated framework rake tasks should exit with non-zero exit code [#4177 ↵Chris Griego2010-03-161-3/+3
| | | | | | status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Break a window :/Jeremy Kemper2010-03-155-7/+7
|
* RJS may cache an arrayJeremy Kemper2010-03-151-1/+1
|
* Fix link_to with blockJeremy Kemper2010-03-152-5/+2
|
* link_to_remote -> link_to :remote => trueJeremy Kemper2010-03-151-1/+1
|
* Swear I ran this testJeremy Kemper2010-03-151-1/+1
|
* Integration test url options should account for :protocol not just https?Jeremy Kemper2010-03-152-9/+8
|
* removing dead code from activerecord tests. [#4187 state:resolved]Aaron Patterson2010-03-154-46/+0
| | | | Signed-off-by: wycats <wycats@gmail.com>
* cleaning up a bunch of parse time warnings in AR [#4186 state:resolved]Aaron Patterson2010-03-159-26/+26
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Move more normalization up to the lookup context, so it does not have to ↵José Valim2010-03-164-38/+40
| | | | repeat in every resolver.
* Revert "Reinstate old default_url_options method signature"Jeremy Kemper2010-03-151-1/+1
| | | | This reverts commit 5913dd478150710fc0b72a0568f68e13c958d6bc.
* adds test coverage for with_output_bufferXavier Noria2010-03-151-3/+45
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Reinstate old default_url_options method signatureJeremy Kemper2010-03-151-1/+1
|
* Allow memcache-client 1.8.0Jeremy Kemper2010-03-151-1/+1
|
* Add deprecation notices for <% %>.Carlhuda2010-03-1515-97/+88
| | | | | | | | | | | | | | | | * The approach is to compile <% %> into a method call that checks whether the value returned from a block is a String. If it is, it concats to the buffer and prints a deprecation warning. * <%= %> uses exactly the same logic to compile the template, which first checks to see whether it's compiling a block. * This should have no impact on other uses of block in templates. For instance, in <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array, not a String, so the result is not concatenated * In two cases (#capture and #cache), a String can be returned that should *never* be concatenated. We have temporarily created a String subclass called NonConcattingString which behaves (and is serialized) identically to String, but is not concatenated by the code that handles deprecated <% %> block helpers. Once we remove support for <% %> block helpers, we can remove NonConcattingString.
* Hack to keep column metadata queries out of test query countsJeremy Kemper2010-03-151-0/+5
|
* with_output_buffer cannot assume there's an output_bufferXavier Noria2010-03-152-1/+7
| | | | | | [#4182 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* to_str works hereJeremy Kemper2010-03-152-6/+2
|
* CI: sudo rm to sledgehammer bad permsJeremy Kemper2010-03-151-1/+1
|
* Hack to keep column metadata queries out of test query countsJeremy Kemper2010-03-151-3/+7
|
* cleaning up many more warnings in activerecord [#4180 state:resolved]Aaron Patterson2010-03-154-3/+17
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Don't force singularization of singleton resource names, e.g. /preferences ↵Andrew White2010-03-152-8/+15
| | | | | | [#4089 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
* read_ and write_fragment cache preserve html safety yet cache strings onlyJeremy Kemper2010-03-142-6/+19
|
* speeding up clone_attributes, changing readonly to be initialized in def ↵Aaron Patterson2010-03-141-8/+9
| | | | | | initialize Signed-off-by: wycats <wycats@gmail.com>
* cleaning up some test warningsAaron Patterson2010-03-144-5/+16
| | | | Signed-off-by: wycats <wycats@gmail.com>
* There's a Ruby issue with File.basename different versions returns different ↵Santiago Pastorino2010-03-141-1/+0
| | | | things, so we shouldn't test that
* Making escaped things more readableSantiago Pastorino2010-03-143-3/+3
|
* Optimize DetailsKey generation.José Valim2010-03-141-4/+5
|
* restricts a test to < 1.9, and rewrites it using a proper expectationXavier Noria2010-03-132-11/+6
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Ensure controller filters are executed before stuff starts to happen.José Valim2010-03-133-3/+21
|
* Remove formats setters from render template, speeding up partial and ↵José Valim2010-03-131-2/+1
| | | | collection renderings.
* adds coverage for the issue addressed in fe43bbdXavier Noria2010-03-121-0/+14
| | | | | | [#4166 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* In app_generator, fix hardcoded `bundle` call to derive the bundle ↵Caio Chassot2010-03-122-3/+5
| | | | | | | | executable name from Thor::Util.ruby_command. This ensures that eg. when `rails` is called from `ruby1.9`, `bundle1.9` is called. Signed-off-by: José Valim <jose.valim@gmail.com>
* Add a check to ensure that the application name does not already exist, i.e. ↵Kieran Pilkington2010-03-122-0/+9
| | | | | | String or Module are part of ruby [#3872 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Made asset_tag_helper use config.perform_caching instead of ↵Denis Odorcic2010-03-122-32/+32
| | | | | | ActionController::Base.perform_caching Signed-off-by: José Valim <jose.valim@gmail.com>
* Prettify generators description whenever using the default stack [#4143 ↵José Valim2010-03-122-2/+20
| | | | status:resolved]
* keep AssociationProxy#to_a to avoid warning in Array(post.author), and ↵Xavier Noria2010-03-122-1/+2
| | | | | | | | delegate it to @target in association collections [#4165 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Load the environment before executing rails console. [#3905 status:resolved]José Valim2010-03-121-1/+1
|
* Revert "Always load the environment before executing any command. [#3905 ↵José Valim2010-03-122-6/+11
| | | | | | status:resolved]" This reverts commit 16846553b8866eab2aa3b128a2a23a221a25f7e3.
* Finish cleaning up rendering stack from views and move assigns evaluation to ↵José Valim2010-03-1215-75/+68
| | | | controller (so plugins and/or controllers can overwrite just one method).