| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \
| | | |
| | | | |
Fix memoization bug on ActionDispatch::TestRequest#request_method=
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
TestRequest have been overrriding request_method setter since 2009,
but the actual implementation in Request (not TestRequest) has been
changed since that. Now it's also using @request_method instance
variable to keep the state.
The override in TestRequest have not been calling `super`, which caused
a bug that after accessing #requst_method the value was memoized and
then we've never been able to change it anymore:
```
req = ActionDispatch::TestRequest.create
puts "was: #{req.request_method}" # memoized here
req.request_method = "POST"
puts "became: #{req.request_method}"
```
output:
```
was: GET
became: GET
```
Since the whole purpose of overriding the setter in TestRequest is to
upcase it, I'm changing it to `super(method.to_s.upcase)`
|
|\ \ \ \
| |_|/ /
|/| | | |
add check of argument
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`#fetch_multi` in case did not cache hit, to write a cache using the block value.
https://github.com/rails/rails/blob/master/activesupport/lib/active_support/cache.rb#L383..L384
Therefore, block is a need to pass always, I think should check first.
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] Replace to closing tag
|
| | | | | |
|
|\ \ \ \ \ |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
AC::Server::Base
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
behavior in 2.3.2, but dont specify that is not halting. Its better to not let developers be caught by surprise. [ci skip]
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Restore missing Gemfile.lock entries
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
These lines were lost in https://github.com/rails/rails/commit/12d5c210#diff-e79a60dc6b85309ae70a6ea8261eaf95L191.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
fix link to `resque` [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`1-x-stable` branch does not exist, `master` is 1.x branch.
Ref: http://words.steveklabnik.com/rescuing-resque-again
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Always store errors details information with symbols
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When the association is autosaved we were storing the details with
string keys. This was creating inconsistency with other details that are
added using the `Errors#add` method. It was also inconsistent with the
`Errors#messages` storage.
To fix this inconsistency we are always storing with symbols. This will
cause a small breaking change because in those cases the details could
be accessed as strings keys but now it can not.
The reason that we chose to do this breaking change is because `#details`
should be considered a low level object like `#messages` is.
Fix #26499.
[Rafael Mendonça França + Marcus Vieira]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Reduce array allocation when `where` with passed hash
|
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | |
| | | | | | |
In most case `where` is called with passed hash. In the case
initializing `binds` is unnecessary.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
use rails command in restart task test
|
| | |_|_|/ /
| |/| | | | |
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
Remove unnecessry `alias uniq distinct` for collection association
|
| | |/ / /
| |/| | |
| | | | |
| | | | | |
`CollectionAssociation` is internal class and `uniq` is not called.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] Fixed commas according to Oxford comma in rdoc and guides
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Rename variable name that returning `type_for` to `type` from `column`
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`column_for` was changed to `type_for` to return `type` object at
36bd52b4. But variable name is still `column`. It is very confusing.
Rename variable name `column` to `type` for readability.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Clear attribute changes after handling locking
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Without this the changes to the lock version column will stick around
even after `touch` returns.
Before:
model.touch
model.changes
# => {"lock_version"=>[0, "1"]}
After:
model.touch
model.changes
# {}
|
|\ \ \ \ \ \ \
| | |_|/ / / /
| |/| | | | | |
[ci skip] Fix bad examples in rdoc
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
fix formatting of `Cache::Store#fetch` [ci skip]
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | | |
Single backticks don't work with rdoc.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix small grammar issue introduced in #26382
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
improve error message when include assertions fail
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message
assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update ActiveModel::Dirty Doc to be simpler to understand
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Rename test to match what it does
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Commit d270da569 changed the `form_for` API from `:object_name` to `:as`.
It also change the related test body, but not its title, which is changed here.
See https://github.com/rails/rails/commit/d270da569efeabd7cd563028816452236713aa9f#diff-52455f1e82acf12551bc5e7e26b82008
I realize this is a small commit but I was having trouble understanding what
the test was about since there is no "object_name" in the code.
I imagine the same may happen to other developers, therefore this commit.
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
DRYing duplicate methods
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[fixes #26441]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
fix typo in `add_column` doc [ci skip]
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Update ActiveModel::Dirty Doc [ci skip]
|
|/ / / / / /
| | | | | |
| | | | | | |
Fix potentially misleading example.
|