aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Privatize constantsAlberto Almagro2018-10-111-4/+5
| | | | | This constants meant to be private but `private_constant` was missing, this commit makes them fully private by adding `private_constant`.
* Merge pull request #27 from ↵Rafael França2018-10-101-0/+28
|\ | | | | | | | | albertoalmagro/test-coverage-form-with-rich-text-area Add test coverage for form with rich_text_area
| * Add test coverage for form with rich-text-areaAlberto Almagro2018-10-101-0/+28
|/
* Remove set_action_text_renderer from dummy app (#26)Liroy Leshed2018-10-101-6/+0
| | | I don't think we need that since it's set automatically through ActionText::Engine.
* Prevent rich_text_area from raising when inexistent attribute is passed (#24)Alberto Almagro Sotelo2018-10-092-1/+22
| | | | | | | | When an inexistent attribute is passed as a parameter to currently existing Rails' Form Helpers they render an empty tag instead of raising an exception. This commit confers the same behavior to `rich_text_area`. Fixes #19
* Merge pull request #22 from albertoalmagro/add-frozen-string-literalJavan Makhmali2018-10-0928-0/+55
|\ | | | | Add frozen_string_literal: true
| * Add frozen_string_literal: trueAlberto Almagro2018-10-0828-0/+55
|/ | | | Adds frozen_string_literal: true comment on top of all currently existing files
* Test against Rails masterJavan Makhmali2018-10-082-64/+70
|
* Match Rails Ruby version requirementsJavan Makhmali2018-10-083-3/+9
|
* travis.yml → .travis.ymlJavan Makhmali2018-10-081-0/+0
| | | | 🤦‍♂️
* Upgrade Ruby version (#20)Alberto Almagro Sotelo2018-10-081-1/+1
| | | Upgrades .ruby-version to latest stable release
* Use the ASt representation APIGeorge Claghorn2018-10-071-5/+2
|
* Add travis.ymlJavan Makhmali2018-10-061-0/+11
|
* Merge pull request #17 from huacnlee/fix/uninitialized-constant-on-rails-reloadJavan Makhmali2018-10-061-5/+5
|\ | | | | Fix `uninitialized constant ActionText:: ALLOWED_TAGS` error on Rails reload
| * Fix `uninitialized constant ActionText:: ALLOWED_TAGS` error on Rails reloadingJason Lee2018-10-061-5/+5
| |
* | Merge pull request #18 from vendethiel/patch-1Javan Makhmali2018-10-061-1/+1
|\ \ | | | | | | Fix minor typo in code comment
| * | Fix minor typo in code commentven2018-10-061-1/+1
| |/
* / Add template for ActionText::Attachables::RemoteImageJavan Makhmali2018-10-062-15/+30
|/ | | | Fixes #15
* Fix has_rich_text with `:body` keywords error. (#16)Jason Lee2018-10-053-1/+7
|
* Merge pull request #14 from hakusaro/add-sanitized-wordDavid Heinemeier Hansson2018-10-041-1/+1
|\ | | | | Add "sanitized" to the readme
| * Add "sanitized" to the readmeLucas Nicodemus2018-10-041-1/+1
|/ | | | | | | I think a prime concern people have here is sanitization and security. Adding this word to the readme provides a little bit of clarity and reassurance that we aren't just rendering raw data trusted from the client.
* Merge pull request #9 from lucascaton/masterGuillermo Iguaran2018-10-041-4/+4
|\ | | | | Recommend use of `rails` over `bin/rails`
| * Recommend use of rails over bin/railsLucas Caton2018-10-041-4/+4
| | | | | | In order to make the recommendations consistent with Rails: https://github.com/rails/rails/commit/40b209db53
* | Delegate string methods to contentJavan Makhmali2018-10-043-9/+15
| | | | | | | | Closes #11
* | Merge pull request #10 from noma4i/patch-3Kasper Timm Hansen2018-10-041-2/+2
|\ \ | |/ |/| Consistency in naming
| * Consistency in namingAlexander Tsirel2018-10-041-2/+2
|/ | | after rails 5 its ApplicationController and ApplicationRecord
* Merge pull request #8 from georgeclaghorn/lazy-loadingDavid Heinemeier Hansson2018-10-031-3/+1
|\ | | | | Install Active Storage extension lazily
| * Install Active Storage extension lazilyGeorge Claghorn2018-10-031-3/+1
|/ | | | Avoid eagerly loading Active Record during app boot. Reinstall the extension when ActiveStorage::Blob is reloaded in dev.
* Declare prior to useDavid Heinemeier Hansson2018-10-031-4/+4
|
* The world is our stageDavid Heinemeier Hansson2018-10-033-3/+3
|
* Customize tag and attribute sanitizationJavan Makhmali2018-10-032-2/+6
| | | | Fixes #6
* Fix image gallery stylesJavan Makhmali2018-10-033-10/+39
|
* Fix content attachment testJavan Makhmali2018-10-035-1/+27
|
* Move attachment rendering to a helperJavan Makhmali2018-10-035-21/+31
| | | | Fixes #5
* WIP: Image gallery supportJavan Makhmali2018-10-034-7/+124
|
* Add default missing attachable templateJavan Makhmali2018-10-031-0/+1
|
* Add support for "presentation" gallery attributeJavan Makhmali2018-10-032-4/+5
|
* Fill in Attachable rich text attributesJavan Makhmali2018-10-031-1/+17
|
* Add a bit more documentationDavid Heinemeier Hansson2018-10-022-0/+27
|
* Flush out the READMEDavid Heinemeier Hansson2018-10-021-23/+65
|
* Copy over the blobs/_blob partial so it can be specializedDavid Heinemeier Hansson2018-10-021-0/+4
|
* Default sanitizationDavid Heinemeier Hansson2018-10-021-1/+1
|
* Uncomment failing testsJavan Makhmali2018-10-022-69/+69
|
* Add import statement to default pack file if relevantDavid Heinemeier Hansson2018-10-021-0/+9
|
* Use an app template installer instead for nicer overwriting checksDavid Heinemeier Hansson2018-10-022-26/+15
|
* Merge branch 'master' of github.com:basecamp/actiontextDavid Heinemeier Hansson2018-10-021-12/+1
|\
| * Now we add the npm dependency as part of the installerDavid Heinemeier Hansson2018-10-021-12/+1
| |
* | Add via yarn in the installerDavid Heinemeier Hansson2018-10-021-1/+6
| |
* | No need for the verbose warningDavid Heinemeier Hansson2018-10-021-6/+2
|/
* Fix <h1> plain text conversionJavan Makhmali2018-10-021-1/+1
| | | | Fixes #4