Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Privatize constants | Alberto Almagro | 2018-10-11 | 1 | -4/+5 |
| | | | | | This constants meant to be private but `private_constant` was missing, this commit makes them fully private by adding `private_constant`. | ||||
* | Merge pull request #27 from ↵ | Rafael França | 2018-10-10 | 1 | -0/+28 |
|\ | | | | | | | | | albertoalmagro/test-coverage-form-with-rich-text-area Add test coverage for form with rich_text_area | ||||
| * | Add test coverage for form with rich-text-area | Alberto Almagro | 2018-10-10 | 1 | -0/+28 |
|/ | |||||
* | Remove set_action_text_renderer from dummy app (#26) | Liroy Leshed | 2018-10-10 | 1 | -6/+0 |
| | | | I don't think we need that since it's set automatically through ActionText::Engine. | ||||
* | Prevent rich_text_area from raising when inexistent attribute is passed (#24) | Alberto Almagro Sotelo | 2018-10-09 | 2 | -1/+22 |
| | | | | | | | | When an inexistent attribute is passed as a parameter to currently existing Rails' Form Helpers they render an empty tag instead of raising an exception. This commit confers the same behavior to `rich_text_area`. Fixes #19 | ||||
* | Merge pull request #22 from albertoalmagro/add-frozen-string-literal | Javan Makhmali | 2018-10-09 | 28 | -0/+55 |
|\ | | | | | Add frozen_string_literal: true | ||||
| * | Add frozen_string_literal: true | Alberto Almagro | 2018-10-08 | 28 | -0/+55 |
|/ | | | | Adds frozen_string_literal: true comment on top of all currently existing files | ||||
* | Test against Rails master | Javan Makhmali | 2018-10-08 | 2 | -64/+70 |
| | |||||
* | Match Rails Ruby version requirements | Javan Makhmali | 2018-10-08 | 3 | -3/+9 |
| | |||||
* | travis.yml → .travis.yml | Javan Makhmali | 2018-10-08 | 1 | -0/+0 |
| | | | | 🤦♂️ | ||||
* | Upgrade Ruby version (#20) | Alberto Almagro Sotelo | 2018-10-08 | 1 | -1/+1 |
| | | | Upgrades .ruby-version to latest stable release | ||||
* | Use the ASt representation API | George Claghorn | 2018-10-07 | 1 | -5/+2 |
| | |||||
* | Add travis.yml | Javan Makhmali | 2018-10-06 | 1 | -0/+11 |
| | |||||
* | Merge pull request #17 from huacnlee/fix/uninitialized-constant-on-rails-reload | Javan Makhmali | 2018-10-06 | 1 | -5/+5 |
|\ | | | | | Fix `uninitialized constant ActionText:: ALLOWED_TAGS` error on Rails reload | ||||
| * | Fix `uninitialized constant ActionText:: ALLOWED_TAGS` error on Rails reloading | Jason Lee | 2018-10-06 | 1 | -5/+5 |
| | | |||||
* | | Merge pull request #18 from vendethiel/patch-1 | Javan Makhmali | 2018-10-06 | 1 | -1/+1 |
|\ \ | | | | | | | Fix minor typo in code comment | ||||
| * | | Fix minor typo in code comment | ven | 2018-10-06 | 1 | -1/+1 |
| |/ | |||||
* / | Add template for ActionText::Attachables::RemoteImage | Javan Makhmali | 2018-10-06 | 2 | -15/+30 |
|/ | | | | Fixes #15 | ||||
* | Fix has_rich_text with `:body` keywords error. (#16) | Jason Lee | 2018-10-05 | 3 | -1/+7 |
| | |||||
* | Merge pull request #14 from hakusaro/add-sanitized-word | David Heinemeier Hansson | 2018-10-04 | 1 | -1/+1 |
|\ | | | | | Add "sanitized" to the readme | ||||
| * | Add "sanitized" to the readme | Lucas Nicodemus | 2018-10-04 | 1 | -1/+1 |
|/ | | | | | | | I think a prime concern people have here is sanitization and security. Adding this word to the readme provides a little bit of clarity and reassurance that we aren't just rendering raw data trusted from the client. | ||||
* | Merge pull request #9 from lucascaton/master | Guillermo Iguaran | 2018-10-04 | 1 | -4/+4 |
|\ | | | | | Recommend use of `rails` over `bin/rails` | ||||
| * | Recommend use of rails over bin/rails | Lucas Caton | 2018-10-04 | 1 | -4/+4 |
| | | | | | | In order to make the recommendations consistent with Rails: https://github.com/rails/rails/commit/40b209db53 | ||||
* | | Delegate string methods to content | Javan Makhmali | 2018-10-04 | 3 | -9/+15 |
| | | | | | | | | Closes #11 | ||||
* | | Merge pull request #10 from noma4i/patch-3 | Kasper Timm Hansen | 2018-10-04 | 1 | -2/+2 |
|\ \ | |/ |/| | Consistency in naming | ||||
| * | Consistency in naming | Alexander Tsirel | 2018-10-04 | 1 | -2/+2 |
|/ | | | after rails 5 its ApplicationController and ApplicationRecord | ||||
* | Merge pull request #8 from georgeclaghorn/lazy-loading | David Heinemeier Hansson | 2018-10-03 | 1 | -3/+1 |
|\ | | | | | Install Active Storage extension lazily | ||||
| * | Install Active Storage extension lazily | George Claghorn | 2018-10-03 | 1 | -3/+1 |
|/ | | | | Avoid eagerly loading Active Record during app boot. Reinstall the extension when ActiveStorage::Blob is reloaded in dev. | ||||
* | Declare prior to use | David Heinemeier Hansson | 2018-10-03 | 1 | -4/+4 |
| | |||||
* | The world is our stage | David Heinemeier Hansson | 2018-10-03 | 3 | -3/+3 |
| | |||||
* | Customize tag and attribute sanitization | Javan Makhmali | 2018-10-03 | 2 | -2/+6 |
| | | | | Fixes #6 | ||||
* | Fix image gallery styles | Javan Makhmali | 2018-10-03 | 3 | -10/+39 |
| | |||||
* | Fix content attachment test | Javan Makhmali | 2018-10-03 | 5 | -1/+27 |
| | |||||
* | Move attachment rendering to a helper | Javan Makhmali | 2018-10-03 | 5 | -21/+31 |
| | | | | Fixes #5 | ||||
* | WIP: Image gallery support | Javan Makhmali | 2018-10-03 | 4 | -7/+124 |
| | |||||
* | Add default missing attachable template | Javan Makhmali | 2018-10-03 | 1 | -0/+1 |
| | |||||
* | Add support for "presentation" gallery attribute | Javan Makhmali | 2018-10-03 | 2 | -4/+5 |
| | |||||
* | Fill in Attachable rich text attributes | Javan Makhmali | 2018-10-03 | 1 | -1/+17 |
| | |||||
* | Add a bit more documentation | David Heinemeier Hansson | 2018-10-02 | 2 | -0/+27 |
| | |||||
* | Flush out the README | David Heinemeier Hansson | 2018-10-02 | 1 | -23/+65 |
| | |||||
* | Copy over the blobs/_blob partial so it can be specialized | David Heinemeier Hansson | 2018-10-02 | 1 | -0/+4 |
| | |||||
* | Default sanitization | David Heinemeier Hansson | 2018-10-02 | 1 | -1/+1 |
| | |||||
* | Uncomment failing tests | Javan Makhmali | 2018-10-02 | 2 | -69/+69 |
| | |||||
* | Add import statement to default pack file if relevant | David Heinemeier Hansson | 2018-10-02 | 1 | -0/+9 |
| | |||||
* | Use an app template installer instead for nicer overwriting checks | David Heinemeier Hansson | 2018-10-02 | 2 | -26/+15 |
| | |||||
* | Merge branch 'master' of github.com:basecamp/actiontext | David Heinemeier Hansson | 2018-10-02 | 1 | -12/+1 |
|\ | |||||
| * | Now we add the npm dependency as part of the installer | David Heinemeier Hansson | 2018-10-02 | 1 | -12/+1 |
| | | |||||
* | | Add via yarn in the installer | David Heinemeier Hansson | 2018-10-02 | 1 | -1/+6 |
| | | |||||
* | | No need for the verbose warning | David Heinemeier Hansson | 2018-10-02 | 1 | -6/+2 |
|/ | |||||
* | Fix <h1> plain text conversion | Javan Makhmali | 2018-10-02 | 1 | -1/+1 |
| | | | | Fixes #4 |