| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
The examples now take in consideration when Active Record finds inverse
associations automatically.
|
|\
| |
| | |
Handle param-parsing errors from Rack that happen low down the stack
|
|/ |
|
| |
|
|\
| |
| | |
add doc about how empty serialization objects are persisted
|
|/
|
| |
the test case for this commit is in cd3f5db
|
| |
|
|\
| |
| | |
DateTime#<=> return nil when compare to the invalid String as Time.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
before:
p Time.now == 'a' # => false
p Time.now <=> 'a' # => nil
require 'active_support'
require 'active_support/core_ext'
p Time.now == 'a' # => false
p Time.now <=> 'a' # => invalid date (ArgumentError)
and on ruby 2.2, Time.now == 'a' warning.
warning: Comparable#== will no more rescue exceptions of #<=> in the next release.
warning: Return nil in #<=> if the comparison is inappropriate or avoid such comparison.
after:
- Error handling.
- Quiet warnings.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If a getter has side effects on the DB, `changes_applied` will be called
twice. The second time will try and remove the changed attributes cache,
and will crash because it's already been unset. This also demonstrates
that we shouldn't assume that calling getters won't change the value of
`changed_attributes`, and we need to clear the cache if an attribute is
modified.
Fixes #20531.
|
|\ \
| | |
| | |
| | |
| | | |
knovoselic/active_support_concern_class_methods_fix
[ActiveSupport] Fix for #20489 - ActiveSupport::Concern#class_methods affects parent classes
|
| | | |
|
|\ \ \
| | | |
| | | | |
use our own runner for Rails framework components `bin/test`
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This adds a script `bin/test` to most Rails framework components. The
script uses the rails minitest plugin to augment the runner.
See https://github.com/rails/rails/pull/19571 for details about the
plugin.
I did not yet add `bin/test` for activerecord, activejob and railties.
These components rely on specific setup performed in the rake-tasks.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This makes it possible to easily get the runner working with existing
setups that rely on `active_support/testing/autorun.rb`.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Make remove_foreign_key reversible
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add prefix option to enum definition
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes #17511 and #17415
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
fix doc about foreign key name [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
this behavior was changed in b8e1f202676b4788c56241b124c401beff9f4014
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Update RDoc for ActionController::TestCase for kwargs.
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
add error log that notify 'file not found' when using cache_digest dependency rake
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
cache_digests:dependency and cache_digests:nested_dependency tasks
|
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | | |
This looks to be just out of sync tests
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
fixed sring to be string in ActiveRecord::Base params documentation [ci skip]
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`serialize` makes the contract that if it is given a class name, it will
never return something other than an instance of that class. This means
that it must cast `nil` to the empty form of that object. As such, we
should then persist empty forms of that object as `nil`. While this is
techincally under the contract of
```
model.attribute = value
assert_equal model.attribute, model.tap(&:save).reload.attribute
```
which we can't actually test universally without property based testing,
it has come up more than once and is worth calling out specifically
since we aren't looking to change it.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
[Sean Griffin & jmondo]
|
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If the subtype provides custom schema dumping behavior, we need to defer
to it. We purposely choose not to handle any values other than an array
(which technically should only ever be `nil`, but I'd rather code
defensively here).
Fixes #20515.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Rails api
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
ParamsWrapper was initially removed from API controllers according to
the following discusision:
https://github.com/rails-api/rails-api/issues/33
However, we're including it again so Rails API devs can decide
whether to enable or disable it.
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|