| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
ActionCable, sometimes add_channel is not called.
|
| | |
|
|\ \
| | |
| | | |
Improve error message when record touch fails.
|
| | |
| | |
| | |
| | |
| | |
| | | |
The current error message only indicates that a touch can fail because the record is new. In practice, we saw cases where touches were failing because the record had been destroyed. `persisted?` checks `new_record?` *and* `destroyed?`. It was confusing to get a message about a new record when in reality we were destroying records.
I also included a helpful tip for users to consider using `persisted?`, `new_record?`, or `destroyed?` before touching.
|
|\ \ \
| | | |
| | | | |
Clarify Postgres initials. [skip ci]
|
|/ / / |
|
|\ \ \
| |/ /
|/| | |
Update Rails 5 release notes with syntax fixes. [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
Fix typo: accidently -> accidentally. [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
remove needless comments
|
| | |
| | |
| | |
| | | |
Follow up to #25240.
|
|\ \ \
| | | |
| | | | |
Correct guide generation command [ci skip]
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Remove unused `predicate_builder` for `BasicObjectHandler` and `RangeHandler`
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
`partial` option on the digest method is no more needed [ci skip]:
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- `partial` option is not used anymore, this was removed in https://github.com/rails/rails/pull/23724
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
refer to rails command instead of rake in doc of `SourceAnnotationExtractor`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Clean backtrace in IRB
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
user/lib code
- Cleaned up backtrace cleaner test code and removed instaces variables
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add handling of cleaning up backtrace from IRB console in case of errors
|
| |/ / / /
|/| | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
fix task name to remove
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Follow up to #25431
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
bquorning/optimize-for-first-result-and-remove-mysql-select_one
Remove #select_one from Mysql2Adapter
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If you only want the last element of a result set, there's no need to create all
of hash_rows. Also, add a test.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The implementation from abstract/database_statements.rb seems to work just fine.
And with ActiveRecord::Result now implementing an optimized #first method, the
performance concerns previously addressed in
https://github.com/rails/rails/commit/bf79aa4fc14aeb2646331e767038acf0b77e9e7f
should not be an issue.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When you only need the first element of a result set, you shouldn't need to
instantiate all of hash_rows.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Renamed NestedParametersTest to NestedParametersPermitTest
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
what we are actually testing in this file
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata"
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This reverts commit 407e0ab5e5cddf6a8b6b278b12f50772d13b4d86.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Remove `create_table_info_cache` because it not be reused
|
| |/ / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
`create_table_info_cache` is used for sharing `create_table_info` both
`table_options` and `foreign_keys`. But `foreign_keys` no longer uses
`create_table_info_cache` by #25307. No need caching anymore.
|
| |_|_|_|/ / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Since bundler 1.12.0, the gemspec is validated so the `bundle install`
command will fail just after the gem is created causing confusion to the
users. This change was a bug fix to correctly validate gemspecs.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Do not depend on Rails git repository layout in ActiveSupport tests.
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|/ / /
|/| | | | | | | |
Pass `pk: false` to `connection.insert` explicitly if do not have a primary key
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Because causing an extra query by `sql_for_insert` for guessing a
primary key.
https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L121-L125
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
ActionDispatch::DebugLocks
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Only intended to be enabled when in use; by necessity, it sits above any
reasonable access control.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Don't inherit from Concurrent::CountDownLatch
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
That class mangles .new, which interferes with our deprecation warning.
More generally, it suggests we shouldn't be subclassing without a very
good reason, and avoiding one allocation doesn't seem to meet that
criteria.
In passing, recommend the simpler Concurrent::Event for the common
count=1 case.
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
close hijacked i/o socket after use (fixes #25613)
|
| | | | | | | | | | |
|
| | | | | | | | | | |
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
When an exception is raised, those Action View rendering logs are just
noise for the end developer. I recently silenced those from Web Console,
as we do use Action View rendering in it as well. It used created a half
a screen of rendering logs. I think we can save those in this recent
push for cleaner development logs.
Now, the silencing is a bit hacky and we have a bunch of it now, so we
can also invest in turning off the logs directly from Action View
objects instead of silencing off the logging stream.
|