| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Fix recreating partial indexes after alter table for sqlite
|
|/ |
|
|\
| |
| | |
Clarify that config.eager_load controls eager loading [ci skip]
|
|/
|
|
|
|
|
| |
Before Rails 4.0, `config.cache_classes` determined whether application
code was eager loaded. The `config.eager_load` option was introduced to
allow the two behaviours to be configured independently, but this
documentation was never updated to reflect that change.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can't replace existing SELECT list as long as having DISTINCT, it
will cause incorrect result.
And also, PostgreSQL has a limitation that ORDER BY expressions must
appear in select list for SELECT DISTINCT.
Therefore, we should not replace existing SELECT list when using
DISTINCT.
Fixes #29779.
|
|
|
|
| |
This broke the doc.
|
|\
| |
| |
| |
| | |
Aquaj/feature/allow-callables-in-select-group-methods
Allow the use of callable objects as group methods for grouped selects.
|
| |
| |
| |
| |
| |
| | |
Replaced the uses of `group.send(...)` in `option_groups_from_collection_for_select`
by calls to `value_for_collection(group, ...)`, allowing the use of
procs, lambdas and other callable objects as parameters.
|
| | |
|
|\ \
| | |
| | | |
let drb make temprary server
|
| | | |
|
|/ /
| |
| |
| | |
Ref: https://github.com/collectiveidea/delayed_job/blob/master/CHANGELOG.md#414---2017-12-29
|
| |
| |
| |
| | |
We can't replace existing select list as long as referenced by ORDER BY.
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Fix IE 10 and IE 11's broken `preventDefault` for rails-ujs
|
| | |
| | |
| | |
| | | |
https://github.com/turbolinks/turbolinks/issues/233
https://stackoverflow.com/questions/23349191/event-preventdefault-is-not-working-in-ie-11-for-custom-events
|
|/ /
| |
| |
| |
| | |
* `assert_header` and `assert_body` were unused since 6f6a589.
* `assert_success` and `assert_missing` were unused since added.
|
|\ \
| | |
| | | |
Update "Action View Overview" guide [ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | | |
- Provide full / Fix generated HTML by `form_for` in the example.
- Provide full params in the example.
- Express params[:person] in the sentence.
|
|\ \ \
| |/ /
|/| | |
CI against ruby 2.5.0
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| | |
Originally I tried to add `assert_equal pk.sql_type, ref.sql_type`. But
the assert failed even though the same type due to `sql_type` of primary
key in SQLite is upper case. Prefer lower case like other types.
|
|\ \
| | |
| | | |
Fix `add_column` with :primary_key type compatibility for SQLite
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
`invoke_all` cause `bundle install`. This will install gems actually
defined in `Gemfile`. To avoid this, stubbed `bundle_command`.
Fixes #31557
|
|\ \ \
| |/ /
|/| | |
Prevent shadowing outer variables
|
|/ / |
|
| |
| |
| |
| | |
And prefer `assert_same` over `assert_equal`.
|
|\ \
| | |
| | | |
Try to update rubygems 2.7.4
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | |
| | | |
mikelikesbikes/fix-update-attribute-callbacks-issue
save attributes changed by callbacks after update_attribute
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
update_attribute previously stopped execution, before saving and before
running callbacks, if the record's attributes hadn't changed. [The
documentation](http://api.rubyonrails.org/classes/ActiveRecord/Persistence.html#method-i-update_attribute)
says that "Callbacks are invoked", which was not happening if the
persisted attributes hadn't changed.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Puma gets bundler's info from `Bundler::ORIGINAL_ENV` for restart.
https://github.com/puma/puma/blob/f6f3892f4d82638fb7a2a57d993641b1486ee88a/lib/puma/launcher.rb#L168
So, specified `BUNDLE_GEMFILE` env for use same Gemfile in the restart.
Fixes #31351
|
| | |
| | |
| | |
| | | |
`skip_bundle` option was removed from plugin generator in 9b72fcc3c22a6f75f37f52dd6cb682bc00c51cf0.
|
| | |
| | |
| | |
| | |
| | | |
Fixes #31531
Closes #31540
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
JanBussieck/add-hwia-inheritance-removal-to-5.1-release-notes
[docs] Add mention of removal of HWIA interface from `AC:Parameters`
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | | |
For pass Active Job integration tests with Ruby 2.5.
Ref: https://github.com/collectiveidea/delayed_job/pull/996
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
yhirano55/add_cloud_service_links_to_readme_in_active_storage
Add cloud service's links to README of Active Storage [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | | |
mrreynolds/activestorage-combined-minimagick-options
Add support for combined MiniMagick transformations
|
| | | | | |
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | | |
This reverts commit 57f0e3d1300d01444d2a311560c055d26968dc3f.
|
|\ \ \ \
| | | | |
| | | | | |
Relax bundler version on Travis CI
|
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit b106242f52272c4a5ced7a0e9d1dcb1b50542501.
|
| | |/ /
| |/| | |
|
|/ / /
| | |
| | |
| | | |
Context: https://github.com/rails/rails/pull/29301#issuecomment-353200233
|