| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Besides making the code easier to read, this commit
also makes it faster:
* We don't eval `@base.class.respond_to?(:i18n_scope)` twice
* We only eval `@base.class.i18n_scope` once
* We don't call `flatten!` because it's not needed anymore
* We don't call `compact` because all elements are Symbols
|
|\
| |
| | |
Remove unused `action` arg for `generate_routing_code`
|
| | |
|
| |
| |
| |
| | |
thor 0.20.0 was released so we can test with the released version.
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| |
| | |
Changed sentence to be more clear
[ci skip]
|
| |
| |
| |
| |
| |
| | |
`it` and `has` are for singular, not plural
[ci skip]
|
| |
| |
| |
| |
| |
| | |
Periods should be outside of the <a> tags
[ci skip]
|
|\ \
| | |
| | | |
Change namespace of Active Storage rake task
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fix RuboCop offenses
|
| |/ /
| | |
| | |
| | | |
And enable `context_dependent` of Style/BracesAroundHashParameters cop.
|
|/ /
| |
| | |
Since c51f9b61 changed the "_before_type_cast" expectation for enum.
|
| |
| |
| |
| | |
Test case for #30045
|
|\ \
| | |
| | |
| | |
| | | |
albertoalmagro/fix-raise-unpermitted-parameters-regression
Load Parameters configurations on :action_controller only once
|
| | |
| | |
| | |
| | | |
Fixes regression ActionController::UnpermittedParameters not raised. The inner hook was being executed twice, once when ActionController::Base was loaded and again when ActionController::API was loaded. As options.delete operations inside the block are not idempotent, the second time it was run there was no configuration option available
|
| | |
| | |
| | |
| | | |
Provide run_once: true option to on_load in case you want a hook only to be executed once. This may be useful in cases where executing a hook several times may have undesired side effects
|
|\ \ \
| | | |
| | | | |
Add `--skip-yarn` option to the plugin generator
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Add SharedGeneratorTests#application_path
This method will help to DRY in files app_generator_test.rb, plugin_generator_test.rb
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
These were intentional, see
https://github.com/rails/rails/pull/30061#issuecomment-320068368
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
kamipo/through_scope_should_not_be_affected_by_scoping
Through scope should not be affected by scoping
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | | |
Follow up of #29834.
Fixes #30266.
|
|\ \ \ \
| | | | |
| | | | | |
Update guides/source/plugins.md [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
kamipo/dont_expose_write_attribute_without_type_cast
Don't expose `write_attribute_without_type_cast`
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
`write_attribute_without_type_cast` is defined as a private method in
`AttributeMethods::Write`, but `AttributeMethods::Dirty` overrode it as
a public method. It should be kept the original visibility.
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Inserted system_test ones into scaffolding logs [ci skip]
|
|/ / / / |
|
|\ \ \ \
| |/ / /
|/| | | |
Fix typo for api_app_generator_test
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
Add missing backticks
Add missing *
Add missing .
|
|\ \ \
| |_|/
|/| | |
Fix format of generator docs [ci skip]
|
|/ / |
|
|\ \
| | |
| | |
| | | |
Ensure sum honors distinct on has_many through
|
| | |
| | |
| | |
| | |
| | |
| | | |
When using a has_many through relation and then summing an attribute
the distinct was not being used. This will ensure that when summing
an attribute, the number is only used once when distinct has been used.
|
|\ \ \
| | | |
| | | | |
Clarify base_class tests on abstract STI vs concrete STI
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Add `binary` helper method to fixtures.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Refactor `--api` option of the app generator
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
It can't use JavaScript in api mode.
Action cable should be disabled by default.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix guide about command_line [ci skip]
|
| | |_|_|_|/
| |/| | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Extract `primary_key` to `AbstractReflection`
|
| | |_|_|/ /
| |/| | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix `reflection.association_primary_key` for `has_many` association
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
It is incorrect to treat `options[:primary_key]` as
`association_primary_key` if `has_many` associations because the
`:primary_key` means the column on the owner record, not on the
association record. It will break `ids_reader` and `ids_writer`.
```ruby
people(:david).essay_ids
# => ActiveRecord::StatementInvalid: Mysql2::Error: Unknown column 'essays.first_name' in 'field list': SELECT `essays`.first_name FROM `essays` WHERE `essays`.`writer_id` = 'David'
```
Fixes #14439.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Allow `serialize` with a custom coder on `json` and `array` columns
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
We already have a test case for `serialize` with a custom coder in
`PostgresqlHstoreTest`.
https://github.com/rails/rails/blob/v5.1.3/activerecord/test/cases/adapters/postgresql/hstore_test.rb#L316-L335
|