aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | Fixing incorrect class name used in an example.Kevin Jayanthan2015-03-021-1/+1
|/ / / / / / / / | | | | | | | | | | | | | | | | On "Controller Namespaces and Routing" section of the "Rails Routing from the Outside In" , the examples are using "AritclesController" as an example of a controller, to show different organizers. But on the line 232, it incorrectly uses "PostsController" instead of "AritclesController".
* | | | | | | | Merge pull request #19163 from JuanitoFatas/feautre/enumerable-without-take-2Richard Schneeman2015-03-012-2/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Use include? instead of in? for Enumerable#without.
| * | | | | | | | Use include? instead of in? for Enumerable#without.Juanito Fatas2015-03-022-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [egilburg]
* | | | | | | | | Merge pull request #19159 from stephenminded/docs_fix_polymorphic_indexArthur Nogueira Neves2015-03-011-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | [docs fix] Composite index is actually [:imageable_type, :imageable_id]
| * | | | | | | | | Composite index is [:imageable_type, :imageable_id] [ci skip]Steve Lounsbury2015-03-011-1/+1
| | | | | | | | | |
* | | | | | | | | | Move transaction code to transaction moduleArthur Neves2015-03-012-41/+41
| |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Remove parent transaction stateArthur Neves2015-03-012-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As far as I can tell nobody is setting this variable.
* | | | | | | | | Merge pull request #19161 from JuanitoFatas/fix/include-inclusionDavid Heinemeier Hansson2015-03-011-0/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Include object inclusion for enumerable test.
| * | | | | | | | | Include object inclusion for enumerable test.Juanito Fatas2015-03-021-0/+1
|/ / / / / / / / /
* | | | | | | | | Merge pull request #19157 from todd/enumerable_withoutDavid Heinemeier Hansson2015-03-015-0/+46
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Add Enumerable#without
| * | | | | | | | | Add Enumerable#withoutTodd Bealmear2015-03-015-0/+46
| | | | | | | | | |
* | | | | | | | | | remove useless conditionalAaron Patterson2015-03-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `@reflects_state[depth+1]` will always be nil because we haven't made a method call that would make it true yet.
* | | | | | | | | | refactor `handle_model` to use private helper methods for generationAaron Patterson2015-03-011-8/+6
| | | | | | | | | |
* | | | | | | | | | drop allocations for string and class polymorphic routesAaron Patterson2015-03-011-3/+3
| | | | | | | | | |
* | | | | | | | | | Merge pull request #19152 from tchandy/removing_unused_mailer_templatesCarlos Antonio da Silva2015-03-0118-50/+0
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Removing unused mailer templates
| * | | | | | | | | | Removing unused mailer templatesThiago Pradi2015-03-0118-50/+0
| | | | | | | | | | |
* | | | | | | | | | | drop string allocations per model url_for call in viewsAaron Patterson2015-03-011-1/+1
| |/ / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ```ruby article = Article.new.tap(&:save!) view.url_for article result = ObjectSpace::AllocationTracer.trace do 3000.times { view.url_for article } end p ObjectSpace::AllocationTracer.allocated_count_table[:T_STRING] / 3000 ```
* | | | | | | | | | Bump rack-test to fix nil values being sent to `parse_nested_query`eileencodes2015-03-012-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I found that nil values were being incorrectly sent to `parse_nested_query` in Rack. Originally it was thought that Rails was doing something incorrect but it was actually rack-test. This was fixed in brynary/rack-test@4a4b2c1 and is no longer an issue. This commit bumps rack-test in Rails so changes to Rack don't cause failures. See rack/rack#813 for more information.
* | | | | | | | | | move _generate_paths_by_default to where it is usedAaron Patterson2015-03-012-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | _generate_paths_by_default wasn't used in AD::Routing::UrlFor, so we should be able to move it where it is used in AV::Routing
* | | | | | | | | | Merge pull request #19153 from stephenminded/docs_fix_polymorphic_indexAbdelkader Boudih2015-03-011-1/+1
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| / / / / / / / / | |/ / / / / / / / [docs fix] Indexing a polymorphic assoc adds index on type and id
| * / / / / / / / Indexing a polymorphic assoc adds index on type and id [ci skip]Steve Lounsbury2015-03-011-1/+1
|/ / / / / / / /
* | | | | | | | Merge pull request #19149 from yui-knk/fix/4_0_release_notes2Rafael Mendonça França2015-03-011-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | [ci skip] Fix fenced code block lang
| * | | | | | | | [ci skip] Fix fenced code block langyui-knk2015-03-021-1/+1
|/ / / / / / / /
* | | | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-03-013-3/+20
|\ \ \ \ \ \ \ \
| * | | | | | | | Explained how to set session expiry through session_store configIain Beeston2015-02-273-3/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most session stores offer an :expire_after option, but it's largely undocumented. Cookie store also supports a number of options via rack (these used to be documented in rails 2.3)
* | | | | | | | | Merge pull request #19148 from yui-knk/fix/4_0_release_notesCarlos Antonio da Silva2015-03-011-1/+1
|\ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / |/| | | | | | | | [ci skip] Add `.`
| * | | | | | | | [ci skip] Add `.`yui-knk2015-03-011-1/+1
|/ / / / / / / /
* | | | | | | | Lines of code can be 100,000+ in a Rails appAkira Matsuda2015-03-011-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Actually, our app has 400,000 LOC :boom:
* | | | | | | | Fix segmentation fault in ActionPack testseileencodes2015-02-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduced in f6e293e ActionPack tests began sefaulting. I found that it was the kwargs and the test causing the seg fault was missing the new default_headers argument.
* | | | | | | | Merge pull request #19138 from yui-knk/fix/code_block_langAbdelkader Boudih2015-03-011-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | [ci skip] Fix fenced code block lang
| * | | | | | | | [ci skip] Fix fenced code block langyui-knk2015-03-011-1/+1
|/ / / / / / / /
* | | | | | | | Merge pull request #19137 from kant/patch-2Abdelkader Boudih2015-03-011-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Update link (minor fix)
| * | | | | | | | Update link (minor fix)Darío Hereñú2015-02-281-1/+1
|/ / / / / / / /
* | | | | | | | Merge pull request #19136 from kant/patch-1Abdelkader Boudih2015-03-011-2/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Minor fixes (proposal)
| * | | | | | | | Minor fixes (proposal)Darío Hereñú2015-02-281-2/+2
|/ / / / / / / /
* | | / / / / / drop allocations when handling model url generationAaron Patterson2015-02-281-1/+1
| |_|/ / / / / |/| | | | | |
* | | | | | | Merge pull request #19131 from ↵Yves Senn2015-02-281-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tgxworld/reduce_allocated_memory_in_module_delegate Reduce allocated memory for Module#delegate.
| * | | | | | | Reduce allocated memory for Module#delegate.Guo Xiang Tan2015-03-011-1/+1
| | | | | | | |
* | | | | | | | Merge pull request #19132 from davydovanton/pdate-doc-module-anonymousRafael Mendonça França2015-02-281-0/+7
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | [ci skip] Add code examples for Module#anonymous? documentation
| * | | | | | | | [ci skip] Add code examples for Module#anonymous? documentationAnton Davydov2015-02-281-0/+7
| | | | | | | | |
* | | | | | | | | Merge pull request #19130 from yui-knk/fix/active_support_core_extensions2Yves Senn2015-02-281-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | [ci skip] Fix to comment
| * | | | | | | | | [ci skip] Fix to commentyui-knk2015-03-011-1/+1
| | | | | | | | | |
* | | | | | | | | | Merge pull request #19129 from yui-knk/fix/active_support_core_extensionsYves Senn2015-02-281-1/+1
|\ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / |/| | | | | | | | | [ci skip] Fix to String
| * | | | | | | | | [ci skip] Fix to Stringyui-knk2015-03-011-1/+1
| |/ / / / / / / /
* | | | | | | | | Merge pull request #19128 from davydovanton/update-doc-range-to-sKasper Timm Hansen2015-02-281-2/+17
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | [ci skip] Update documentation for Range#to_formatted_s
| * | | | | | | | | [ci skip] Update documentation for Range#to_formatted_sAnton Davydov2015-02-281-2/+17
| | |/ / / / / / / | |/| | | | | | |
* | | | | | | | | Merge pull request #18965 from hjoo/rake_restartEileen M. Uchitelle2015-02-284-0/+43
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | created rake restart task
| * | | | | | | | Created rake restart task.Hyonjee Joo2015-02-264-0/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #18876. Rake restart touches `tmp/restart.txt` to restart application on next request. Updated tests and documentation accordingly.
* | | | | | | | | Merge pull request #19125 from y-yagi/testing_guideYves Senn2015-02-281-0/+1
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | add `ActiveJob::TestCase` to list of classes providing for test [ci skip]
| * | | | | | | | add `ActiveJob::TestCase` to list of classes providing for test [ci skip]yuuji.yaginuma2015-02-281-0/+1
| | | | | | | | |