Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #15172 from notEthan/active_record_pretty_print | Rafael Mendonça França | 2014-06-03 | 3 | -0/+95 |
|\ | | | | | | | | | | | | | implement ActiveRecord::Base#pretty_print Conflicts: activerecord/CHANGELOG.md | ||||
| * | implement ActiveRecord::Base#pretty_print + changelog | Ethan | 2014-05-29 | 3 | -0/+95 |
| | | |||||
* | | Merge pull request #15492 from sgrif/sg-dirty-defaults | Rafael Mendonça França | 2014-06-03 | 5 | -2/+40 |
|\ \ | | | | | | | Keep column defaults in type cast form | ||||
| * | | Keep column defaults in type cast form | Sean Griffin | 2014-06-03 | 5 | -2/+40 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The contract of `_field_changed?` assumes that the old value is always type cast. That is not the case for the value in `Column#default` as things are today. It appears there are other public methods that assume that `Column#default` is type cast, as well. The reason for this change originally was because the value gets put into `@raw_attributes` in initialize. This reverts to the old behavior on `Column`, and updates `initialize` to make sure that the values are in the right format. | ||||
* | | | Merge pull request #15493 from bf4/relax_mail_dep | Rafael Mendonça França | 2014-06-03 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | | | | | Relax mail gem constraint from ~> 2.5.4 to ~> 2.5 | ||||
| * | | | Relax mail gem constraint from ~> 2.5.4 to ~> 2.5, >= 2.5.4 | Benjamin Fleischer | 2014-06-03 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows Rails users to install mail 2.6 which relaxes the mime-types dependency, which is a big win for a lot of people. Previously, the mail gem restricted mime-types to ~> 1.16 but now it has expanded to [">= 1.16", "< 3"] And the mime-types maintainer will also be checking that 2.x releases don't break mail. See https://github.com/mikel/mail/pull/713 https://rubygems.org/gems/mail/versions/2.6.0 | ||||
* | | | | force table creation | Aaron Patterson | 2014-06-03 | 1 | -2/+3 |
| | | | | |||||
* | | | | Merge pull request #15447 from akshay-vishnoi/test-cases | Rafael Mendonça França | 2014-06-03 | 1 | -0/+8 |
|\ \ \ \ | | | | | | | | | | | Test `except!` in other cases too | ||||
| * | | | | Test `except!` in other cases too | Akshay Vishnoi | 2014-05-31 | 1 | -0/+8 |
| | | | | | |||||
* | | | | | oops! :bomb: | Aaron Patterson | 2014-06-03 | 2 | -92/+0 |
| | | | | | |||||
* | | | | | Routes specifying 'to:' must be a string that contains a "#" or a rack | Aaron Patterson | 2014-06-03 | 6 | -27/+149 |
| | | | | | | | | | | | | | | | | | | | | | | | | | application. Use of a symbol should be replaced with `action: symbol`. Use of a string without a "#" should be replaced with `controller: string`. | ||||
* | | | | | Revert "test pg, we don't care about the internal state of `column#default`." | Yves Senn | 2014-06-03 | 7 | -0/+23 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "test pg, remove unused column assignments. Follow up to 254cdf47" Related to #15492 This reverts commit 254cdf4728291277f3fbaa854f34495030e476b4. This reverts commit 4bcf9029452e0c760af04faab6b549710401e8cf. There are public methods that assume `Column#default` is type casted. The return value of `Column#default` is publicly relevant and should not change. /cc @sgrif | ||||
* | | | | | use the factory method to construct the mapping | Aaron Patterson | 2014-06-03 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | add tests for mixing :to and controller / action | Aaron Patterson | 2014-06-03 | 1 | -0/+48 |
| | | | | | |||||
* | | | | | push some options munging to an alternate constructor | Aaron Patterson | 2014-06-03 | 1 | -13/+19 |
| | | | | | |||||
* | | | | | add tests for nested lambda constraints | Aaron Patterson | 2014-06-03 | 1 | -0/+27 |
| | | | | | |||||
* | | | | | move options_constraints tests next to each other | Aaron Patterson | 2014-06-03 | 1 | -2/+2 |
| | | | | | |||||
* | | | | | only do is_a checks on `formatted` once | Aaron Patterson | 2014-06-03 | 1 | -9/+5 |
| | | | | | |||||
* | | | | | push options_constraints processing up | Aaron Patterson | 2014-06-03 | 1 | -22/+24 |
| | | | | | | | | | | | | | | | | | | | | | | | | | this lets us reduce is_a checks on the options_constraints and push "callable constraints" verification to the right place. | ||||
* | | | | | remove options as an ivar | Aaron Patterson | 2014-06-03 | 1 | -6/+8 |
| | | | | | |||||
* | | | | | only do Regexp === option once | Aaron Patterson | 2014-06-03 | 1 | -3/+4 |
| | | | | | |||||
* | | | | | return early from add_request_method | Aaron Patterson | 2014-06-03 | 1 | -11/+11 |
| | | | | | |||||
* | | | | | only loop over `options` once (hopefully) | Aaron Patterson | 2014-06-03 | 1 | -13/+11 |
| | | | | | |||||
* | | | | | only loop through constraints once | Aaron Patterson | 2014-06-03 | 1 | -19/+15 |
| | | | | | |||||
* | | | | | change defaults allocation to a one-liner | Aaron Patterson | 2014-06-03 | 1 | -3/+2 |
| | | | | | |||||
* | | | | | no longer need the scope ivar | Aaron Patterson | 2014-06-03 | 1 | -2/+1 |
| | | | | | |||||
* | | | | | only look up scope[:module] once | Aaron Patterson | 2014-06-03 | 1 | -6/+6 |
| | | | | | |||||
* | | | | | remove IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -4/+8 |
| | | | | | |||||
* | | | | | :only is never used in Mapping, so rm the key | Aaron Patterson | 2014-06-03 | 1 | -1/+2 |
| | | | | | |||||
* | | | | | remove :defaults from the IGNORE_OPTIONS list | Aaron Patterson | 2014-06-03 | 1 | -4/+4 |
| | | | | | |||||
* | | | | | remove :constraints from IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -4/+5 |
| | | | | | |||||
* | | | | | disconnect normalize_defaults! from options[:constraints] | Aaron Patterson | 2014-06-03 | 1 | -6/+6 |
| | | | | | |||||
* | | | | | disconnect options and scope from the `blocks` method | Aaron Patterson | 2014-06-03 | 1 | -7/+8 |
| | | | | | |||||
* | | | | | disconnect the constraints method from the options and scope hashes | Aaron Patterson | 2014-06-03 | 1 | -12/+15 |
| | | | | | |||||
* | | | | | :on is removed from options before the Mapping is instantiated, so remove it ↵ | Aaron Patterson | 2014-06-03 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | from IGNORE_OPTIONS | ||||
* | | | | | pull up via extraction and remove it from options / IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -8/+6 |
| | | | | | |||||
* | | | | | always make :via a list | Aaron Patterson | 2014-06-03 | 1 | -3/+2 |
| | | | | | |||||
* | | | | | always pull out a via variable and simplify logic | Aaron Patterson | 2014-06-03 | 1 | -12/+15 |
| | | | | | |||||
* | | | | | test with an empty via | Aaron Patterson | 2014-06-03 | 1 | -0/+8 |
| | | | | | |||||
* | | | | | add a test for missing "via" parameter | Aaron Patterson | 2014-06-03 | 2 | -1/+9 |
| | | | | | |||||
* | | | | | remove :as and :anchor from IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -3/+5 |
| | | | | | |||||
* | | | | | remove another value from IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -2/+2 |
| | | | | | |||||
* | | | | | shorten up IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | since we are now passing the format value around, we can remove it from the options hash, which means we don't need to consult as many values from IGNORE_OPTIONS | ||||
* | | | | | only look up the format option from the hash once | Aaron Patterson | 2014-06-03 | 1 | -16/+18 |
| | | | | | |||||
* | | | | | Merge pull request #15486 from sgrif/sg-binary-quoting | Matthew Draper | 2014-06-04 | 5 | -47/+83 |
|\ \ \ \ \ | |_|/ / / |/| | | | | Refactor quoting of binary data to not be based on the column type | ||||
| * | | | | Refactor quoting of binary data to not be based on the column type | Sean Griffin | 2014-06-03 | 5 | -47/+83 |
| | |/ / | |/| | | |||||
* | | | | test pg, remove unused column assignments. Follow up to 254cdf47 | Yves Senn | 2014-06-03 | 5 | -12/+0 |
| | | | | |||||
* | | | | pg, preserve money type when dumping schema and extract money default. | Yves Senn | 2014-06-03 | 7 | -22/+39 |
| | | | | |||||
* | | | | test pg, rm unused requires. | Yves Senn | 2014-06-03 | 11 | -27/+0 |
| | | | | |||||
* | | | | Merge pull request #15487 from sgrif/sg-bit-limit | Yves Senn | 2014-06-03 | 3 | -32/+32 |
|\ \ \ \ | | | | | | | | | | | Respect limit for PG bit strings |