aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * add documentation to CollectionProxy#empty?Francesco Rodriguez2012-11-291-1/+6
| |
| * Asset Pipeline: add 'the'Steve Klabnik2012-11-291-2/+2
| | | | | | | | | | | | Some guides work without 'the'. For instance, 'Migrations' or 'Form Helpers.' But when we talk about the asset pipeline, we... always say 'the asset pipeline.' The guide title should reflect this.
| * Command Line: remove 'A Guide to'Steve Klabnik2012-11-291-2/+2
| | | | | | | | It's obvious that this is a guide.
| * Migrations: add 'Active Record' to titleSteve Klabnik2012-11-291-2/+2
| | | | | | | | | | Other guides that talk about Active Record specific features include the name of the library in the title, this one should too for consistency.
| * Fix title of 'form helpers' guide.Steve Klabnik2012-11-291-2/+2
| | | | | | | | | | | | They're Rails Guides, so obviously we're talking about Rails Form Helpers. Also, 'helpers' should be capitalized.
| * Associations: s/A Guide//Steve Klabnik2012-11-291-2/+2
| | | | | | | | It's obvious that this is a guide, and none of the other guides say 'A Guide to'.
| * Remove 'This guide is based on ' warnings.Steve Klabnik2012-11-294-9/+0
| | | | | | | | It's obvious that the guide is based on this version of Rails, and may not be backwards compatible.
| * Add periods to the bullet points in guides.Steve Klabnik2012-11-2928-126/+126
| | | | | | | | Talked with @fxn about this. Bullet points should have periods at the ends.
| * Migrations: Fix opening bullets.Steve Klabnik2012-11-291-2/+2
| | | | | | | | The wording of these was a bit off, so I fixed them.
| * ActionView -> Action ViewSteve Klabnik2012-11-291-2/+2
| | | | | | | | The proper name has a space.
| * ActionController -> Action ControllerSteve Klabnik2012-11-291-2/+2
| | | | | | | | The proper name has a space.
| * ActiveSupport -> Active SupportSteve Klabnik2012-11-291-4/+4
| | | | | | | | The proper name has a space.
| * ActionMailer -> Action Mailer.Steve Klabnik2012-11-291-2/+2
| | | | | | | | The proper name for the library has a space.
| * ActionPack -> Action Pack.Steve Klabnik2012-11-291-1/+1
| | | | | | | | The proper name has a space.
| * ActiveRecord -> Active RecordSteve Klabnik2012-11-295-6/+6
| | | | | | | | | | The proper name, as per the documentation guides, is 'Active Record.' I've updated several references to it as 'ActiveRecord'.
| * Migrations: move massive paragraph out of intro.Steve Klabnik2012-11-291-10/+19
| | | | | | | | | | | | | | Most of the guides have a few simple sentences describing what they will show you at the top. This one had a few big paragraphs. I've moved those paragraphs down to an introductory one, and written a new smaller one for the introduction. This makes this guide more consistent with the others.
| * Getting Started: Improve instructions on opening a terminalSteve Klabnik2012-11-291-1/+4
| |
| * Getting Started: remove reference to attr_accessibleSteve Klabnik2012-11-291-11/+0
| |
| * Getting Started: mac -> Mac OS XSteve Klabnik2012-11-291-1/+1
| | | | | | | | It's properly called "Mac OS X"
| * Getting Started: Rails 3.2 -> Rails 4.Steve Klabnik2012-11-291-1/+1
| | | | | | | | This is based on Rails 4, not Rails 3.2.
| * Revert "correct css selector for the display of validation error messages: ↵Xavier Noria2012-11-281-4/+4
| | | | | | | | | | | | | | | | changed #error_explanation to #errorExplanation" At least in master the selector is snake case. This reverts commit ba2fed41613e02bb6cfc46c92ace00abb99ce313.
| * Clarifies the cookie store docs a bit and uses correct Markdown syntax for ↵Andy Lindeman2012-11-271-1/+1
| | | | | | | | preformatted text
| * Adding a note about :inverse_of for validations.Steve Klabnik2012-11-271-0/+8
| | | | | | | | From https://github.com/lifo/docrails/commit/cfd324b4b68469ba3188e4b7ba8586e59b239693\#commitcomment-2213592
| * Fix validation based on object not _id.Steve Klabnik2012-11-271-2/+2
| | | | | | | | From https://github.com/rails/rails/issues/6161\#issuecomment-10750118
| * correct css selector for the display of validation error messages: changed ↵Harper Henn2012-11-271-4/+4
| | | | | | | | #error_explanation to #errorExplanation
| * Set fixed-width style where appropriate on Getting Started guide.Hendy Tanata2012-11-271-2/+2
| |
| * Merge pull request #119 from c0/masterCaleb Wright2012-11-251-1/+1
| |\ | | | | | | Clarification to ActiveRecord Validations Doc in 7.2 Custom Methods
| | * Update guides/source/active_record_validations_callbacks.mdCaleb Wright2012-11-251-1/+1
| |/ | | | | In the expiration_date_cannot_be_in_the_past validation method, use `expiration_date.present?` instead of the double negative `!expiration_date.blank?`. Also join the comparisons with `&&` instead of `and`, which could cause unintended consequences.
| * Revert "Updated with where functional/helper tests go"Jason Noble2012-11-251-2/+2
| | | | | | | | | | | | This reverts commit c94cfdad6388dcdfaf4c10b9e8cee46baf2a7901. * This is the new 4.0 (master) directory structure
| * Reword Post model to note there are lines not shownJason Noble2012-11-241-1/+2
| |
| * We should use post_path, not post_urlJason Noble2012-11-241-1/+1
| |
| * Updated with where functional/helper tests goJason Noble2012-11-241-2/+2
| |
| * Moved position of has_manyJason Noble2012-11-241-2/+3
| |
| * Added new line to make it more readableJason Noble2012-11-241-1/+2
| | | | | | | | * This shows the reader there is a method: and data: parameters
| * Changed the Using Partials section to read a little betterJason Noble2012-11-241-25/+4
| | | | | | | | * No need to give a simple example, as we have a partial that we create in the blog app
| * Modified "Allowing the update of fields" sectionJason Noble2012-11-241-12/+6
| | | | | | | | | | | | | | * Rails generate model Post ______ creates the attr_accessible line for you for any fields you specify. Changed the section to describe what this line in the model does.
| * Update version numbers of Ruby and RailsJason Noble2012-11-241-2/+2
| |
| * Updated link to RubyGems siteJason Noble2012-11-241-1/+1
| |
* | Fix typo in AS guide [ci skip]Carlos Antonio da Silva2012-12-011-2/+2
| |
* | copy-edits the docs of 9ee0ffbXavier Noria2012-12-011-7/+5
| |
* | Merge pull request #8246 from urielka/uriel-fixed-8167Xavier Noria2012-12-019-19/+244
|\ \ | | | | | | Fix #8167 - adding autoloading support for caching
| * | Patched Marshal#load to work with constant autoloading ↵Uriel Katz2012-12-019-19/+244
|/ / | | | | | | (active_support/dependecies.rb) (issue #8167)
* | Make `Time.zone.parse` to work with JavaScript date stringsAndrew White2012-12-013-25/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chrome, Safari and Firefox serialize Date objects to strings such as 'Mon May 28 2012 00:00:00 GMT-0700 (PDT)'. When these strings are parsed the zone is interpreted as 'GMT-0700' which doesn't exist in the TzInfo list of timezones. By taking advantage of the improved date/time handling in 1.9.3 we can use `Date._parse` and the `:offset` value which is parsed correctly. Three tests were amended to make them pass: 1. test_parse_with_old_date This needed changing to a different value because the original value was before EST was adopted so was being changed to a LMT (Local Mean Time) value after the change. It didn't before because `DateTime` just has offsets from UTC not timezones. 2. test_parse_should_not_black_out_system_timezone_dst_jump Changed the implementation of this test as the stubs were dependent on internal implementation details of the test. Confirmed that the modified test still failed when the implementation of `parse` was restored to pre-#5571. 3. test_parse_should_black_out_app_timezone_dst_jump Ditto. Closes #5770.
* | Merge pull request #8387 from claudiob/remove_ar_observer_from_docsSantiago Pastorino2012-11-302-19/+0
|\ \ | | | | | | Remove references to AR::Observer from docs
| * | Remove references to AR::Observer from docsclaudiob2012-11-302-19/+0
|/ / | | | | | | | | ActiveRecord::Observer was extracted into a separate gem so it should not be referenced anymore (see https://github.com/rails/rails/commit/ccecab3)
* | Merge pull request #8385 from frodsan/strings_loveRafael Mendonça França2012-11-302-3/+30
|\ \ | | | | | | hash filters should be accessed with symbols or strings
| * | hash filters should be accessed with symbols or stringsFrancesco Rodriguez2012-11-302-3/+30
|/ /
* | Use separate Relation subclasses for each AR classJon Leighton2012-11-305-56/+156
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At present, ActiveRecord::Delegation compiles delegation methods on a global basis. The compiled methods apply to all subsequent Relation instances. This creates several problems: 1) After Post.all.recent has been called, User.all.respond_to?(:recent) will be true, even if User.all.recent will actually raise an error due to no User.recent method existing. (See #8080.) 2) Depending on the AR class, the delegation should do different things. For example, if a Post.zip method exists, then Post.all.zip should call it. But this will then result in User.zip being called by a subsequent User.all.zip, even if User.zip does not exist, when in fact User.all.zip should call User.all.to_a.zip. (There are various variants of this problem.) We are creating these compiled delegations in order to avoid method missing and to avoid repeating logic on each invocation. One way of handling these issues is to add additional checks in various places to ensure we're doing the "right thing". However, this makes the compiled methods signficantly slower. In which case, there's almost no point in avoiding method_missing at all. (See #8127 for a proposed solution which takes this approach.) This is an alternative approach which involves creating a subclass of ActiveRecord::Relation for each AR class represented. So, with this patch, Post.all.class != User.all.class. This means that the delegations are compiled for and only apply to a single AR class. A compiled method for Post.all will not be invoked from User.all. This solves the above issues without incurring significant performance penalties. It's designed to be relatively seamless, however the downside is a bit of complexity and potentially confusion for a user who thinks that Post.all and User.all should be instances of the same class. Benchmark --------- require 'active_record' require 'benchmark/ips' class Post < ActiveRecord::Base establish_connection adapter: 'sqlite3', database: ':memory:' connection.create_table :posts def self.omg :omg end end relation = Post.all Benchmark.ips do |r| r.report('delegation') { relation.omg } r.report('constructing') { Post.all } end Before ------ Calculating ------------------------------------- delegation 4392 i/100ms constructing 4780 i/100ms ------------------------------------------------- delegation 144235.9 (±27.7%) i/s - 663192 in 5.038075s constructing 182015.5 (±21.2%) i/s - 850840 in 5.005364s After ----- Calculating ------------------------------------- delegation 6677 i/100ms constructing 6260 i/100ms ------------------------------------------------- delegation 166828.2 (±34.2%) i/s - 754501 in 5.001430s constructing 116575.5 (±18.6%) i/s - 563400 in 5.036690s Comments -------- Bear in mind that the standard deviations in the above are huge, so we can't compare the numbers too directly. However, we can conclude that Relation construction has become a little slower (as we'd expect), but not by a huge huge amount, and we can still construct a large number of Relations quite quickly.
* | Simplify keys order test for as_json in Active ModelCarlos Antonio da Silva2012-11-301-4/+1
| |
* | Fix memory leak in development modeJon Leighton2012-11-302-15/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keying these hashes by klass causes reloadable classes to never get freed. Thanks to @thedarkone for pointing this out in the comments on 221571beb6b4bb7437989bdefaf421f993ab6002. This doesn't seem to make a massive difference to performance. Benchmark --------- require 'active_record' require 'benchmark/ips' class Post < ActiveRecord::Base establish_connection adapter: 'sqlite3', database: ':memory:' end GC.disable Benchmark.ips(20) do |r| r.report { Post.connection } end Before ------ Calculating ------------------------------------- 5632 i/100ms ------------------------------------------------- 218671.0 (±1.9%) i/s - 4364800 in 19.969401s After ----- Calculating ------------------------------------- 8743 i/100ms ------------------------------------------------- 206525.9 (±17.8%) i/s - 4039266 in 19.992590s
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-14 10:35:24 +0000