| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| |_|/ /
|/| | | |
do not create unnecessary directory
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
This was added in a4c358f, but `config.assets` has been removed in 5172d93.
Also, do not use env path to `Sprockets::Cache::FileStore` even `sprockets-rails`.
ref: https://github.com/rails/sprockets-rails/blob/master/lib/sprockets/railtie.rb#L129
|
|\ \ \
| | | |
| | | | |
fix typo in file path [ci skip]
|
| |/ / |
|
|\ \ \
| |/ /
|/| | |
Check for protected environments before trying to load structure.sql file
|
|/ /
| |
| |
| |
| |
| | |
- Check for protected environments while running `db:structure:load`
similar to how `db:schema:load` behaves.
- Followup of https://github.com/rails/rails/pull/24399.
|
|\ \
| | |
| | | |
Fix behavior of JSON encoding for Exception
|
|/ / |
|
|\ \
| | |
| | | |
generate ApplicationJob if it does not already exist
|
| | |
| | |
| | |
| | |
| | |
| | | |
ActiveJob jobs now inherit from ApplicationJob by default.
However, when updating to Rails 5 from the old Rails,
since there is a possibility that ApplicationJob does not exist.
|
|\ \ \
| | | |
| | | | |
MariaDB 5.3+ supports microsecond datetime precision
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We support microsecond datetime precision for MySQL 5.6.4+. MariaDB has
supported it since 5.3.0, but even 10.x versions return a compatible
version string like `5.5.5-10.1.8-MariaDB-log` which we parse as 5.5.5,
before MySQL supported microsecond precision.
Specialize our version check to account for MariaDB to fix.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
jeremy/mailer/dont-deliver-later-after-message-is-loaded
Disallow calling `#deliver_later` after local message modifications.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
They would be lost when the delivery job is enqueued, otherwise.
Prevents a common, hard-to-find bug like:
```ruby
message = Notifier.welcome(user, foo)
message.message_id = my_generated_message_id
message.deliver_later
```
The message_id is silently lost here! *Only the mailer arguments are
passed to the delivery job.*
This raises an exception now.
Make modifications to the message within the mailer method or use a
custom Active Job to manage delivery instead of using #deliver_later.
|
|\ \ \ \
| | | | |
| | | | | |
Remove reference to non existing link in the welcome page [ci skip]
|
|/ / / /
| | | |
| | | |
| | | | |
modified: guides/source/getting_started.md
|
|\ \ \ \
| | | | |
| | | | | |
Clarify fixtures examples [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Clarify description of `include_all_helpers` config setting's default behavior [ci skip]
|
|/ / / /
| | | |
| | | |
| | | | |
behavior [ci skip]
|
|\ \ \ \
| | | | |
| | | | | |
Fix broken link in 'Ruby on Rails 3.1 Release Notes' [ci skip]
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Updated syntax
* Updated tests to match syntax
|
|\ \ \ \
| | | | |
| | | | | |
remove needless entry [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | | |
The option backed to `start` in da26934313a31ae530b7537aba8a7662152f4dfe.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fixes for the strong & weak ETags guide [ci skip]
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
y-yagi/remove_blank_line_generated_in_appliation_mailer
remove blank line generated in application_mailer.rb
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
remove unused `require`
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Typo:- Fix length validation error [ci skip]
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Clean up after a failure in a run callback
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Also, make sure to call the +complete+ hooks if +run+ fails.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Prevent db:schema:load to protected environments
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Follow up to https://github.com/rails/rails/pull/22967 to protect against
loading a schema on accident in production.
cc @schneems
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Simply use `select_value` in `show_variable`
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
`SELECT @@name` statement returns only single row or `StatementInvalid`.
```
root@localhost [activerecord_unittest] > SELECT @@version;
+-----------+
| @@version |
+-----------+
| 5.7.9-log |
+-----------+
1 row in set (0.00 sec)
root@localhost [activerecord_unittest] > SELECT @@unknown_variable;
ERROR 1193 (HY000): Unknown system variable 'missing_variable'
```
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|/ / /
|/| | | | | | | |
Move quoting methods to `Quoting` module
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
`MysqlString`
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
methods to `Quoting` module
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
yahonda/use_newer_version_of_sqlite3_at_travis_ci"
This reverts commit a3d085a4ce949526cd388d6b399347504d9a0c92, reversing
changes made to e2df1c6d2aa1dd667c6c1be25d5c7f7d69f293fa.
It broke the build
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Add test case for interpolation with passing of data along with record
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
attribute in error message, where a proc is passed.
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
prathamesh-sonpatki/update-message-proc-documentation
Update example of passing a proc to `:message` option for validating records [ci skip]
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
[ci skip]
- This change is made as the behavior for `:message` proc was changed in
https://github.com/rails/rails/pull/24119.
- Also check
https://github.com/rails/rails/pull/24431#issuecomment-206106790 for
reference.
|
|\ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / /
|/| | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
integration and not complete i18n framework.
Fix Active Model basics introduction [ci skip]
|