aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge pull request #24915 from Erol/use-consistent-term-underscoredप्रथमेश Sonpatki2016-05-081-1/+1
|\ \ \ \ | | | | | | | | | | Use consistent term `underscored`
| * | | | Use consistent term [skip ci]Erol Fornoles2016-05-081-1/+1
|/ / / /
* / / / Use original `Array#sum` to speed up calculatingyui-knk2016-05-071-4/+8
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use original `Array#sum` when calculating Numeric sum. This commit is related #24804 issue. Issue #24804 reports `Array#sum` becomes much slower when ActiveSupport is included. This commit tries to use original method as far as possible. ```shell $ cat array_sum.rb class Array alias core_sum sum end require 'benchmark/ips' require 'active_support/core_ext/enumerable' ary = [1.0] * 1_000_000 Benchmark.ips do |x| x.report("core sum") { ary.core_sum } x.report("AS's sum") { ary.sum } x.compare! end $ bundle exec ruby -v -I lib array_sum.rb ruby 2.4.0dev (2016-05-01 master 54867) [x86_64-darwin14] Calculating ------------------------------------- core sum 4.000 i/100ms AS's sum 5.000 i/100ms ------------------------------------------------- core sum 50.492 (± 7.9%) i/s - 252.000 AS's sum 50.116 (± 6.0%) i/s - 250.000 Comparison: core sum: 50.5 i/s AS's sum: 50.1 i/s - 1.01x slower ``` Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | | Merge pull request #24897 from maclover7/jm-fix-24844Arthur Nogueira Neves2016-05-072-3/+4
|\ \ \ | | | | | | | | Followup to #24844
| * | | Followup to #24844Jon Moss2016-05-072-3/+4
|/ / / | | | | | | | | | | | | | | | | | | Some slight documentation edits and fixes. Also, run remove unnecessary `RuntimeError`. r? @arthurnn
* | | change cable.coffee to cable.js [ci skip]yuuji.yaginuma2016-05-072-11/+21
| | | | | | | | | | | | | | | In #23935, cable file was to be provided by the javascript instead of coffeescript, doc was also been modified to use javascript.
* | | Merge pull request #24906 from Neodelf/refactoring_loopXavier Noria2016-05-071-2/+1
|\ \ \ | | | | | | | | Replace `loop` to `until`
| * | | Replace `loop` to `until`Molchanov Andrey2016-05-071-2/+1
|/ / /
* | | Merge commit 'fbdcf5221ad7ea3d40ad09651962fc85d101dd67'Matthew Draper2016-05-0722-44/+88
|\ \ \ | | | | | | | | | | | | Preparing for 5.0.0.rc1 release
| * | | Preparing for 5.0.0.rc1 releaseRafael Mendonça França2016-05-0622-44/+88
| | | |
* | | | Merge pull request #24886 from rails/maclover7-patch-1Jon Moss2016-05-075-20/+20
|\ \ \ \ | | | | | | | | | | http --> https
| * | | | http --> httpsJon Moss2016-05-065-20/+20
| |/ / / | | | | | | | | | | | | [ci skip]
* | | | Merge pull request #24904 from jonatack/helpers-grammar-fixesJon Moss2016-05-071-2/+2
|\ \ \ \ | |/ / / |/| | | Helpers doc grammar fix [skip ci]
| * | | Helpers doc grammar fix [skip ci]Jon Atack2016-05-071-2/+2
|/ / /
* | | Fix etag expectation to work with the SHA256Rafael Mendonça França2016-05-061-1/+1
| | | | | | | | | | | | It is related with https://github.com/rack/rack/commit/7b66d2cdb80a4d6b44fa8c61d92e25fbbda1f152
* | | Sign the tags when releasingRafael Mendonça França2016-05-061-1/+1
| | |
* | | Upgrade all gems to make sure Rails works with rack 2.0.0.rc1Rafael Mendonça França2016-05-061-35/+37
| | |
* | | Merge pull request #24844 from arthurnn/arthurnn/connArthur Nogueira Neves2016-05-0611-92/+109
|\ \ \ | | | | | | | | Refactor connection handler
| * | | Update docs for connection handlerArthur Neves2016-05-061-2/+5
| | | | | | | | | | | | | | | | [skip ci]
| * | | s/specification_name/connection_specification_nameArthur Neves2016-05-064-14/+14
| | | |
| * | | s/specification_id/specification_nameArthur Neves2016-05-058-48/+48
| | | |
| * | | Retrive the right pool for db tasksArthur Neves2016-05-051-2/+2
| | | |
| * | | inline retrive_conn_pool methodArthur Neves2016-05-051-12/+8
| | | |
| * | | Better code readabilityArthur Neves2016-05-052-4/+2
| | | |
| * | | Test to swap connection at runtimeArthur Neves2016-05-051-0/+7
| | | |
| * | | fix testArthur Neves2016-05-051-8/+7
| | | |
| * | | Add spec_id testsArthur Neves2016-05-051-0/+9
| | | |
| * | | Use spec key, when given as spec_idArthur Neves2016-05-052-20/+23
| | | |
| * | | Better specification_id methodArthur Neves2016-05-051-10/+7
| | | |
| * | | Rename methodArthur Neves2016-05-051-3/+3
| | | |
| * | | Refactor connection handlerArthur Neves2016-05-059-83/+88
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ConnectionHandler will not have any knowlodge of AR models now, it will only know about the specs. Like that we can decouple the two, and allow the same model to use more than one connection. Historically, folks used to create abstract AR classes on the fly in order to have multiple connections for the same model, and override the connection methods. With this, now we can override the `specificiation_id` method in the model, to return a key, that will be used to find the connection_pool from the handler.
* | | | Make flash messages cookie compatible with Rails 4Rafael Mendonça França2016-05-062-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #18721 we removed the discard key from the session hash used to flash messages and that broke compatibility with Rails 4 applications because they try to map in the discarded flash messages and it returns nil. Fixes #24726.
* | | | Merge pull request #24896 from prathamesh-sonpatki/api-cleanupGuillermo Iguaran2016-05-061-7/+0
|\ \ \ \ | | | | | | | | | | BoomerAPI is not used anywhere, so removed it!
| * | | | BoomerAPI is not used anywhere, so removed it!Prathamesh Sonpatki2016-05-061-7/+0
| | |/ / | |/| | | | | | | | | | | | | | - It was originally added in 83b4e9073f0852afc065 and partially removed in 05d89410bf97d0778e7.
* | | | Merge pull request #24894 from prathamesh-sonpatki/release-notes-19282Rafael França2016-05-061-0/+4
|\ \ \ \ | | | | | | | | | | Release notes: Add a note about `use_transactional_tests` in the deprecated section of Active Record notes [ci skip]
| * | | | Release notes: Add a note about `use_transactional_tests` in the deprecated ↵Prathamesh Sonpatki2016-05-061-0/+4
| |/ / / | | | | | | | | | | | | | | | | | | | | section of Active Record notes [ci skip] - Followup of PR #19282.
* | | | Merge pull request #24889 from lvl0nax/as_array_split_refactoringRafael França2016-05-061-11/+6
|\ \ \ \ | | | | | | | | | | Array#split refactoring for case with block
| * | | | Array#split refactoring for case with blocklvl0nax2016-05-061-11/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calculating ------------------------------------- before 26.319k i/100ms after 29.414k i/100ms ------------------------------------------------- before 350.623k (± 1.6%) i/s - 1.763M after 416.227k (± 1.4%) i/s - 2.088M Comparison: after: 416226.8 i/s before: 350622.8 i/s - 1.19x slower
* | | | | Merge pull request #24029 from ↵Sean Griffin2016-05-066-19/+70
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | rthbound/dont-call-each-when-calling-body-on-response Dont call each when calling body on response to fix #23964 Fixes #23964
| * | | | Fixes #23964Ryan T. Hosford2016-03-136-19/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Adds #each_chunk to ActionDispatch::Response. it's a method which will be called by ActionDispatch::Response#each. - Make Response#each a proper method instead of delegating to @stream - In Live, instead of overriding #each, override #each_chunk. - `#each` should just spit out @str_body if it's already set - Adds #test_set_header_after_read_body_during_action to prove this fixes #23964 - Adds #test_each_isnt_called_if_str_body_is_written to ensure #each_chunk is not called when @str_body is available - Call `@response.sent!` in AC::TestCase's #perform so a test response acts a bit more like a real response. Makes test that call `#assert_stream_closed` pass again. - Additionally assert `#committed?` in `#assert_stream_closed` - Make test that was calling @response.stream.each pass again by calling @response.each instead.
* | | | | Merge pull request #24871 from vipulnsward/disable-transaction-failureArthur Nogueira Neves2016-05-061-0/+2
|\ \ \ \ \ | | | | | | | | | | | | Fix failures due to transactions
| * | | | | We are erroring due to nested transaction failures from mysql on ↵Vipul A M2016-05-061-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | test_migrate_clears_schema_cache_afterward test. Disable transactions for this test. Fixes #24391
* | | | | | Merge pull request #24892 from javiervidal/2_3_release_notesVipul A M2016-05-061-4/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix broken links in 'Ruby on Rails 2.3 Release Notes' [ci skip]
| * | | | | | Fix broken links in 'Ruby on Rails 2.3 Release Notes' [ci skip]Javier Vidal2016-05-061-4/+4
| | | | | | |
* | | | | | | Allow the connection adapters to determine the order of bind paramsSean Griffin2016-05-063-4/+46
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 5.0 we use bind parameters for limit and offset, while in 4.2 we used the values directly. The code as it was written assumed that limit and offset worked as `LIMIT ? OFFSET ?`. Both Oracle and SQL Server have a different syntax, where the offset is stated before the limit. We delegate this behavior to the connection adapter so that these adapters are able to determine how the bind parameters are flattened based on what order their specification has the various clauses appear. Fixes #24775
* | | | | | Merge pull request #24888 from javiervidal/configuringJon Moss2016-05-061-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix link in 'Configuring Rails Applications' [ci skip]
| * | | | | | Fix link in 'Configuring Rails Applications' [ci skip]Javier Vidal2016-05-061-1/+1
|/ / / / / /
* | | | | | Merge pull request #24885 from javiervidal/3_0_release_notesEileen M. Uchitelle2016-05-061-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix link in 'Ruby on Rails 3.0 Release Notes' [ci skip]
| * | | | | | Fix link in 'Ruby on Rails 3.0 Release Notes' [ci skip]Javier Vidal2016-05-061-1/+1
|/ / / / / /
* | | | | | Merge pull request #24884 from javiervidal/markdown_syntax_2_2_release_notesVipul A M2016-05-061-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix markdown syntax in 'Ruby on Rails 2.2 Release Notes' [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 06:06:56 +0000