| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
vngrs/remove_test_order_from_activejob_test_helper
Don't need to explicitly set test_order it's :random default
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
:nodoc: rename_column in postgresql/schema_statements.rb [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Its already doc'ed in
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The old `test_create_bang_returns_falsy_when_join_record_has_errors` had
a missleading name and was a duplicate of
`test_save_should_not_raise_exception_when_join_record_has_errors`.
Since it had an assertion on the return value I renamed it accordingly
and got rid of the duplicate test.
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
added activejob in list [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Adds documentaion for the Rails.root and Rails.public_path methods
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Let Sidekiq and Que set provider_job_id
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When a job is added to Sidekiq by ActiveJob, make sure we still can get the
original job_id provider by Sidekiq. We do this by adding the sidekiq jid to
provider_job_id field on the job object.
Partly fixes #18821
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Changed to static value of id in comments [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In help text for method, dynamic value makes it hard to understand, so replaced with static value matching with example above
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Get provider_job_id from DelayedJob
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When queueing with DelayedJob, get the id of the job instance and report
it back to ActiveJob as provider_job_id.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Example updated [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Should be ApplicationController not ApplicationController::Base
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Typo fix [ci skip]
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
Single brackets
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Amend `next_week` documentation [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
[skip ci]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Make sure that tests do not hardcode the default value.
For example `test_instantiation_doesnt_try_to_require_corresponding_file`
always restored the configuration to `true` regardless of what it's
original value was.
Extract a helper to make the global modification consistent across tests.
|
|\ \ \ \ \ \ \
| |_|_|_|/ / /
|/| | | | | | |
[skip ci] Fix typos in actionpack changelog and security guide
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
removing require object/blank
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
the current class is not the blank?, present? as well as other inheriting, the test suite runs
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Docs: Adding a note, snipped for brevity [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
sudden ending of form looks incomplete and catches [ci skip]
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
make AbstractAdapter#subquery_for private
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Make sure this script keeps working and has consistent output.
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | |
| | | | | | | |
Use the built-in rake tasks
|
| | | | | | |
| | | | | | |
| | | | | | | |
Use the `log:clear` and `tmp:clear` rake tasks in the setup file template
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
seanlinsley/list-reserved-works-in-generator-error
List reserved words in generator error
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Documentation: Using the real C and R def of Crud [ci skip]
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
fixing English in Rails::Engine docs
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[ci skip]
|
|\ \ \ \ \ \ \ \
| | |_|_|_|/ / /
| |/| | | | | | |
Fixes some words missing from the contributing guide [ci skip]
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|/ / /
|/| | | | | | | |
Tiny grammar correction in documentation [ci skip]
|
|/ / / / / / / |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Prompted by:
https://github.com/rails/rails/commit/e38dd7bfa4360e241eadf0cf44abdf86ea33a393#commitcomment-11011496
/cc @kuldeepaggarwal
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Use `select_value` for avoid `ActiveRecord::Result` instance creating
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
`exec_query` create `ActiveRecord::Result` instance. It is better to use
`select_value` instead of `exec_query` for performance.
|