| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
|
| |
[ci skip]
Sync AV, AR, AJ, AS, AM changelogs with our 5.0 release notes draft.
This is a follow up to c94045d and contains changes made since the
release of beta1.
|
|
|
|
|
|
|
|
|
|
| |
[ci skip]
This updates the 5.0 release notes guide to reflect changes that
happened after beta1 has been released.
I'll sync the other changelogs later today but I'll push this batch to
prevent against cumbersome merge conflicts.
|
|\
| |
| | |
Require enumerable module when using #sum
|
|/
|
|
|
|
| |
In https://github.com/rails/rails/commit/dfa48f200cbc5c1ca18457a8cde14642e12af5,
a call to `#sum` was added. For that to always work, we need to require the
core_ext/enumerable module.
|
|\
| |
| | |
update Active Job default adapter [ci skip]
|
| |
| |
| |
| | |
Follow up to 625baa69d14881ac49ba2e5c7d9cac4b222d7022
|
|\ \
| | |
| | | |
Cable: add isolated tests and FAYE=1 test runs
|
| | | |
|
|\ \ \
| | | |
| | | | |
changed default value of `caching` option to `nil`
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | | |
The default is that's false, caching even if you do not specify the caching option is determined not to use,
and `tmp/caching-dev.txt` will be deleted.
If it is this, regardless of whether or not there is `tmp/caching-dev.txt`, be sure to order would be necessary to specify the caching option,
I think that in than good to so as not to do anything by default.
|
|\ \ \
| | | |
| | | |
| | | | |
Comment out config.file_watcher during Rails upgrade process
|
| | | |
| | | |
| | | |
| | | | |
[related #24243]
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
switched layout :mailer to a string so that mail layout can be properly sent
|
| | | | |
| | | | |
| | | | |
| | | | | |
found and mail can be delivered properly
|
| | | | | |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | |
| | | | | |
Fix request.reset_session for API controllers
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Due to that `ActionDispatch::Flash` (the flash API's middleware) is not
included for API controllers, the `request.reset_session` method, which
relies on there being a `flash=` method which is in fact defined by the
middleware, was previously breaking. Similarly to how
add46482a540b33184f3011c5c307f4b8e90c9cc created a method to be
overridden by the flash middleware in order to ensure non-breakage, this
is how flashes are now reset.
Fixes #24222
|
|\ \ \ \
| |_|/ /
|/| | | |
remove Rails 4 text from asset pipeline guide
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
RochesterinNYC/better-error-message-for-includes-relations-missing
Improve error message for missing relations for includes and eager_load
|
| | | |
| | | |
| | | |
| | | | |
relations
|
|\ \ \ \
| | | | |
| | | | | |
Added more tests for reserved hash keys of ActiveJob::Arguments.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Added tests for checking all reserved hash keys of ActiveJob::Arguments.
- Moved unrelated code from the test to the correct place, i.e. newly created
test.
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
use rails 5 favicon.ico for rails guides [ci skip]
|
| | |_|/
| |/| | |
|
|/ / /
| | |
| | |
| | | |
[ci skip]
|
|\ \ \
| | | |
| | | | |
Document and Match the Rails logger interface
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
The logger interface to get all Rails features is not obvious. This change adds documentation on how to assign a logger that will use all Rails features.
We are also matching the stdout logging interface to the default logger in bootstrap https://github.com/rails/rails/blob/f5a5988352b165143f0f9d622707c351c1470882/railties/lib/rails/application/bootstrap.rb#L42-L45.
|
|\ \ \
| |/ /
|/| | |
Creates development and test databases in db:migrate task
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts a334425caff9b2140d5e99fcfc2eb8c4ab10bdfa.
The main reason is that now the workflow is inconsistent when using
spring.
When using spring `RAILS_ENV` is always set, so only one database is
created.
This means that in development `bin/rake db:create` and `bundle exec
rake db:create` have different results.
It also breaks the `bin/setup` script since `bin/rake db:setup
db:test:prepare` will fail.
|
|\ \ \
| | | |
| | | | |
fix a comment in atom_feed_helper.rb
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Improve ActiveSupport::Dependencies code understanding
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In a previous patch, all log-related stuff was removed. However,
some logs are still useful to understand the code. Therefore, in
this patch, I put those log messages back as comments.
[ci skip]
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This configuration improves git diff, git log -p -W, git grep -p, ...,
and allows to inspect the history of a method with a command like
git log -L:new_constants_in:activesupport/lib/active_support/dependencies.rb
Let me also appeal to authority by saying it is present in the Ruby
repository as well
https://github.com/ruby/ruby/blob/trunk/.gitattributes
:)
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If the code reaches that line new_constants is no longer needed.
We only need here to iterate over it to discard stuff and done.
Note that constant_watch_stack.new_constants returns a new
reference each time it is invoked, so that #clear call was not
cleaning state in some internal structure (which would have been
a bit dirty as well at this level of coupling).
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This array literal cannot be reached. The previous begin either
returns to the caller via the explicit return in the ensure
block if all goes well, or else propagates whatever make the
begin block abort execution.
I have investigated the origin of this a bit. In the past the
ensure block didn't have a return call, see for example c08547d.
Later on the return was added in 4da4506, but the trailing
literal was left there.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
References #24205.
|
| | |
| | |
| | |
| | |
| | | |
Lets have the server and the Rake task go through the same ropes, so we can
share all the file lookup, adding, and deleting code.
|
|\ \ \
| | | |
| | | | |
Update action_controller_overview.md
|
|/ / / |
|
|\ \ \
| |/ /
|/| | |
Remove log-related stuff from ActiveSupport::Dependencies
|
|/ /
| |
| |
| |
| | |
In this patch, all log-related stuff in `ActiveSupport::Dependencies`
is removed because the logging is no longer useful.
|