Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | remove unnecessary `remove_file` | yuuji.yaginuma | 2017-01-01 | 1 | -1/+0 |
| | | | | | | It deletes the `app/mailers` directory itself, it is not necessary to delete the file individually. https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/app_generator.rb#L329 | ||||
* | Merge pull request #27528 from kamipo/extract_casted_booleans | Kasper Timm Hansen | 2016-12-31 | 2 | -18/+18 |
|\ | | | | | Extract `casted_true`/`casted_false` for `Type::ImmutableString` | ||||
| * | Extract `casted_true`/`casted_false` for `Type::ImmutableString` | Ryuta Kamizono | 2017-01-01 | 2 | -18/+18 |
| | | | | | | | | | | | | The only difference between `Type::ImmutableString` and its subclasses is the representation of the casted booleans. Prefer extracting `casted_true`/`casted_false` and override these by subclasses. | ||||
* | | Merge pull request #27529 from kamipo/refactor_ids_reader | Kasper Timm Hansen | 2016-12-31 | 1 | -3/+1 |
|\ \ | |/ |/| | Refactor `CollectionAssociation#ids_reader` | ||||
| * | Refactor `CollectionAssociation#ids_reader` | Ryuta Kamizono | 2017-01-01 | 1 | -3/+1 |
|/ | | | | | Simply we can do `target.pluck(reflection.association_primary_key)` if `target` is loaded. | ||||
* | Merge pull request #27527 from kamipo/array_subtype_options | Kasper Timm Hansen | 2016-12-31 | 2 | -4/+6 |
|\ | | | | | Dump array subtype options correctly | ||||
| * | Dump array subtype options correctly | Ryuta Kamizono | 2017-01-01 | 2 | -4/+6 |
| | | | | | | | | | | Currently schema dumper does not dump array subtype `precision` and `scale` options. This commit fixes the issue. | ||||
* | | Match Thor's `desc` signature. | Kasper Timm Hansen | 2016-12-31 | 1 | -1/+1 |
| | | | | | | | | It can also take an options hash. | ||||
* | | Prevent command name being printed twice. | Kasper Timm Hansen | 2016-12-31 | 1 | -0/+8 |
|/ | | | | | | | | | Thor would inadvertantly duplicate the command usage because of the help method in a command class. Fixes #26664. [ Yuji Yaginuma & Kasper Timm Hansen ] | ||||
* | Merge pull request #27525 from kirs/patch-1 | Kasper Timm Hansen | 2016-12-31 | 1 | -2/+2 |
|\ | | | | | Update schema cache doc in guides/command_line | ||||
| * | Update schema cache doc in guides/command_line | Kir Shatrov | 2016-12-31 | 1 | -2/+2 |
|/ | |||||
* | [ci skip] Update Active Model copyright years. | Kasper Timm Hansen | 2016-12-31 | 2 | -2/+2 |
| | | | | | | Missed in 37d956f. Fixes #27524. [ MSathieu & Kasper Timm Hansen ] | ||||
* | Merge pull request #27441 from koic/quoted_insert_version_sql | Kasper Timm Hansen | 2016-12-31 | 1 | -4/+4 |
|\ | | | | | Add a quote to an SQL insert statement of schema migration | ||||
| * | Add a quote to an SQL insert statement of schema migration | Koichi ITO | 2016-12-23 | 1 | -4/+4 |
| | | |||||
* | | [ci skip] Retouch some association wording. | Kasper Timm Hansen | 2016-12-31 | 1 | -3/+4 |
| | | | | | | | | | | Trim some needless words off the lines and format the code sample like we'd write in the Rails source. | ||||
* | | [ci skip] Remove mention of GeneratedAssociationMethods | Kasper Timm Hansen | 2016-12-31 | 1 | -4/+3 |
| | | | | | | | | | | Marked as private in 2afe5a1 and doesn't seem worth it to mention the module name here. | ||||
* | | Merge pull request #27521 from ↵ | Kasper Timm Hansen | 2016-12-31 | 1 | -0/+2 |
|\ \ | | | | | | | | | | | | | prathamesh-sonpatki/mark-one-more-constant-as-private Mark :GeneratedAssociationMethods also as private_constant | ||||
| * | | Mark :GeneratedAssociationMethods also as private_constant | Prathamesh Sonpatki | 2016-12-31 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - After https://github.com/rails/rails/commit/64e5b897ac944a05a33275e3828a3d4047a6b457, only :GeneratedAssociationMethods was remaining to be marked as private constant, so marked it as well. - Before: >> User.constants(false) => [:GeneratedAssociationMethods] - After: >> User.constants(false) => [] | ||||
* | | | Merge pull request #27523 from maclover7/jm-2017 | Jon Moss | 2016-12-31 | 17 | -17/+17 |
|\ \ \ | | | | | | | | | Bump license years for 2017 | ||||
| * | | | Bump license years for 2017 | Jon Moss | 2016-12-31 | 17 | -17/+17 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip] | ||||
* | | | Merge pull request #27522 from ↵ | Kasper Timm Hansen | 2016-12-31 | 2 | -3/+3 |
|\ \ \ | |/ / |/| | | | | | | | | y-yagi/remove_skip_bundle_option_from_plugin_generator remove `skip_bundle` option from plugin generator | ||||
| * | | remove `skip_bundle` option from plugin generator | yuuji.yaginuma | 2016-12-31 | 2 | -3/+3 |
|/ / | | | | | | | | | | | | | Because `bundle install` is not executed regardless of whether the option is specified or not. Ref: fbd1e98cf983572ca9884f17f933ffe92833632a | ||||
* | | Merge pull request #12509 from eitoball/pluralize_for_non_ascii_character_words | Matthew Draper | 2016-12-31 | 1 | -0/+8 |
|\ \ | | | | | | | | | | | | | | | | Fix ActiveSupport::Inflector.pluralize behavior for words that consist of non-ASCII characters (test only; the original bug was fixed by 1bf50badd943e684a56a03392ef0ddafefca0ad7) | ||||
| * | | fix pluralize behavior for words that consist of non-ascii characters | Eito Katagiri | 2015-07-02 | 2 | -1/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The code below returns "猫" in 3.2, but "猫s" in 4.0. ```ruby ActiveSupport::Inflector.inflections do |inflect| inflect.uncountable "猫" end "猫".pluralize ``` | ||||
* | | | Prefer Regexp#match? over Regexp#=== | Matthew Draper | 2016-12-31 | 1 | -1/+2 |
| | | | |||||
* | | | Only add regexes for the new words | Matthew Draper | 2016-12-31 | 1 | -2/+3 |
| | | | |||||
* | | | Merge pull request #27518 from maclover7/jm-ar-changelog-2 | Jon Moss | 2016-12-30 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Add missing word in activerecord/CHANGELOG.md | ||||
| * | | | Add missing word in activerecord/CHANGELOG.md | Jon Moss | 2016-12-30 | 1 | -1/+1 |
|/ / / | | | | | | | | | | [ci skip] | ||||
* | | | Mark internal cache constants as private | Matthew Draper | 2016-12-31 | 1 | -1/+4 |
| | | | | | | | | | | | | Closes #14640 | ||||
* | | | Enforce middleware ordering with a test, instead of comments | Matthew Draper | 2016-12-31 | 2 | -6/+35 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We want the actual order to be very predictable, so it's rightly defined in code -- not with an on-the-fly tsort. But we can do the tsort here, and then verify that it matches the implemented ordering. This way we don't leave future readers guessing which parts of the ordering are deliberate and which are arbitrary. | ||||
* | | | Merge pull request #27515 from ↵ | Matthew Draper | 2016-12-31 | 2 | -3/+4 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | kbrock/fix_log_remote_ip_before_dispatcher_ips_settings Allow log remote ip addres when config.action_dispatch.trusted_proxie… | ||||
| * | | | Allow log remote ip addres when config.action_dispatch.trusted_proxies passed | Leonid Batizhevsky | 2016-12-30 | 2 | -2/+3 |
|/ / / | |||||
* | | | Merge pull request #27512 from ↵ | Rafael França | 2016-12-30 | 1 | -3/+1 |
|\ \ \ | | | | | | | | | | | | | | | | | kamipo/remove_needless_activesupport_deprecation_silence Remove needless `ActiveSupport::Deprecation.silence` | ||||
| * | | | Remove needless `ActiveSupport::Deprecation.silence` | Ryuta Kamizono | 2016-12-31 | 1 | -3/+1 |
| | | | | |||||
* | | | | Merge pull request #27509 from kamipo/remove_remaining_deprecations | Rafael França | 2016-12-30 | 9 | -58/+9 |
|\ \ \ \ | |/ / / |/| | | | Remove remaining ActiveRecord deprecations | ||||
| * | | | Remove deprecated `#uniq`, `#uniq!`, and `#uniq_value` | Ryuta Kamizono | 2016-12-30 | 7 | -46/+5 |
| | | | | |||||
| * | | | Remove deprecated `#insert_sql`, `#update_sql`, and `#delete_sql` | Ryuta Kamizono | 2016-12-30 | 3 | -12/+4 |
|/ / / | |||||
* | | | Merge pull request #27506 from maclover7/jm-ar-changelog | Jon Moss | 2016-12-29 | 1 | -5/+5 |
|\ \ \ | | | | | | | | | Grammar linting in activerecord/CHANGELOG.md | ||||
| * | | | Grammar linting in activerecord/CHANGELOG.md | Jon Moss | 2016-12-29 | 1 | -5/+5 |
|/ / / | | | | | | | | | | [ci skip] | ||||
* | | | Merge pull request #27504 from kenta-s/fix-grammar-in-ar-changelog | Jon Moss | 2016-12-29 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Fix grammar in AR CHANGELOG.md [ci skip] | ||||
| * | | | Fix grammar in AR CHANGELOG.md [ci skip] | kenta-s | 2016-12-30 | 1 | -1/+1 |
|/ / / | |||||
* | | | Merge pull request #27503 from rails/activerecord-deprecation | Rafael França | 2016-12-29 | 66 | -650/+329 |
|\ \ \ | | | | | | | | | Remove all ActiveRecord deprecations | ||||
| * | | | Delayed job doesn't support Active Record 5.1 yet | Rafael Mendonça França | 2016-12-29 | 1 | -1/+2 |
| | | | | |||||
| * | | | Remove deprecated #use_transactional_fixtures configuration | Rafael Mendonça França | 2016-12-29 | 3 | -31/+5 |
| | | | | |||||
| * | | | Remove deprecated `#raise_in_transactional_callbacks` configuration | Rafael Mendonça França | 2016-12-29 | 2 | -10/+4 |
| | | | | |||||
| * | | | Remove deprecated #load_schema_for | Rafael Mendonça França | 2016-12-29 | 2 | -8/+4 |
| | | | | |||||
| * | | | Remove deprecated conditions parameter from #delete_all | Rafael Mendonça França | 2016-12-29 | 3 | -26/+12 |
| | | | | |||||
| * | | | Remove deprecated conditions parameter from `#destroy_all` | Rafael Mendonça França | 2016-12-29 | 3 | -16/+6 |
| | | | | |||||
| * | | | Remove deprecated support to passing arguments to `#select` when a block is ↵ | Rafael Mendonça França | 2016-12-29 | 3 | -10/+5 |
| | | | | | | | | | | | | | | | | provided. | ||||
| * | | | Remove deprecated support to query using commas on LIMIT | Rafael Mendonça França | 2016-12-29 | 4 | -37/+9 |
| | | | |