Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | Add test case and documentation for skip_before_filter. | Lauro Caetano | 2015-01-08 | 2 | -0/+22 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Test case for using skip_before_filter with the options :only and :if both present. In this case, the :if option will be ignored and :only will be executed. Closes #14549 (the commit was cherry-picked from there). | |||||
* | | | | Fix the example (for realz) | David Heinemeier Hansson | 2015-01-08 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Fix the example | David Heinemeier Hansson | 2015-01-08 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Merge pull request #18334 from simi/prepend-false-for-protect-from-forgery | David Heinemeier Hansson | 2015-01-08 | 3 | -1/+91 | |
|\ \ \ \ | | | | | | | | | | | Add prepend option to protect_from_forgery. | |||||
| * | | | | Add prepend option to protect_from_forgery. | Josef Šimánek | 2015-01-08 | 3 | -1/+91 | |
|/ / / / | ||||||
* | | | | Merge pull request #18371 from brainopia/remove_hide_actions | David Heinemeier Hansson | 2015-01-08 | 5 | -93/+7 | |
|\ \ \ \ | |_|/ / |/| | | | Remove ActionController::HideActions (closes #18336) | |||||
| * | | | Remove ActionController::HideActions (closes #18336) | brainopia | 2015-01-06 | 5 | -93/+7 | |
| | | | | ||||||
* | | | | Document has_many :extend option | Caleb Thompson | 2015-01-08 | 1 | -0/+4 | |
| |/ / |/| | | | | | | | | https://github.com/rails/rails/commit/5937bd02dee112646469848d7fe8a8bfcef5b4c1#commitcomment-9205786 | |||||
* | | | Merge pull request #18403 from georgeclaghorn/enqueued-email-assertions | David Heinemeier Hansson | 2015-01-08 | 5 | -2/+144 | |
|\ \ \ | | | | | | | | | Enqueued email assertions | |||||
| * | | | Add assert_enqueued_emails and assert_no_enqueued_emails | George Claghorn | 2015-01-08 | 3 | -0/+115 | |
| | | | | ||||||
| * | | | Add :only option to assert_no_enqueued_jobs | George Claghorn | 2015-01-08 | 2 | -2/+29 | |
|/ / / | ||||||
* | | | Fix Active Job changelog formatting and reword a bit [ci skip] | Carlos Antonio da Silva | 2015-01-08 | 1 | -24/+22 | |
| | | | ||||||
* | | | Merge pull request #18397 from georgeclaghorn/enhance-job-assertions | David Heinemeier Hansson | 2015-01-07 | 3 | -7/+76 | |
|\ \ \ | | | | | | | | | Add :only option to assert_enqueued_jobs | |||||
| * | | | Add :only option to assert_enqueued_jobs | George Claghorn | 2015-01-07 | 3 | -7/+76 | |
|/ / / | | | | | | | | | | With the option, assert_enqueued_jobs will check the number of times a specific kind of job is enqueued. | |||||
* | | | Merge pull request #16640 from mfazekas/fix_loop_in_changed_for_autosave | Godfrey Chan | 2015-01-07 | 2 | -4/+21 | |
|\ \ \ | | | | | | | | | Fix potenital infinite recursion in changed_for_autosave? | |||||
| * | | | Fix potenital stack level too deep with autosave or validation | Miklos Fazkeas | 2015-01-04 | 2 | -4/+21 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When associations checked for autosave have a cycle, and none of them is dirty, then changed_for_autosave? will be an infinite loop. We now remember if we're in the check and will short circuit the recursion. | |||||
* | | | | Merge pull request #18377 from brainopia/custom_connection_with_count | Sean Griffin | 2015-01-07 | 2 | -1/+8 | |
|\ \ \ \ | |_|_|/ |/| | | | Fix count on a separate connection | |||||
| * | | | Fix count on a separate connection (fixes #18359) | brainopia | 2015-01-08 | 2 | -1/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previosly count and other AR calculations would convert column_name_for_operation to sql on a default Arel::Table.engine (AR::Base) connection. That could lead to trouble if current model has a connection to a different adapter or Base connection is inaccessible. | |||||
* | | | | Merge pull request #18378 from ↵ | Carlos Antonio da Silva | 2015-01-07 | 2 | -2/+2 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | shunsukeaida/avoid_orm_being_humanized_in_generator_help_message Overwrite descriptions generated by Generators::Base to respect acronym. | |||||
| * | | | | acronyms like ORM should be in uppercase, so overwrite the desc generated by ↵ | shunsukeaida | 2015-01-07 | 2 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | hook_for | |||||
* | | | | | Move changelog entry to the top [ci skip] | Carlos Antonio da Silva | 2015-01-07 | 1 | -7/+5 | |
| |/ / / |/| | | | ||||||
* | | | | Merge pull request #18074 from caike/master | Rafael Mendonça França | 2015-01-06 | 9 | -38/+58 | |
|\ \ \ \ | |_|_|/ |/| | | | Add _mailer suffix to generated file names. | |||||
| * | | | Add mailer suffix to generated files and classes | Carlos Souza | 2015-01-06 | 9 | -38/+58 | |
| | | | | | | | | | | | | | | | | | | | | Following the same naming convention used in controllers and jobs. | |||||
* | | | | Use Ruby's #include? to avoid relying on AS extension | Carlos Antonio da Silva | 2015-01-06 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The build has failed when running the date/time ext tests in isolation due to the missing extension, so better than adding a require is using just Ruby in this case. https://travis-ci.org/rails/rails/jobs/46107954#L1077 | |||||
* | | | | Merge pull request #18368 from kuldeepaggarwal/fix-attribute-scope | Carlos Antonio da Silva | 2015-01-06 | 1 | -3/+1 | |
|\ \ \ \ | | | | | | | | | | | fix `attribute` method scoping(i.e. private) | |||||
| * | | | | fix `attribute` method scoping(i.e. private) | Kuldeep Aggarwal | 2015-01-06 | 1 | -3/+1 | |
| | | | | | | | | | | | | | | | | | | | | ref #52f641264b1325a4c2bdce7971b14524bd4905f1 | |||||
* | | | | | Merge pull request #18370 from LindseyB/patch-1 | Guillermo Iguaran | 2015-01-06 | 1 | -1/+1 | |
|\ \ \ \ \ | | | | | | | | | | | | | Changing sets -> set [ci-skip] | |||||
| * | | | | | Changing sets -> set | Lindsey Bieda | 2015-01-06 | 1 | -1/+1 | |
|/ / / / / | | | | | | | | | | | Updating some minor grammar issue. | |||||
* | | | | | Merge pull request #18335 from georgeclaghorn/day-gymnastics | David Heinemeier Hansson | 2015-01-06 | 3 | -17/+151 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Add #weekend?, #next_weekday, and #prev_weekday methods to Date, Time, and DateTime | |||||
| * | | | | Add #prev_day and #next_day as counterparts to #yesterday and #tomorrow for ↵ | George Claghorn | 2015-01-06 | 3 | -6/+31 | |
| | | | | | | | | | | | | | | | | | | | | Date, Time, and DateTime | |||||
| * | | | | Add same_time option to #prev_week and #next_week for Date, Time, and DateTime | George Claghorn | 2015-01-06 | 3 | -17/+42 | |
| | | | | | ||||||
| * | | | | Add #on_weekend?, #next_weekday, and #prev_weekday methods to Date, Time, ↵ | George Claghorn | 2015-01-06 | 3 | -0/+84 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and DateTime `#on_weekend?` returns true if the receiving date/time falls on a Saturday or Sunday. `#next_weekday` returns a new date/time representing the next day that does not fall on a Saturday or Sunday. `#prev_weekday` returns a new date/time representing the previous day that does not fall on a Saturday or Sunday. | |||||
* | | | | | Merge pull request #18366 from codeodor/patch-1 | Rafael Mendonça França | 2015-01-06 | 1 | -1/+1 | |
|\ \ \ \ \ | |_|/ / / |/| | | | | Add log_level options to configuration guide | |||||
| * | | | | Add log_level options to configuration guide | Sammy Larbi | 2015-01-06 | 1 | -1/+1 | |
|/ / / / | ||||||
* | | | | Merge pull request #18362 from georgemillo/attribute | Rafael Mendonça França | 2015-01-06 | 1 | -3/+2 | |
|\ \ \ \ | | | | | | | | | | | replacing 'attribute' method with an alias | |||||
| * | | | | replacing 'attribute' method with an alias | George Millo | 2015-01-06 | 1 | -3/+2 | |
| |/ / / | ||||||
* | | | | Merge pull request #18364 from prathamesh-sonpatki/ar-changelog-typos | Abdelkader Boudih | 2015-01-06 | 1 | -5/+5 | |
|\ \ \ \ | | | | | | | | | | | Fixed typos and wording in ActiveRecord CHANGELOG [ci skip] | |||||
| * | | | | Fixed typos and wording in ActiveRecord CHANGELOG [ci skip] | Prathamesh Sonpatki | 2015-01-06 | 1 | -5/+5 | |
|/ / / / | ||||||
* | | | | Merge pull request #18358 from ↵ | Yves Senn | 2015-01-06 | 4 | -1/+12 | |
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | prathamesh-sonpatki/add-test-for-non-string-labeled-fixtures Fix lookup of fixtures with non-string(like Fixnum) label | |||||
| * | | | Fix lookup of fixtures with non-string label | Prathamesh Sonpatki | 2015-01-06 | 4 | -1/+13 | |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Fixtures with non-string labels such as integers should be accessed using integer label as key. For eg. pirates(1) or pirates(42). - But this results in NotFound error because the label is converted into string before looking up into the fixtures hash. - After this commit, the label is converted into string only if its a symbol. - This issue was fount out while adding a test case for https://github.com/rails/rails/commit/7b910917. | |||||
* | | | Merge pull request #18354 from simi/improve-request-forgery-documentation | David Heinemeier Hansson | 2015-01-05 | 1 | -3/+3 | |
|\ \ \ | | | | | | | | | Improve protect_from_forgery documentation. | |||||
| * | | | Improve protect_from_forgery documentation. [ci skip]. | Josef Šimánek | 2015-01-06 | 1 | -3/+3 | |
| | | | | ||||||
* | | | | Merge pull request #18356 from georgemillo/singularize | Rafael Mendonça França | 2015-01-05 | 1 | -2/+2 | |
|\ \ \ \ | | | | | | | | | | | removing unecessary default parameter in private method | |||||
| * | | | | removing unecessary parameter in private method | George Millo | 2015-01-06 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | '_singularize' only ever gets called with one argument | |||||
* | | | | | Merge pull request #18355 from georgemillo/docs | Sean Griffin | 2015-01-05 | 1 | -0/+3 | |
|\ \ \ \ \ | | | | | | | | | | | | | Documenting 'remove_possible_method' and 'redefine_method' [ci skip] | |||||
| * | | | | | adding documentation for 'remove_possible_method' and 'redefine_method' [ci ↵ | George Millo | 2015-01-05 | 1 | -0/+3 | |
| |/ / / / | | | | | | | | | | | | | | | | skip] | |||||
* | | | | | Merge pull request #18350 from brainopia/fix_build_from_bind_values | Sean Griffin | 2015-01-05 | 2 | -2/+12 | |
|\ \ \ \ \ | |_|/ / / |/| | | | | Propagate bind_values from join in subquery | |||||
| * | | | | Correctly fetch bind_values from join in subquery | brainopia | 2015-01-06 | 2 | -2/+12 | |
| | | | | | ||||||
* | | | | | Define attribute methods before attempting to populate records | Sean Griffin | 2015-01-05 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `initialize_internals_callback` will attempt to assign attributes from the current scope, which will fail if something defined the method and calls super (meaning it won't hit `method_missing`). Fixes #18339 | |||||
* | | | | | Whitespace fixes from #18349 | Sean Griffin | 2015-01-05 | 1 | -2/+1 | |
| | | | | |