rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
\| \| * \| \| \| \| \| \|	Now returning html if html is blank? in FullSanitizer and ↵	Timm	2014-06-16	2	-5/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	WhiteListSanitizer. This means it'll return false if called with false, however that is not a valid use case.
\| \| * \| \| \| \| \| \|	Stylistic improvements. Some light documentation for remove_xpaths.	Timm	2014-06-16	1	-6/+8
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Removed require's for html-scanner.	Timm	2014-06-16	3	-2/+3
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Changed test expectation from '<<' to '' with string to sanitize '<<<bad ↵	Timm	2014-06-16	1	-4/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	html>' in sanitizers_test.
\| \| * \| \| \| \| \| \|	Added deprecation warning to ActionDispatch::Assertions::TagAssertions.	Timm	2014-06-16	1	-0/+3
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Removed dom_assertion method since it created bugs.	Timm	2014-06-16	1	-8/+6
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Fixed uninitialized constant ActionView::HTML error entered after recent git ↵	Timm	2014-06-16	1	-1/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	rebase.
\| \| * \| \| \| \| \| \|	Removed a bunch of duplicated tests in SanitizeHelperTest.	Timm	2014-06-16	1	-37/+0
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Removed unnecessary documentation in DomAssertions.	Timm	2014-06-16	1	-7/+0
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Removed case statement in equal_children? used child.element? instead.	Timm	2014-06-16	1	-2/+1
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Reworked some internal documentation for equal_attribute_nodes?.	Timm	2014-06-16	1	-3/+2
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Changed attributes_are_equal? to equal_attribute_nodes? which takes ↵	Timm	2014-06-16	1	-7/+8
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	attribute_nodes instead of nodes.
\| \| * \| \| \| \| \| \|	Removed html_strings variable, no splat operator needed.	Timm	2014-06-16	1	-4/+4
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Changed back to =~ or == comparison in HTMLSelector filter.	Timm	2014-06-16	1	-2/+2
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Simplified the removal of xpaths in remove_xpaths. Added more tests for ↵	Timm	2014-06-16	2	-9/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	remove_xpaths.
\| \| * \| \| \| \| \| \|	Fixed: added apostrophe to possessive noun.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Extracted: create Regexp from match_with and use =~ to compare instead of ↵	Timm	2014-06-16	1	-1/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	checking .is_a? Regexp every time through the loop.
\| \| * \| \| \| \| \| \|	Changed conditional check in filter. Removed weird comments.	Timm	2014-06-16	1	-7/+3
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Moved: initial assignment of @selector_is_second_argument is now in initialize.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Changed: using duck typing instead of requiring subclasses of Node and NodeSet.	Timm	2014-06-16	1	-4/+1
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Renamed: HTMLSelector css_selector to selector.	Timm	2014-06-16	1	-7/+7
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Removed unnecessary lines from HTMLSelector initialize.	Timm	2014-06-16	1	-3/+1
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Changed: put selector extraction into selector_from, which is renamed to ↵	Timm	2014-06-16	1	-4/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	extract_selector.
\| \| * \| \| \| \| \| \|	Changed: HTMLSelector comparisons renamed to equality_tests.	Timm	2014-06-16	1	-9/+6
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Changed: removed @selected and @page variables from HTMLSelector since one ↵	Timm	2014-06-16	1	-10/+8
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	method used them. Passed the values directly to there instead.
\| \| * \| \| \| \| \| \|	Changed: return early from compare_doms if the two doms don't have the same ↵	Timm	2014-06-16	1	-0/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	number of children.
\| \| * \| \| \| \| \| \|	Renamed: remove_xpaths tests no longer prefixed with sanitizer.	Timm	2014-06-16	1	-6/+6
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Changed: remove_xpaths called with String returns String, while called with ↵	Timm	2014-06-16	2	-2/+13
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Loofah fragment returns Loofah fragment. Added tests for this.
\| \| * \| \| \| \| \| \|	Fixed: spelling mistake in SanitizeHelperTest.	Timm	2014-06-16	1	-3/+3
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Removed duplication in assert_dom_equal and assert_dom_not_equal.	Timm	2014-06-16	1	-9/+6
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Changed wording of missing selector argument exception message in css_select.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Reworked root and selector conditional assignment in css_select.	Timm	2014-06-16	1	-5/+2
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Added related Nokogiri issue link to tests that fail with unknown encoding ↵	Timm	2014-06-16	2	-6/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ASCII-8BIT.
\| \| * \| \| \| \| \| \|	Moved Action Pack changelog message to Action View. Clarified Dom and ↵	Timm	2014-06-16	1	-0/+14
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Selector assertions changes in there.
\| \| * \| \| \| \| \| \|	Trimmed deprecation message for ActionDispatch::Assertions::SelectorAssertions.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Removed :nodoc: from PermitScrubber.	Timm	2014-06-16	1	-1/+0
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Reworked documentation for PermitScrubber and TargetScrubber.	Timm	2014-06-16	1	-2/+33
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Fixed: spelling error.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Initialized tags and attributes to nil.	Timm	2014-06-16	1	-0/+4
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Refactored scrub to keep_node? instead of scrub_node calling it. Also added ↵	Timm	2014-06-16	1	-6/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ability to stop traversing by returning STOP from scrub_node.
\| \| * \| \| \| \| \| \|	Changed PermitScrubber to be even more extensible. Updated TargetScrubber to ↵	Timm	2014-06-16	1	-39/+40
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	be compliant. Updated documentation for PermitScrubber and TargetScrubber for clarity.
\| \| * \| \| \| \| \| \|	Changed PermitScrubbers documentation to list override points for ↵	Timm	2014-06-16	1	-12/+15
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	subclasses. Renamed should_remove_attributes? to should_scrub_attributes?.
\| \| * \| \| \| \| \| \|	Already killed off LinkScrubber. Changed it instead to be TargetScrubber, ↵	Timm	2014-06-16	2	-9/+20
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	which is more general, while still allowing maximum code reuse.
\| \| * \| \| \| \| \| \|	Added LinkScrubber to remove duplication in LinkSanitizer. As such made ↵	Timm	2014-06-16	2	-11/+22
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	PermitScrubber easier to subclass.
\| \| * \| \| \| \| \| \|	Changed FullSanitizer sanitize to use tap method instead of temporary variable.	Timm	2014-06-16	1	-3/+3
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Extracted the common xpaths to remove into XPATHS_TO_REMOVE.	Timm	2014-06-16	1	-2/+4
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Refactored remove_xpaths to use duck typing and read better.	Timm	2014-06-16	1	-4/+5
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Changed explanation for no duck typing of custom scrubbers.	Timm	2014-06-16	1	-1/+2
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Added correct requires in html-scanner tests. Sanitizers are not based on ↵	Timm	2014-06-16	7	-330/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	html-scanner anymore, so sanitizer_test.rb is removed.
\| \| * \| \| \| \| \| \|	Require ActionView::Assertions in ActionController test_case.rb.	Timm	2014-06-16	1	-0/+1
\| \| \| \| \| \| \| \| \|