| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \
| | |
| | | |
Add missing test cases for schema dumping defaults
|
| | | |
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Before this patch, using `ActiveRecord::Base.primary_key_prefix_type`
with `:table_name_with_underscore` would change the `SchemaMigration` model
to have a primary key. This resulted in broken queries for PG because it tried
to return the inserted PK (which does not exist).
Closes #15051.
Closes #15419.
|
| | | |
|
| | |
| | |
| | |
| | | |
/cc @zuhao
|
|/ /
| |
| |
| |
| |
| |
| | |
This adds a regression test for #14411, which was fixed by #15503.
Closes #14411
Closes #14595
|
|\ \
| | |
| | | |
Bring type casting behavior of hstore/json in line with serialized
|
| | |
| | |
| | |
| | |
| | | |
`@raw_attributes` should not contain the type-cast, mutable version of
the value.
|
|\ \ \
| | | |
| | | | |
Use a frozen Set instance for CGI_VARIABLES.
|
| | | |
| | | |
| | | | |
Also expand the CGI_VARIABLE name listing to multiple lines for cleaner diffs and legibility.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The migration numbers were normalized different ways. This left
the task output in an inconsistent state.
Closes #15538.
|
| | | |
| | | |
| | | |
| | | | |
Closes #15541.
|
|\ \ \ \
| |/ / /
|/| | |
| | | | |
Baseclass becomes! subclass
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Remove optimization that was required with whiny nils
|
| | | | |
| | | | |
| | | | |
| | | | | |
Whiny nils is no longer a thing, so we no longer need this optimization
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Avoid misuse of underscore argument
|
|/ / / / /
| | | | |
| | | | | |
Per convention, underscore-only argument names should be used for unused parameters.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Reset callbacks after test.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Otherwise the state of callback chain is leaked.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Removed CaptureHelper#flush_output_buffer as it is only used in tests.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
reviewed: @tenderlove
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
document include_blank's usage with a string [ci skip]
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Restore Response.default_headers after test.
|
| | |_|_|/ / / /
| |/| | | | | | |
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Avoid hard-coded value in test setup/teardown.
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Make sure Mime::Type is not altered after tests.
|
| |/ / / / / / |
|
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Fix BC year handling in postgres
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
BC era year is (astronomical year + 1) and starts from 1 BC.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | | |
zuhao/refactor_actionpack_query_string_parsing_test
Avoid hardcoded value in test setup/teardown.
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Remove deprecated method ActiveRecord::Migrator.proper_table_name
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Fixed `ActiveSupport::TimeWithZone#-` so precision is not unnecessarily lost
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
When working with objects with a nanosecond component, the `-` method may
unnecessarily cause loss of precision.
`ActiveSupport::TimeWithZone#-` should return the same result as if we were
using `Time#-`:
Time.now.end_of_day - Time.now.beginning_of_day #=> 86399.999999999
Before:
Time.zone.now.end_of_day.nsec #=> 999999999
Time.zone.now.end_of_day - Time.zone.now.beginning_of_day #=> 86400.0
After:
Time.zone.now.end_of_day - Time.zone.now.beginning_of_day
#=> 86399.999999999
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Added Two Clarification "Tips" [ci skip]
|
| | | | | | | |
| | | | | | | |
| | | | | | | | |
It's not very clear exactly what the "params" method is and does, as the current description in the guide is somewhat vague and brief. An example is helpful, especially considering this method is referenced over 30 times in this guide. [ci skip]
|
| | |/ / / / /
| |/| | | | |
| | | | | | | |
It may be confusing to a Rails newbie why "Article" is suddenly being referred to with the "A" being capitalized. Thus far in the guide, the "a" has always been in lowercase. I think it is helpful to point out the reason for this change (especially since not using the capital "A" will result in an error). [ci skip]
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fix inverse associations test
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`InverseHasManyTests#test_parent_instance_should_be_shared_within_create_block_of_new_child`
was mistakenly the same as
`InverseHasManyTests#test_parent_instance_should_be_shared_within_build_block_of_new_child`.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
schneems/schneems/levenshtein-generator-failure-messages
Emit suggested generator names when not found
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When someone types in a generator command it currently outputs all generators. Instead we can attempt to find a subtle mis-spelling by running all generator names through a levenshtein_distance algorithm provided by rubygems.
So now a failure looks like this:
```ruby
$ rails generate migratioooons
Could not find generator 'migratioooons'. Maybe you meant 'migration' or 'integration_test' or 'generator'
Run `rails generate --help` for more options.
```
If the suggestions are bad we leave the user with the hint to run `rails generate --help` to see all commands.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Follow up to #15438 and #15502.
/cc @sgrif
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit c22a253d1a72602331db1eba3e91bc945eff2346.
Reason: Our documentation assumes the assets are in the proper place and
we are using the default Rails stack.
With the default Rails stack and the assets being in the correct place
the assets helpers uses the `/assets` prefix.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Use null column for association key types
|
| | |_|_|/ /
| |/| | | | |
|