aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Tiny follow-up to #15987 and 088b4c3e [ci skip]Robin Dupret2014-07-021-4/+4
|
* do not hold on to a stale connection object. fixes #15998Aaron Patterson2014-07-012-6/+14
|
* Merge pull request #15999 from ↵Rafael Mendonça França2014-07-011-0/+32
|\ | | | | | | | | eileencodes/add-regression-tests-for-keys-on-nested-associations Add regression tests for keys on nested associations
| * Add regression tests for keys on nested associationseileencodes2014-07-011-0/+32
| | | | | | | | | | | | This adds the regressions tests from issue #15893 to master. It's checking that both strings and symbols are accepted as keys for nested associations.
* | Merge pull request #16006 from ShunsukeAida/xml_http_request_comment_changeRafael Mendonça França2014-07-011-2/+2
|\ \ | | | | | | [ci skip] Fixed the documentation of xml_http_request? (aka xhr?)
| * | makes it sound less misleadingShunsukeAida2014-07-021-2/+2
| | |
* | | Rename preview_enabled option to show_previewsRafael Mendonça França2014-07-016-20/+20
| | |
* | | Merge pull request #15970 from ↵Rafael Mendonça França2014-07-017-3/+80
|\ \ \ | |/ / |/| | | | | | | | | | | lengarvey/add_configuration_option_for_mail_preview Add configuration to enable mail previews
| * | Add configuration to enable mail previewsLeonard Garvey2014-07-017-3/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds `config.action_mailer.preview_enabled` This allows mail previewing to be enabled easily in non-development environments such as staging. The default is set to true for development so no changes should be required to existing Rails applications. The mail preview path can still be configured using the existing `config.action_mailer.preview_path` configuration option. Adding this avoids devs from having to do stuff like: https://gist.github.com/lengarvey/fa2c9bd6cdbeba96526a Update actionmailer/CHANGELOG with new configuration. Update configuring guide with new configuratation. Add `config.action_mailer.preview_path` to configuring guide.
* | | Merge pull request #16000 from sgrif/sg-silence-warningMatthew Draper2014-07-021-0/+1
|\ \ \ | | | | | | | | Silence warning emitted in tests
| * | | Silence warning emitted in testsSean Griffin2014-07-011-0/+1
| | | | | | | | | | | | | | | | | | | | The instance method `model_name` was being defined multiple times, causing a redefinition warning.
* | | | Merge pull request #16004 from JuanitoFatas/doc/patch-1Rafael Mendonça França2014-07-011-0/+2
|\ \ \ \ | |/ / / |/| | | [ci skip] Add missing prologue section of upgrading ruby on rails guide.
| * | | [ci skip] Add missing prologue section of upgrading ruby on rails guide.Juanito Fatas2014-07-011-0/+2
| | |/ | |/|
* | | Merge pull request #15997 from cirosantilli/typoEileen M. Uchitelle2014-07-011-1/+1
|\ \ \ | |/ / |/| | Fix doc unwanted dl Admin:: [ci skip]
| * | Fix doc unwanted dl Admin:: [ci skip]Ciro Santilli2014-07-011-1/+1
|/ /
* | push host / port / protocol extraction upAaron Patterson2014-06-301-6/+6
| | | | | | | | Then we only need to extract host once.
* | Add CHANGELOG entry for #15214Rafael Mendonça França2014-06-301-0/+4
| | | | | | | | Closes #15214
* | Use if/elseRafael Mendonça França2014-06-301-2/+5
| | | | | | | | | | Since we are using both branches of the code is preferable to use if/else over the early return.
* | Merge pull request #15214 from todd/date_field_docsRafael Mendonça França2014-06-303-2/+119
|\ \ | | | | | | | | | Added String support for min and max properties for date field helpers
| * | Add String support for min/max attributes on DatetimeFieldTodd Bealmear2014-06-303-2/+119
|/ /
* | Rename rollback_changes to undo_changesRafael Mendonça França2014-06-303-6/+6
| | | | | | | | To avoid overload with database rollback
* | Add CHANGELOG entry for #14861 and document private methods on the APIRafael Mendonça França2014-06-302-5/+10
| |
* | Merge pull request #14861 from igor04/dirty-rollbackRafael Mendonça França2014-06-302-0/+35
|\ \ | | | | | | | | | Added rollback method to ActiveModel::Dirty
| * | Added rollback method to ActiveModel::Dirtyigor042014-06-232-0/+35
| | |
* | | Merge pull request #15991 from sgrif/sg-has-attributeRafael Mendonça França2014-06-301-6/+1
|\ \ \ | | | | | | | | Don't add a second method for attribute existence
| * | | Don't add a second method for attribute existenceSean Griffin2014-06-301-6/+1
|/ / / | | | | | | | | | | | | We already had one in the public API that people can use more easily for the transition
* | | Merge pull request #15989 from nickpellant/masterRafael Mendonça França2014-06-301-1/+1
|\ \ \ | | | | | | | | Fix 10.3 invite_email.body assert_match documentation example.
| * | | Fix 10.3 invite_email.body assert_match example.Nick Pellant2014-06-301-1/+1
|/ / / | | | | | | | | | | | | Currently there is no implicit conversion for Mail::Body to string therefore .to_s must be applied. This is exampled in 10.2.2.
* | | Move STI docs off of the main Base document, leaving a noteSean Griffin2014-06-302-28/+34
| | |
* | | Merge pull request #15987 from jamesprior/patch-2Sean Griffin2014-06-301-0/+9
|\ \ \ | | | | | | | | Update documentation on STI change handling
| * | | Update documentation on STI change handlingjamesprior2014-06-301-0/+9
|/ / / | | | | | | Documenting a potential source of confusion about how STI classes handle changes.
* | | Merge pull request #15981 from sgrif/sg-simplify-defaultsRafael Mendonça França2014-06-293-21/+9
|\ \ \ | | | | | | | | Simplify creation of default attributes on AR instance
| * | | Simplify creation of default attributes on AR instanceSean Griffin2014-06-294-21/+10
| | | | | | | | | | | | | | | | `AttributeSet#dup` has all the behavior we need.
* | | | Merge pull request #15977 from sgrif/sg-remove-array-hackGodfrey Chan2014-06-291-24/+0
|\ \ \ \ | | | | | | | | | | Remove array workaround in PG quoting
| * | | | Remove array workaround in PG quotingSean Griffin2014-06-291-24/+0
| | | | | | | | | | | | | | | | | | | | | | | | | We no longer need to do fancy legwork to make sure arrays use a type object, now that schema methods use a real type object.
* | | | | Merge pull request #15978 from sgrif/sg-pg-array-memberGodfrey Chan2014-06-292-12/+9
|\ \ \ \ \ | |/ / / / |/| | | | Remove unused `array_member` from PG quoting for HStore columns
| * | | | Remove unused `array_member` from PG quoting for HStore columnsSean Griffin2014-06-292-12/+9
|/ / / / | | | | | | | | | | | | | | | | Hstore no longer needs additional quoting to be used in an array, the array type handles it sufficiently.
* | | | Merge pull request #15983 from sgrif/sg-inline-pointGodfrey Chan2014-06-293-19/+9
|\ \ \ \ | | | | | | | | | | Use the type object when sending point columns to the DB
| * | | | Use the type object when sending point columns to the DBSean Griffin2014-06-293-19/+9
| | | | |
* | | | | Merge pull request #15976 from sgrif/sg-attribute-existsGodfrey Chan2014-06-291-2/+7
|\ \ \ \ \ | |/ / / / |/| | | | Don't encourage usage of `columns_hash`
| * | | | Don't encourage usage of `columns_hash`Sean Griffin2014-06-291-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed in https://github.com/plataformatec/simple_form/pull/1094, we should not encourage usage of `columns_hash`, and instead provide an alternate method to determine whether or not an attribute exists. The language `attribute` was chosen over `column` since these are in the `AttributeMethods` module.
* | | | | Merge pull request #15982 from sgrif/sg-attr-set-map-valuesGodfrey Chan2014-06-292-7/+4
|\ \ \ \ \ | | | | | | | | | | | | Use `Hash#transform_values` to clean up `AttributeSet`
| * | | | | Use `Hash#transform_values` to clean up `AttributeSet`Sean Griffin2014-06-292-7/+4
| | |/ / / | |/| | |
* | | | | Merge pull request #15979 from sgrif/sg-json-quotingGodfrey Chan2014-06-294-23/+11
|\ \ \ \ \ | |/ / / / |/| | | | Use the type object for sending JSON to the database
| * | | | Use the type object for sending JSON to the databaseSean Griffin2014-06-294-23/+11
| |/ / /
* | | | Merge pull request #15819 from sgrif/sg-hash-map-valuesGuillermo Iguaran2014-06-294-0/+76
|\ \ \ \ | |/ / / |/| | | Add `Hash#map_values` to ActiveSupport to simplify a common pattern
| * | | Add `Hash#map_values` to ActiveSupportSean Griffin2014-06-294-0/+76
|/ / / | | | | | | | | | | | | Didn't get a chance to convert existing code, I'll skim through the code base to make use of this later this afternoon.
* | | Tiny documentation fixes [ci skip]Robin Dupret2014-06-293-5/+5
| | |
* | | Quick pass through Active Support and guides CHANGELOGRobin Dupret2014-06-292-3/+5
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #15961 from mckramer/patch-1Rafael Mendonça França2014-06-291-2/+2
|\ \ \ | | | | | | | | Rename options param of #time_ago_in_words to match API change
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-25 22:21:46 +0000