Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Restore an ability that class level `update` without giving ids | Ryuta Kamizono | 2019-01-02 | 2 | -1/+17 |
| | | | | | | | | | | | | | | | | | | That ability was introduced at #11898 as `Relation#update` without giving ids, so the ability on the class level is not documented and not tested. c83e30d which fixes #33470 has lost two undocumented abilities. One has fixed at 5c65688, but I missed the ability on the class level. Removing any feature should not be suddenly happened in a stable version even if that is not documented. I've restored the ability and added test case to avoid any regression in the future. Fixes #34743. | ||||
* | Fix TypeError: no implicit conversion of Arel::Attributes::Attribute into ↵ | Ryuta Kamizono | 2019-01-02 | 2 | -1/+3 |
| | | | | | | | | | | | | | String properly This reverts 27c6c07 since `arel_attr.to_s` is not right way to avoid the type error. That to_s returns `"#<struct Arel::Attributes::Attribute ...>"`, there is no reason to match the regex to the inspect form. And also, the regex path is not covered by our test cases. I've tweaked the regex for redundant part and added assertions for the regex path. | ||||
* | :scissors: | Ryuta Kamizono | 2019-01-02 | 1 | -1/+1 |
| | | | [ci skip] | ||||
* | Fix links in ingress docs [ci skip] | George Claghorn | 2019-01-01 | 2 | -2/+2 |
| | |||||
* | Exclude ActionMailbox::Base#perform_processing and #finished_processing? ↵ | George Claghorn | 2019-01-01 | 1 | -2/+2 |
| | | | | from API docs | ||||
* | Document ActionMailbox::Base#bounce_with [ci skip] | George Claghorn | 2019-01-01 | 1 | -0/+1 |
| | |||||
* | Add load hook for ActionMailbox::TestCase | George Claghorn | 2018-12-31 | 2 | -0/+3 |
| | |||||
* | Update the load hooks reference table [ci skip] | George Claghorn | 2018-12-31 | 1 | -0/+3 |
| | |||||
* | Bump Nokogiri for sparklemotion/nokogiri@bf41ba0 | George Claghorn | 2018-12-31 | 1 | -8/+8 |
| | |||||
* | Add load hook for ActionMailbox::Base | George Claghorn | 2018-12-31 | 1 | -0/+2 |
| | |||||
* | Merge pull request #34707 from xlts/update-notifications-docs | Gannon McGibbon | 2018-12-31 | 2 | -9/+35 |
|\ | | | | | Add examples describing error handling in ActiveSupport::Notification… | ||||
| * | Add examples describing error handling in ActiveSupport::Notifications and ↵ | Mariusz Hausenplas | 2018-12-14 | 2 | -9/+35 |
| | | | | | | | | ActiveSupport::LogSubscriber documentation files | ||||
* | | Merge pull request #34624 from ↵ | Gannon McGibbon | 2018-12-31 | 1 | -1/+3 |
|\ \ | | | | | | | | | | | | | blaszczakphoto/update-docs-regarding-gzipping-assets Rename header of the gzip paragraph | ||||
| * | | Rename header of the gzip paragraph to more accurate and add short info ↵ | Mariusz Błaszczak | 2018-12-21 | 1 | -1/+3 |
| | | | | | | | | | | | | aboaut what to do about serving gziped files [ci skip] | ||||
* | | | Merge pull request #34834 from gmcgibbon/mention_tiff_support_in_guides | George Claghorn | 2018-12-31 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Mention tiff support in ActiveStorage guides | ||||
| * | | | Mention tiff support in ActiveStorage guides | Gannon McGibbon | 2018-12-31 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | [ci skip] | ||||
* | | | | Merge pull request #34833 from ↵ | George Claghorn | 2018-12-31 | 1 | -1/+1 |
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | bogdanvlviv/add-changelog-file-to-actionmailbox-specification Add CHANGELOG.md to actionmailbox gem specification | ||||
| * | | | Add CHANGELOG.md to actionmailbox gem specification | bogdanvlviv | 2018-12-31 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge pull request #34831 from arunagw/bump-year-to-2019 | Arun Agrawal | 2018-12-31 | 23 | -23/+23 |
|\ \ \ \ | |/ / / |/| | | | Bump license years for 2019 | ||||
| * | | | Bump license years for 2019 | Arun Agrawal | 2018-12-31 | 23 | -23/+23 |
| | | | | |||||
* | | | | Merge pull request #34740 from sponomarev/feature/assert_has_stream | George Claghorn | 2018-12-31 | 2 | -6/+73 |
|\ \ \ \ | | | | | | | | | | | Add streams assert methods to ActionCable channel test case | ||||
| * | | | | Add streams assert methods to ActionCable channel test case | Sergey Ponomarev | 2018-12-18 | 2 | -6/+73 |
| | | | | | |||||
* | | | | | Add load hook for ActionMailbox::InboundEmail | George Claghorn | 2018-12-31 | 1 | -0/+2 |
| |/ / / |/| | | | |||||
* | | | | Permit generating variants of TIFF images | Luciano Sousa | 2018-12-30 | 4 | -0/+17 |
| | | | | |||||
* | | | | Add Rake task for testing mailboxes | George Claghorn | 2018-12-30 | 3 | -3/+19 |
| | | | | |||||
* | | | | Tweak test name | George Claghorn | 2018-12-30 | 1 | -1/+1 |
| | | | | |||||
* | | | | Make Active Storage blob keys lowercase | Julik Tarkhanov | 2018-12-30 | 6 | -7/+67 |
| | | | | | | | | | | | | Accommodate case-insensitive filesystems and database collations. | ||||
* | | | | Switch to released rb-inotify 0.10.0 | Matthew Draper | 2018-12-31 | 2 | -12/+2 |
| | | | | | | | | | | | | | | | | It contains guard/rb-inotify#79, which is what we were waiting for. | ||||
* | | | | Merge pull request #34825 from ↵ | George Claghorn | 2018-12-29 | 4 | -4/+4 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | bogdanvlviv/change-migration-version-of-actionmailbox Use 6.0 version of `ActiveRecord::Migration` for Action Mailbox | ||||
| * | | | | Use 6.0 default configs in Active Storage test dummy app | bogdanvlviv | 2018-12-30 | 1 | -1/+1 |
| | | | | | |||||
| * | | | | Use 6.0 version of ActiveRecord::Migration for Action Mailbox | bogdanvlviv | 2018-12-30 | 3 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Action Mailbox will be introduced in Rails 6.0, it makes more sense to generate migration of that version. Also I changed its test dummy app to use default 6.0 configs. | ||||
* | | | | | Merge pull request #34812 from bogdanvlviv/action_mailbox-guides-docs | George Claghorn | 2018-12-29 | 5 | -314/+324 |
|\ \ \ \ \ | |/ / / / |/| | | | | Add Action Mailbox to guides | ||||
| * | | | | Add Action Mailbox to Major Features of Rails 6.0 [ci skip] | bogdanvlviv | 2018-12-30 | 1 | -0/+9 |
| | | | | | |||||
| * | | | | Fix Action Mailer Basics [ci skip] | bogdanvlviv | 2018-12-30 | 2 | -47/+7 |
| | | | | | | | | | | | | | | | | | | | | Now Action Mailbox is responsible for receiving emails. | ||||
| * | | | | Move some `actionmailbox/README.md` content to Action Mailbox Basics guide ↵ | bogdanvlviv | 2018-12-30 | 3 | -267/+308 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] I added WIP label to that guide since we definitely want to complement it. | ||||
* | | | | | Don't load Action Mailbox when Active Storage is skipped | George Claghorn | 2018-12-29 | 2 | -1/+6 |
| | | | | | |||||
* | | | | | Do not show suggestion message when not exist suggestion | yuuji.yaginuma | 2018-12-29 | 4 | -2/+12 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | **before** ``` $ ./bin/rails g g Could not find generator 'g'. Maybe you meant nil? Run `rails generate --help` for more options. ``` **after** ``` $ ./bin/rails g g Could not find generator 'g'. Run `rails generate --help` for more options. ``` | ||||
* | | | | | Require railties for all Action Mailbox dependencies | George Claghorn | 2018-12-28 | 1 | -1/+6 |
| | | | | | |||||
* | | | | | Merge pull request #34820 from bogdanvlviv/extract-text-from-34816 | George Claghorn | 2018-12-28 | 1 | -0/+5 |
|\ \ \ \ \ | | | | | | | | | | | | | Ensure that the app generator skips action mailbox when `--skip-active-record` is given | ||||
| * | | | | | Ensure that the app generator skips action mailbox when ↵ | bogdanvlviv | 2018-12-28 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `--skip-active-record` is given Related to https://github.com/rails/rails/pull/34816#issuecomment-450378366 Follow up https://github.com/rails/rails/commit/ddaf06779aa51d5d1ca462c21c53f2ed169a0d2f | ||||
* | | | | | | Remove frozen_string_literal pragma from Action Mailbox templates | George Claghorn | 2018-12-28 | 2 | -4/+0 |
|/ / / / / | |||||
* | | | | | Label Action Mailbox PRs | George Claghorn | 2018-12-28 | 1 | -0/+2 |
| | | | | | |||||
* | | | | | Merge pull request #34814 from bogdanvlviv/follow-up-e3f832a7433a | George Claghorn | 2018-12-28 | 2 | -29/+4 |
|\ \ \ \ \ | | | | | | | | | | | | | Remove mention about `receive.action_mailer` from the AS instrumentation guide | ||||
| * | | | | | Remove mention about `receive.action_mailer` from the AS instrumentation guide | bogdanvlviv | 2018-12-28 | 2 | -29/+4 |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | Since e3f832a7433a291a51c5df397dc3dd654c1858cb `ActionMailer::Base.receive` is deprecated. | ||||
* | | | | | Fix broken Mailbox generator test | yuuji.yaginuma | 2018-12-28 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | Follow up to d082439cf7e577e266bfeb7b443569f323df1673 | ||||
* | | | | | Add missing quotes on Mailbox test template | yuuji.yaginuma | 2018-12-28 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Don't load Action Mailbox when Active Record is skipped | George Claghorn | 2018-12-28 | 2 | -2/+7 |
| | | | | | |||||
* | | | | | Load Action Mailbox when other components are skipped | George Claghorn | 2018-12-28 | 1 | -0/+1 |
| | | | | | |||||
* | | | | | Deprecate ActionMailer::Base.receive in favor of Action Mailbox | George Claghorn | 2018-12-27 | 5 | -40/+14 |
| | | | | | |||||
* | | | | | Use high level API on `migration_context` instead of using low level API ↵ | Ryuta Kamizono | 2018-12-28 | 2 | -13/+11 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | directly Since `migration_context` has `migrations_paths` itself and provides methods which returning values from parsed migration files, so there is no reason to use the `parse_migration_filename` low level API directly. |