| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Refactor `case_{sensitive|insensitive}_comparison`
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before:
```
SELECT 1 AS one FROM "topics" WHERE "topics"."title" = 'abc' LIMIT $1 [["LIMIT", 1]]
```
After:
```
SELECT 1 AS one FROM "topics" WHERE "topics"."title" = $1 LIMIT $2 [["title", "abc"], ["LIMIT", 1]]
```
|
| |
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | |
| | |
| | | |
rthbound/adds-exception-object-to-instrumenter-payload
Adds exception object to instrumenter's payload
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Adds new key/value pair to payload when an exception is raised
e.g. `:exception_object=> #<RuntimeError: FAIL>`
- Updates relevant test
- Adds CHANGELOG entry
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
prathamesh-sonpatki/create-application-model-under-namespaced-dir-in-plugin
Create application_record.rb under namespaced directory in plugin
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Earlier it was creating application_record.rb under `app/models`, after
this change, it will create application_record.rb under
`app/models/plugin_name` similar to other application classes.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
It was made public by mistake in
https://github.com/rails/rails/commit/539b69e0.
|
|\ \ \ \
| | | | |
| | | | | |
Remove unnecessary enable,disable_extension on tests
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
uuid-ossp extension is alreadly enabled on test schema.
And `disable_extension!('uuid-ossp', connection)` can be a cause of test failure.
`ActiveRecord::StatementInvalid: PG::UndefinedFunction: ERROR: function uuid_generate_v1() does not exist`
will happen depending on the execution order.
|
|\ \ \ \
| | | | |
| | | | | |
Better example for ActiveRecord::Relation#or [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
iguchi1124/fix-to-remove-wasted-space-in-cable-coffee
Remove a wasted space [ci skip]
|
|/ / / / / |
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
using `enum kind: [ :any, :income, :expense ]` syntax, value is already an
integer and using `enum kind: { any: 'any', income: 'income', expense:
'expense' }` syntax value is a string.
This allows us to define the mapping in the enum definition.
This reverts commit 933decceaf6092020ba7ba768b51b2db9d5b882f.
|
|\ \ \ \
| | | | |
| | | | | |
Add tests for ActionController::Renderers::use_renderers
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Update copyright notices to 2016 [ci skip]
|
|/ / / / |
|
|\ \ \ \
| |/ / /
|/| | | |
Remove client-side Action Cable debugging code
|
|/ / /
| | |
| | |
| | | |
Added to aid in developing Action Cable, but isn't neccessary for production operation.
|
|\ \ \
| | | |
| | | | |
Fix AC::Parameters#to_unsafe_h to return all unfiltered values
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- AC::Parameters#convert_parameters_to_hashes should return filtered or
unfiltered values based on whether it is called from `to_h` or `to_unsafe_h`
instead of always defaulting to `to_h`.
- Fixes #22841
|
|\ \ \ \
| | | | |
| | | | | |
Lets not put fullstop at the end of a migration pending command
|
| | | | |
| | | | |
| | | | |
| | | | | |
- So that we can just copy paste the command and execute it
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
morgoth/fix-errors-details-on-autosave-associations
Fixed setting errors details on autosaved associations
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Configurable redirect and secure cookies for ActionDispatch::SSL
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Support extended grapheme clusters and UAX 29
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
We how have tests for every rule in UAX 29.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
http://www.unicode.org/reports/tr29/tr29-21.html is the version of UAX
29 that corresponds to Unicode 6.2.0. Unicode.unpack_graphemes now
implements all the rules listed there, including the ones for extended
grapheme clusters.
I added a new optional test,
test/multibyte_grapheme_break_conformance.rb, that is heavily based on
test/multibyte_normalization_conformance.rb, which runs the Unicode test
suite.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This test is only testing normalization behavior, not any other Unicode
behaviors.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This will make it easier to add the rest of the rules listed in UAX 29.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
the radios
Fixes #22773
|
|\ \ \ \ \ \ \
| |_|_|_|_|/ /
|/| | | | | | |
Fix typo in Testing guide: test -> text
|
|/ / / / / / |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Two USAGE files were referring to Active Record and Active Model
without a space, which is incorrect because we're referring to
the framework name and not the constants.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
It didn't mention Action Cable's engine.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Avoid `Time.parse` for static date
|
| | |_|_|_|/
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Benchmark.ips do |x|
x.report('Time.parse') { Time.parse('2011-01-01') }
x.report('Time.new') { Time.new(2011, 1, 1) }
end
Calculating -------------------------------------
Time.parse 6.640k i/100ms
Time.new 15.082k i/100ms
-------------------------------------------------
Time.parse 71.915k (± 3.1%) i/s - 365.200k
Time.new 167.645k (± 3.3%) i/s - 844.592k
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
It was removed by mistake at 877a411d0c16baa4e670dae9a28f5cfcc201adc1
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Make `postgresql_version` public
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This is useful to libraries that want to feature gate based on the
version of PostgreSQL the user is connected to. For instance, I want to
know if the user is connected to a version of Postgres that supports
concurrent materialized view refreshes. I could add that as a method on
the adapter as a PR, but rails has no need for this itself.
Rails is already using the postgresql_version for its own feature gating
and this makes that possible for other libraries.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix test for AC::Parameters#to_unsafe_h
|
| | |_|_|_|/
| |/| | | |
| | | | | |
| | | | | | |
- Test should call `to_unsafe_h` instead of `to_h`
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add `columns_for_distinct` for MySQL 5.7 with ONLY_FULL_GROUP_BY
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In MySQL 5.7.5 and up, ONLY_FULL_GROUP_BY affects handling of queries
that use DISTINCT and ORDER BY. It requires the ORDER BY columns in the
select list for distinct queries, and requires that the ORDER BY include
the distinct column.
See https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html
|