| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
This reverts commit dd779c9686f49f5ed6dda8ad5a1cb3b0788e1dd4.
|
|
|
|
|
|
| |
ActiveSupport::TestCase now"
This reverts commit 98d0f7ebd34b858f12a12dcf37ae54fdbb5cab64.
|
|
|
|
| |
This reverts commit 8d2866bb80fbe81acb04f5b0c44f152f571fb29f.
|
| |
|
| |
|
| |
|
|\
| |
| | |
Remove duplicate method definition
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
no_color! is already defined in [`Rails::Command::Behavior`][behavior],
which gets [included into `Rails:Generators`][include]. This duplication
came about in 6813edc7d9 when we introduced the Thor command structure.
We have [test coverage][] to ensure this method still behaves correctly
on `Rails:Generators`.
[behavior]: https://github.com/rails/rails/blob/f7e91c7224560fbd3e95c238a0e8bb362799bcb7/railties/lib/rails/command/behavior.rb#L12-L14
[include]: https://github.com/rails/rails/blob/f7e91c7224560fbd3e95c238a0e8bb362799bcb7/railties/lib/rails/generators.rb#L18
[test coverage]: https://github.com/rails/rails/blob/f7e91c7224560fbd3e95c238a0e8bb362799bcb7/railties/test/generators_test.rb#L163-L168
|
| |
| |
| |
| | |
To avoid "uninitialized constant ActiveSupport::Testing (NameError)"
|
|/ |
|
|\
| |
| | |
Add tests for selecting aggregrates
|
| |
| |
| |
| |
| |
| | |
These tests verifies that aggregates like `AVG` can be selected as
"virtual attributes" on Active Record models and have the correct
column type.
|
| | |
|
| |
| |
| |
| | |
extension test
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
This hack prevails everywhere in the codebase by being copy & pasted, and it's actually not a negative thing but a necessary thing for framework implementors,
so it should better have a name and be a thing.
And with this commit, activesupport/test/abstract_unit.rb now doesn't silently autoload AS::TestCase,
so we're ready to establish clearner environment for running AS tests (probably in later commits)
|
| |
| |
| |
| | |
It's used everywhere, clean and mature enough
|
|\ \
| |/
|/| |
Deduplicate joins values
|
|/
|
|
|
|
|
|
|
| |
#36805 have one possible regression that failing deduplication if
`joins_values` have complex order (e.g. `joins_values = [join_node_a,
:comments, :tags, join_node_a]`).
This fixes the deduplication to take it in the first phase before
grouping.
|
| |
|
| |
|
|\
| |
| |
| |
| | |
akshaymohite/fix-form-helpers-documentation-comment
Added missing comment notation for the example of form_with in form_helpers.md documentation. [ci skip]
|
|/
|
|
| |
form_helpers.md documentation. [ci skip]
|
|
|
|
|
| |
This causes
"NameError: undefined local variable or method `nsec' for #<DateTime:0x0000559163cdd878>"
|
| |
|
|
|
|
|
|
| |
In most cases it works now without explicit require because it's accidentally required through
active_support/core_ext/date_and_time/calculations.rb where we still call `try`,
but that would stop working if we changed the Calculations implementation and remove the require call there.
|
|
|
|
| |
and Git taught me that this crap was added via this commit... https://github.com/rails/rails/commit/68db6bc431fbff0b2291f1f60ccf974b4eece596
|
| |
|
| |
|
|\
| |
| | |
Fixed a typo in documentation example of activerecord database configuration. [ci skip]
|
| |
| |
| |
| |
| |
| | |
configuration. [ci skip]
- The example has sqlite3 adpater in database.yml, whereas configuration object had incorrectly specified mysql2 in documentation.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes the following warnings.
```
actionmailer/test/base_test.rb:272: warning: method redefined; discarding old welcome
actionmailer/test/base_test.rb:260: warning: previous definition of welcome was here
```
|
|\ \
| | |
| | | |
Upload filename and disposition for Azure
|
| | | |
|
|\ \ \
| | | |
| | | | |
Prevent error on transliterate with frozen strings
|
| | |/
| |/|
| | |
| | | |
ActiveSupport::Inflector.transliterate mutates strings by changing encodings. Prior to this commit passing a frozen string would raise a `FrozenError`. This change duplicates the internal string, if frozen, before transliterating.
|
|\ \ \
| | | |
| | | | |
Upload with filename and disposition for S3
|
| | |/
| |/| |
|
|\ \ \
| |_|/
|/| | |
Fix db:seed
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The `rake db:seed` command was broken for the primary environment if the
application is using multiple databases. We never implemented `rake
db:seed` for other databases (coming soon), but that shouldn't break the
default case.
The reason this was broken was because `abort_if_pending_migrations`
would loop through the configs for all databases and check for
migrations but would leave the last established connection. So `db:seed`
was looking in the wrong database for the table to seed.
This PR doesn't fix the fact that `db:seed` doesn't work for multiple
databases but does fix the default case.
Fixes #36817
Co-authored-by: John Crepezzi <john.crepezzi@gmail.com>
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|