rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
* \| \| \| \| \| \| \| \| \| \| \|	Stop explicitly passing `nil` as the column to `type_cast`	Sean Griffin	2015-01-01	1	-12/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	So we can change the arity later.
* \| \| \| \| \| \| \| \| \| \| \|	Stop depending on columns for type information in PG quoting tests	Sean Griffin	2015-01-01	2	-30/+29
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	A few of the tests weren't testing anything of value. The IP Address tests are testing the type, not behavior of the connection adapter. There are two CVE regression tests which are important, but don't have a good place to go, so I've left them alone for now, as they call `quote` and the focus right now is removing `column` from `type_cast`
* \| \| \| \| \| \| \| \| \| \| \|	Stop relying on columns for type information in mysql2 casting tests	Sean Griffin	2015-01-01	1	-4/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The column itself has no actual impact on the return value. These were actually testing the behavior of the type object, which is sufficiently covered elsewhere.
* \| \| \| \| \| \| \| \| \| \| \|	Stop relying on columns in mysql quoting tests	Sean Griffin	2015-01-01	1	-6/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The behavior tested by the removed lines is sufficiently covered elsewhere.
* \| \| \| \| \| \| \| \| \| \| \|	Stop relying on columns in sqlite quoting tests	Sean Griffin	2015-01-01	2	-22/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The string encoding test wasn't using the types for anything. The boolean casting test included logic that should be in the tests for the types, and the string test was legitimately not testing anything useful.
* \| \| \| \| \| \| \| \| \| \| \|	💣 I forgot to commit the arity change	Sean Griffin	2015-01-01	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \|	Don't rely on the column for type information in uniquness validations	Sean Griffin	2015-01-01	1	-1/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The validator has access to richer type information
* \| \| \| \| \| \| \| \| \| \| \|	Don't load an entire table into memory to copy it on SQLite	Sean Griffin	2015-01-01	1	-15/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	SQL has mechanisms we can use to copy data from one table into another.
* \| \| \| \| \| \| \| \| \| \| \|	Stop using the column for type information in sanitization	Sean Griffin	2015-01-01	1	-5/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	As we move towards removing the types from the column objects, any remaining places which have access to richer type information should be using it.
* \| \| \| \| \| \| \| \| \| \| \|	Stop passing the column to the connection adapter when quoting defaults	Sean Griffin	2015-01-01	1	-2/+2
\| \|/ / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The column is no longer used for anything besides type casting, which is what we're trying to remove from the column entirely.
* \| \| \| \| \| \| \| \| \| \|	Merge pull request #18271 from arunagw/change-copyright-year	Robin Dupret	2015-01-01	16	-16/+16
\|\ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Update copyright notices to 2015 [ci skip]
\| * \| \| \| \| \| \| \| \| \| \|	Update copyright notices to 2015 [ci skip]	Arun Agrawal	2014-12-31	16	-16/+16
\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18275 from robin850/head-status	Carlos Antonio da Silva	2014-12-31	4	-5/+23
\|\ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Correctly use the response's status code calling head
\| * \| \| \| \| \| \| \| \| \| \| \|	Correctly use the response's status code calling head	Robin Dupret	2014-12-31	4	-5/+23
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Commit 20fece1 introduced the `_status_code` method to fix calls to `head :ok`. This method has been added on both ActionController::Metal and ActionDispatch::Response. As for the latter, this method is just equivalent to the `response_code` one so commit aefec3c removed it from the `Reponse` object so call to the `_status_code` method on an ActionController::Base instance would be handled by the `Metal` class (which `Base` inherits from) but the status code is not updated according to the response at this level. The fix is to actually rely on `response_code` for ActionController::Base instances but this method doesn't exist for bare Metal controllers so we need to define it.
* \| \| \| \| \| \| \| \| \| \| \| \|	Changelog edits [ci skip]	Robin Dupret	2014-12-31	3	-20/+26
\| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \|	Tiny follow-up to #18260 [ci skip]	Robin Dupret	2014-12-31	2	-11/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Indent the list content by 4 spaces instead of 2 to match the other changelog files. Also wrap the lines around 80 chars. Finally update the documentation example with nit-picky things.
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18277 from prathamesh-sonpatki/typo-aj-changelog	Arun Agrawal	2014-12-31	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fixed typo in ActiveJob CHANGELOG [ci skip]
\| * \| \| \| \| \| \| \| \| \| \| \| \|	Fixed typo in ActiveJob CHANGELOG [ci skip]	Prathamesh Sonpatki	2014-12-31	1	-1/+1
\| \| \|/ / / / / / / / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18272 from kamipo/fix_warning_assigned_but_unused_variable	Sean Griffin	2014-12-31	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix warning: assigned but unused variable - post
\| * \| \| \| \| \| \| \| \| \| \| \| \|	Fix warning: assigned but unused variable - post	Ryuta Kamizono	2014-12-31	1	-1/+1
\| \|/ / / / / / / / / / / /
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18276 from y-yagi/fix_rake_command	Robin Dupret	2014-12-31	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \|_\|/ / / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \|	fix rake command typo in Testing guide [ci skip]
\| * \| \| \| \| \| \| \| \| \| \| \|	fix rake command typo in Testing guide [ci skip]	yuuji.yaginuma	2014-12-31	1	-1/+1
\|/ / / / / / / / / / / /
* \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18274 from rajcybage/spell_fix	Robin Dupret	2014-12-31	2	-4/+4
\|\ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix spell life cycle on activejob docs [ci skip]
\| * \| \| \| \| \| \| \| \| \| \| \|	Fix spell life cycle on activejob docs [ ci skip]	Rajarshi Das	2014-12-31	2	-4/+4
\| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18269 from cuppincake/getting-started-migration-update	Yves Senn	2014-12-31	1	-0/+3
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \|_\|/ / / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \|	Update Getting Started guide to reflect foreign key in migration [ci skip]
\| * \| \| \| \| \| \| \| \| \| \| \|	Update Getting Started guide to reflect foreign key in migration [ci skip]	Jennifer Wollesen	2014-12-30	1	-0/+3
\| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18270 from prathamesh-sonpatki/activejobs-is-not-actionjob	Cristian Bica	2014-12-31	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \|/ / / / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \|	ActiveJob is not ActionJob [ci skip] :smile:
\| * \| \| \| \| \| \| \| \| \| \| \|	ActiveJob is not ActionJob [ci skip] :smile:	Prathamesh Sonpatki	2014-12-31	1	-1/+1
\|/ / / / / / / / / / / /
* \| \| \| \| \| \| \| \| \| \| \|	Add Profiling guide skeleton [ci skip]	Zachary Scott	2014-12-30	2	-0/+22
\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \|	Extract the index length validation to a auxiliar method	Rafael Mendonça França	2014-12-30	3	-9/+12
\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18264 from yahonda/rename_index_mysql	Rafael Mendonça França	2014-12-30	1	-0/+3
\|\ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Raise a better exception for renaming long indexes for mysql adapters
\| * \| \| \| \| \| \| \| \| \| \| \|	Raise a better exception for renaming long indexes for mysql adapters	Yasuo Honda	2014-12-30	1	-0/+3
\| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18266 from cristianbica/ajfixes	Rafael Mendonça França	2014-12-30	6	-12/+21
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ActiveJob testing improvements
\| * \| \| \| \| \| \| \| \| \| \| \| \|	ActiveJob testing improvements	Cristian Bica	2014-12-30	6	-12/+21
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	1. The :test adapter wasn't going through a full cycle of serialize/deserialize when performing jobs. Now it does 2. Regular AJ tests were not run for the :test adapter. Now they are 3. ActiveJob::TestHelper uses assert_valid_keys but doesn’t requires the file that implements that method. Now it does
* \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix error message when trying to create an associated record	Rafael Mendonça França	2014-12-30	4	-1/+23
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This error only happens when the foreign key is missing. Before this fix the following exception was being raised: NoMethodError: undefined method `val' for #<Arel::Nodes::BindParam:0x007fc64d19c218> Now the message is: ActiveRecord::UnknownAttributeError: unknown attribute 'foreign_key' for Model.
* \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18260 from isaacseymour/active-job-delegate-deserialize	David Heinemeier Hansson	2014-12-30	2	-4/+53
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ActiveJob: delegate deserialization to the job class
\| * \| \| \| \| \| \| \| \| \| \| \| \| \|	ActiveJob: delegate full deserialization to class	Isaac Seymour	2014-12-30	2	-4/+53
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \| \| \|	stop referencing `env` in url_for	Aaron Patterson	2014-12-30	2	-1/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	encapsulate env in the request so that we can eventually move away from the env hash
* \| \| \| \| \| \| \| \| \| \| \| \| \| \|	use methods on the request rather than direct hash access	Aaron Patterson	2014-12-30	2	-2/+10
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	this will help decouple us from using the rack env hash
* \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18242 from brainopia/has_one_loading_for_new_record	Sean Griffin	2014-12-30	6	-43/+71
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Load a has_one target for a new record if possible
\| * \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Share foreign_key_present? implementation in _has_ associations	brainopia	2014-12-31	6	-43/+71
\| \| \|_\|/ / / / / / / / / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18219 from jaroslawr/master	Aaron Patterson	2014-12-30	1	-74/+116
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \|/ / / / / / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \|	Flatten the call stacks ActiveSupport::Callbacks produces, fix #18011.
\| * \| \| \| \| \| \| \| \| \| \| \| \| \|	Flatten the call stacks ActiveSupport::Callbacks produces, fix #18011.	Jaroslaw Rzeszotko	2014-12-27	1	-74/+116
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #17680 from larskanis/fix_bytea_change_detection	Sean Griffin	2014-12-30	2	-1/+9
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	PostgreSQL, Fix change detection caused by superfluous bytea unescaping
\| * \| \| \| \| \| \| \| \| \| \| \| \| \| \|	PostgreSQL, Fix change detection caused by wrong data for bytea unescaping.	Lars Kanis	2014-12-29	2	-1/+9
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This showed up when running BinaryTest#test_load_save with the more restrictive input string handling of pg-0.18.0.pre20141117110243.gem . Bytea values sent to the server are in binary format, but are returned back as escaped text. To fulfill the assumption that type_cast_from_database(type_cast_for_database(binary)) == binary we unescape only, if the value was really received from the server.
* \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Move Engines guide under Extending Rails [ci skip]	Zachary Scott	2014-12-30	1	-5/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18262 from benwoody/fix-cycle-doc-missprint	Zachary Scott	2014-12-30	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fixes simple missprint in docs for #cyle in text_helper [ci skip]
\| * \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fixes simple missprint in docs for #cyle in text_helper	Ben Woodall	2014-12-30	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge pull request #18263 from mntj/fix_typo_in_comment	Zachary Scott	2014-12-30	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \|/ / / / / / / / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix comment typo in debugger.rb [ci skip]
\| * \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix comment typo in debugger.rb	mntj	2014-12-30	1	-1/+1
\|/ / / / / / / / / / / / / / / /