Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #34806 from bogdan/reuse-find-target | Ryuta Kamizono | 2018-12-27 | 4 | -30/+20 |
|\ | | | | | | | Reuse AR::Association#find_target method | ||||
| * | Reuse AR::Association#find_target method | Bogdan Gusiev | 2018-12-27 | 4 | -29/+21 |
| | | |||||
* | | Only run isolated tests on the latest stable ruby: that's now 2.6 | Ryuta Kamizono | 2018-12-27 | 1 | -1/+1 |
| | | | | | | | | | | | | Follow up #34795. See also f1a30d8ad5ae17e6202fd3a126027378773dcaea. | ||||
* | | Merge pull request #34801 from bogdanvlviv/follow-up-34786 | George Claghorn | 2018-12-26 | 6 | -52/+5 |
|\ \ | | | | | | | Follow up 34786 | ||||
| * | | Fix Ruby warnings in actionmailbox | bogdanvlviv | 2018-12-27 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` rails/actionmailbox$ bundle exec rake tests (snip) ... rails/activerecord/lib/active_record/persistence.rb:48: warning: in `create!': the last argument was passed as a single Hash rails/actionmailbox/app/models/action_mailbox/inbound_email/message_id.rb:21: warning: although a splat keyword arguments here ... (snip) ``` | ||||
| * | | Improve actionmailbox's .gitignore and remove redundant files | bogdanvlviv | 2018-12-27 | 5 | -51/+4 |
|/ / | | | | | | | Follow up #34786 | ||||
* | | Nest ActionMailbox::Base in the API docs (missed in 6c168aa) | George Claghorn | 2018-12-26 | 1 | -93/+95 |
| | | |||||
* | | Nest Action Mailbox classes in the API docs | George Claghorn | 2018-12-26 | 19 | -508/+546 |
| | | |||||
* | | Generate Action Mailbox's API docs | George Claghorn | 2018-12-26 | 1 | -0/+8 |
| | | |||||
* | | Start an Action Mailbox changelog | George Claghorn | 2018-12-26 | 1 | -0/+3 |
| | | |||||
* | | Test against Ruby 2.6.0 | George Claghorn | 2018-12-26 | 1 | -0/+36 |
| | | |||||
* | | Merge pull request #34786 from georgeclaghorn/actionmailbox | George Claghorn | 2018-12-26 | 162 | -182/+10911 |
|\ \ | | | | | | | Import Action Mailbox | ||||
| * \ | Import Action Mailbox | George Claghorn | 2018-12-25 | 162 | -182/+10911 |
| |\ \ | |||||
| | * | | Bump the minimum Ruby version to match Rails master | George Claghorn | 2018-12-20 | 1 | -1/+1 |
| | | | | |||||
| | * | | Remove Ruby 2.4 from the test matrix | George Claghorn | 2018-12-19 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | Rails 6 will require Ruby 2.5 or newer. See rails/rails#34754. | ||||
| | * | | Use class_methods throughout codebase. | Kasper Timm Hansen | 2018-12-19 | 2 | -4/+4 |
| | | | | |||||
| | * | | [ci skip] Docs: fix spelling, routing setup call and formatting. | Kasper Timm Hansen | 2018-12-19 | 2 | -9/+9 |
| | | | | |||||
| | * | | Merge pull request #12 from dixpac/add_logger_when_auto_generating_message_id | Kasper Timm Hansen | 2018-12-19 | 1 | -4/+4 |
| | |\ \ | | | | | | | | | | | Added logging when Message ID wasn't extracted | ||||
| | | * | | Added logging when Message ID wasn't extracted | Dino Maric | 2018-12-19 | 1 | -4/+4 |
| | |/ / | |||||
| | * | | Resurrect installer. | Kasper Timm Hansen | 2018-12-18 | 4 | -3/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Running `./bin/rails generate mailbox application --no-test-framework` generates: ``` class ApplicationMailbox < ApplicationMailbox def process end end ``` which is not correct for the application mailbox. It shouldn't respond to process but it should contain a routing hint. Generally generators aren't meant to be used like the previous commit. The mailbox generator can certainly add in the ApplicationMailbox if missing, but it shouldn't be called with "application" as an argument. Also adds back auto inserting an `ingress` config line in `config/environmnets/production.rb`. Fixes #13. [Kasper Timm Hansen, Andrew Babichev] | ||||
| | * | | Refit generator file structure to match Action Cable. | Kasper Timm Hansen | 2018-12-18 | 7 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fits with rails/generators/channel containing: - channel_generator.rb - templates/ - USAGE | ||||
| | * | | Remove actions argument from Mailbox generator. | Kasper Timm Hansen | 2018-12-18 | 3 | -15/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Generators only have the public `process` action, so there's nothing else to generate here. Skip the needless indirection. | ||||
| | * | | Test namespacing is supported. | Kasper Timm Hansen | 2018-12-18 | 1 | -0/+22 |
| | | | | |||||
| | * | | Include proper suffix to assert no file correctly. | Kasper Timm Hansen | 2018-12-18 | 1 | -1/+2 |
| | | | | |||||
| | * | | Merge pull request #10 from dixpac/subtile_generator_mention_in_readme | David Heinemeier Hansson | 2018-12-16 | 1 | -0/+5 |
| | |\ \ | | | | | | | | | | | Subtile mention of generator inside README | ||||
| | | * | | Subtile mention of generator inside README | Dino Maric | 2018-12-16 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | | | | | Just a small mention that we can use generators inside README. | ||||
| | * | | | Merge pull request #11 from dixpac/fix_required_ruby_version | George Claghorn | 2018-12-16 | 1 | -1/+1 |
| | |\ \ \ | | | |/ / | | |/| | | Set ruby >= 2.4.1 as min required version | ||||
| | | * | | Set ruby >= 2.4.1 as min required version | Dino Maric | 2018-12-16 | 1 | -1/+1 |
| | |/ / | | | | | | | | | | | | | This matches Rails master, and it should make TravisCI green. | ||||
| | * | | Hook up Travis CI | George Claghorn | 2018-12-16 | 1 | -0/+18 |
| | | | | |||||
| | * | | Merge pull request #9 from dixpac/dix/fix_generators | David Heinemeier Hansson | 2018-12-15 | 8 | -17/+26 |
| | |\ \ | | | | | | | | | | | Fix Rails generators | ||||
| | | * | | Fix Rails generators | Dino Maric | 2018-12-15 | 8 | -17/+26 |
| | |/ / | | | | | | | | | | | | | | | | | 1.Don't generate ApplicationMailboxTest when executing installer 2. Hookup test_unit, so console doesn't throw errors | ||||
| | * | | Merge pull request #8 from dgilperez/adds-generator | David Heinemeier Hansson | 2018-12-14 | 9 | -8/+154 |
| | |\ \ | | | | | | | | | | | Add Mailbox and MailboxTest generators | ||||
| | | * | | renames file names | David Gil | 2018-12-14 | 2 | -1/+1 |
| | | | | | |||||
| | | * | | Uses the new generator to install ApplicationMailbox in ↵ | David Gil | 2018-12-14 | 3 | -13/+3 |
| | | | | | | | | | | | | | | | | | | | | action_mailbox:install rake | ||||
| | | * | | Add Mailbox and MailboxTest generators | David Gil | 2018-12-14 | 7 | -0/+156 |
| | |/ / | |||||
| | * | | Use the correct route method | David Heinemeier Hansson | 2018-12-14 | 1 | -1/+1 |
| | | | | |||||
| | * | | Merge pull request #5 from kylekeesling/rails522-conductor-fix | George Claghorn | 2018-12-14 | 1 | -1/+1 |
| | |\ \ | | | | | | | | | | | Development conductor ingress does not work with Rails 5.2.2 | ||||
| | | * | | remove unimplemented arguement when adding mail message to ActiveStorage | Kyle Keesling | 2018-12-14 | 1 | -1/+1 |
| | |/ / | | | | | | | | | | | | | The indentify parameter is not yet implemented in Rails 5.2.2 | ||||
| | * | | Merge pull request #4 from dixpac/dix/add_frozen_string_literals | George Claghorn | 2018-12-14 | 51 | -0/+102 |
| | |\ \ | | | | | | | | | | | Add frozen_string_literal: true to match Rails codebase | ||||
| | | * | | Add frozen_string_literal: true to match Rails codebase | Dino Maric | 2018-12-14 | 51 | -0/+102 |
| | | | | | |||||
| | * | | | Merge pull request #3 from frodsan/patch-1 | George Claghorn | 2018-12-14 | 1 | -1/+1 |
| | |\ \ \ | | | |/ / | | |/| | | Fix typo [ci skip] | ||||
| | | * | | Fix typo [ci skip] | Francesco Rodríguez | 2018-12-14 | 1 | -1/+1 |
| | |/ / | |||||
| | * | | Merge pull request #2 from panckreous/patch-1 | George Claghorn | 2018-12-13 | 1 | -1/+1 |
| | |\ \ | | | | | | | | | | | fix minor typo | ||||
| | | * | | fix minor typo | Dan | 2018-12-13 | 1 | -1/+1 |
| | |/ / | | | | | | | | | https://www.merriam-webster.com/words-at-play/top-10-commonly-confused-words-vol-2 | ||||
| | * | | Don't need to trip it up right away | David Heinemeier Hansson | 2018-12-13 | 1 | -1/+1 |
| | | | | |||||
| | * | | Add installer | David Heinemeier Hansson | 2018-12-13 | 3 | -9/+17 |
| | | | | |||||
| | * | | Tidy up and example testing | David Heinemeier Hansson | 2018-12-13 | 1 | -3/+27 |
| | | | | |||||
| | * | | Simpler | David Heinemeier Hansson | 2018-12-13 | 1 | -3/+1 |
| | | | | |||||
| | * | | Document the ingress controllers | George Claghorn | 2018-12-13 | 6 | -1/+168 |
| | | | | |||||
| | * | | Document ingress configuration | George Claghorn | 2018-12-13 | 1 | -6/+147 |
| | | | |