aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Initialize @target instead asking if it is defined.Emilio Tagua2011-02-181-1/+2
|
* Should use "=" instead "replace" after this commit: ↵Emilio Tagua2011-02-181-1/+1
| | | | 1644663ba7f678d178deab2bf1629dc05626f85b
* No need to test agaisnt target.Emilio Tagua2011-02-181-1/+1
|
* Reindent and remove wrong line left in merge by mistake.Emilio Tagua2011-02-181-4/+3
|
* Use to_a instead :load in test, since :load changed.Emilio Tagua2011-02-181-1/+1
|
* No need to test against target anymore.Emilio Tagua2011-02-181-8/+8
|
* Merge remote branch 'rails/master' into identity_mapEmilio Tagua2011-02-1847-791/+865
|\ | | | | | | | | | | Conflicts: activerecord/lib/active_record/associations/association.rb activerecord/lib/active_record/fixtures.rb
| * Split AssociationProxy into an Association class (and subclasses) which ↵Jon Leighton2011-02-1826-502/+392
| | | | | | | | manages the association, and a CollectionProxy class which is *only* a proxy. Singular associations no longer have a proxy. See CHANGELOG for more.
| * Add :nodoc: to ThroughAssociation and HasOneAssociationJon Leighton2011-02-182-2/+2
| |
| * Allow building and then later saving has_many :through records, such that ↵Jon Leighton2011-02-187-12/+124
| | | | | | | | the join record is automatically saved too. This requires the :inverse_of option to be set on the source association in the join model. See the CHANGELOG for details. [#4329 state:resolved]
| * Ensure that association_ids uses the correct attribute where the association ↵Jon Leighton2011-02-184-2/+20
| | | | | | | | is a has_many :through with a :primary_key option on the source reflection. [#6376 state:resolved]
| * Remove unused line in test setup.Ben Orenstein2011-02-171-1/+0
| | | | | | | | | | | | [#6442 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * explicitly allowing lolqueriesAaron Patterson2011-02-162-13/+11
| |
| * use the arel table rather than generating stringsAaron Patterson2011-02-161-1/+1
| |
| * no need for Array.wrapAaron Patterson2011-02-161-1/+1
| |
| * fixing whitespace problemsAaron Patterson2011-02-161-3/+3
| |
| * removed an unnecessary second query when passing an ActiveRecord::Relation ↵Steven Fenigstein2011-02-162-2/+32
| | | | | | | | to a where clause. And added ability to use subselects in where clauses.
| * Fixed issue #6363, avoid to pluralized already pluralized names and ↵Timothy N. Tsvetkov2011-02-162-2/+7
| | | | | | | | | | | | | | | | singularize a single in generators, for example stadia is a valid plural for stadium. But calling pluralize for stadia will return stadias which sematically is not corrent in this case [#6363 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * handle double pluralization for irregular pluralsDan Pickett2011-02-163-0/+12
| | | | | | | | | | | | [#6363] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * Remove unused code.Ben Orenstein2011-02-161-3/+0
| | | | | | | | | | | | [#6437 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * fixture methods can be overridden and super() is usefulAaron Patterson2011-02-152-14/+32
| |
| * fixing variable names to reflect realityAaron Patterson2011-02-151-11/+11
| |
| * this is in the AR namespace, so AR must existAaron Patterson2011-02-151-1/+1
| |
| * GcTime incorrectly checks GC.respond_to?(:total_time), it should check ↵Joel Nimety2011-02-151-1/+1
| | | | | | | | | | | | | | | | GC::Profiler.respond_to?(:total_time) [#6435 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * Optimization for postgres adapter for add_column method. Set default and not ↵Timothy N. Tsvetkov2011-02-151-6/+10
| | | | | | | | null in one query
| * fixing variable names, removing FixtureFile instances from test ivarsAaron Patterson2011-02-152-21/+14
| |
| * removing unused variableAaron Patterson2011-02-151-3/+1
| |
| * ActiveResource validation tests did not test ActiveModel validations. Adjust ↵Ken Mazaika2011-02-152-13/+12
| | | | | | | | | | | | the test to be done the Rails3 way. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| * fixed broken link to postgresql docsSergii Boiko2011-02-151-1/+1
| | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | Fix expected queries in relation tests.Emilio Tagua2011-02-151-2/+2
| |
* | Don't shadow outer local variable.Emilio Tagua2011-02-151-2/+2
| |
* | Run tests without IdentityMap when IM=false is given.Emilio Tagua2011-02-156-15/+23
| |
* | Remove identity map from benchmark script.Emilio Tagua2011-02-151-7/+0
| |
* | Merge remote branch 'rails/master' into identity_mapEmilio Tagua2011-02-15430-9198/+12029
|\| | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/examples/performance.rb activerecord/lib/active_record/association_preload.rb activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/association_proxy.rb activerecord/lib/active_record/autosave_association.rb activerecord/lib/active_record/base.rb activerecord/lib/active_record/nested_attributes.rb activerecord/test/cases/relations_test.rb
| * bad tests are badAaron Patterson2011-02-141-18/+0
| |
| * remove accidental raise!Aaron Patterson2011-02-141-1/+0
| |
| * removing irrelevant testAaron Patterson2011-02-142-18/+1
| |
| * Merge branch 'fixtures'Aaron Patterson2011-02-141-28/+28
| |\ | | | | | | | | | | | | | | | | | | | | | * fixtures: remove unused methods extract database activity out of Fixtures instances extract rows that should be inserted to a method fixtures will return a list of tables that may be effected, delete existing fixtures will delete those tables
| | * remove unused methodsAaron Patterson2011-02-142-40/+0
| | |
| | * extract database activity out of Fixtures instancesAaron Patterson2011-02-141-7/+23
| | |
| | * extract rows that should be inserted to a methodAaron Patterson2011-02-141-12/+12
| | |
| | * fixtures will return a list of tables that may be effected, delete existing ↵Aaron Patterson2011-02-142-6/+30
| | | | | | | | | | | | fixtures will delete those tables
| * | Merge remote branch 'jonleighton/association_fixes'Aaron Patterson2011-02-1423-117/+171
| |\ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * jonleighton/association_fixes: Add a transaction wrapper in add_to_target. This means that #build will now also use a transaction. IMO this is reasonable given that the before_add and after_add callbacks might do anything, and this great consistency allows us to abstract out the duplicate code from #build and #create. Inline ensure_owner_is_persisted! as it is only called from one place @target should always be an array Rename add_record_to_target_with_callbacks to add_to_target Don't pass the block through build_record Move create and create! next to build Get rid of create_record as it is not only used in one place Get rid of AssociationCollection#save_record Fix test/cases/connection_pool_test.rb for sqlite3 in-memory db Add interpolation of association conditions back in, in the form of proc { ... } rather than instance_eval-ing strings
| | * Add a transaction wrapper in add_to_target. This means that #build will now ↵Jon Leighton2011-02-141-27/+27
| | | | | | | | | | | | also use a transaction. IMO this is reasonable given that the before_add and after_add callbacks might do anything, and this great consistency allows us to abstract out the duplicate code from #build and #create.
| | * Inline ensure_owner_is_persisted! as it is only called from one placeJon Leighton2011-02-141-8/+4
| | |
| | * @target should always be an arrayJon Leighton2011-02-141-1/+2
| | |
| | * Rename add_record_to_target_with_callbacks to add_to_targetJon Leighton2011-02-142-5/+5
| | |
| | * Don't pass the block through build_recordJon Leighton2011-02-141-10/+8
| | |
| | * Move create and create! next to buildJon Leighton2011-02-141-21/+21
| | |
| | * Get rid of create_record as it is not only used in one placeJon Leighton2011-02-141-8/+7
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 19:10:12 +0000