aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* disconnect options and scope from the `blocks` methodAaron Patterson2014-06-031-7/+8
|
* disconnect the constraints method from the options and scope hashesAaron Patterson2014-06-031-12/+15
|
* :on is removed from options before the Mapping is instantiated, so remove it ↵Aaron Patterson2014-06-031-1/+1
| | | | from IGNORE_OPTIONS
* pull up via extraction and remove it from options / IGNORE_OPTIONSAaron Patterson2014-06-031-8/+6
|
* always make :via a listAaron Patterson2014-06-031-3/+2
|
* always pull out a via variable and simplify logicAaron Patterson2014-06-031-12/+15
|
* test with an empty viaAaron Patterson2014-06-031-0/+8
|
* add a test for missing "via" parameterAaron Patterson2014-06-032-1/+9
|
* remove :as and :anchor from IGNORE_OPTIONSAaron Patterson2014-06-031-3/+5
|
* remove another value from IGNORE_OPTIONSAaron Patterson2014-06-031-2/+2
|
* shorten up IGNORE_OPTIONSAaron Patterson2014-06-031-2/+2
| | | | | | since we are now passing the format value around, we can remove it from the options hash, which means we don't need to consult as many values from IGNORE_OPTIONS
* only look up the format option from the hash onceAaron Patterson2014-06-031-16/+18
|
* Merge pull request #15486 from sgrif/sg-binary-quotingMatthew Draper2014-06-045-47/+83
|\ | | | | Refactor quoting of binary data to not be based on the column type
| * Refactor quoting of binary data to not be based on the column typeSean Griffin2014-06-035-47/+83
| |
* | test pg, remove unused column assignments. Follow up to 254cdf47Yves Senn2014-06-035-12/+0
| |
* | pg, preserve money type when dumping schema and extract money default.Yves Senn2014-06-037-22/+39
| |
* | test pg, rm unused requires.Yves Senn2014-06-0311-27/+0
| |
* | Merge pull request #15487 from sgrif/sg-bit-limitYves Senn2014-06-033-32/+32
|\ \ | | | | | | Respect limit for PG bit strings
| * | Respect limit for PG bit stringsSean Griffin2014-06-033-32/+32
| | |
* | | Merge pull request #15442 from sgrif/sg-refactor-field-changedYves Senn2014-06-036-36/+39
|\ \ \ | |/ / |/| | Refactor determination of whether the field has changed
| * | Refactor determination of whether the field has changedSean Griffin2014-06-036-36/+39
| |/ | | | | | | | | The types know more about what is going on than the dirty module. Let's ask them!
* | pg, preserve type when schema dumping bit and bit varying columns.Yves Senn2014-06-037-12/+44
| |
* | test pg, move bit string type tests into `bit_string_test.rb`.Yves Senn2014-06-033-42/+80
| |
* | test pg, we don't care about the internal state of `column#default`.Yves Senn2014-06-035-9/+0
|/ | | | | That data is internal to Active Record. What we care about is that new records have the right default value.
* pg, preserve point type when schema dumping.Yves Senn2014-06-036-11/+24
|
* pg test, examples for default values and schema dumping of point types.Yves Senn2014-06-032-0/+32
| | | | /cc @sgrif
* Merge pull request #15483 from ↵Yves Senn2014-06-034-11/+11
|\ | | | | | | | | eileencodes/reuse-available-reflection-polymorphic-methods fix polymorphic? method and reuse it
| * fix polymorphic? method and reuse iteileencodes2014-06-024-11/+11
|/ | | | | | Fix polymorphic to check for `options[:polymorphic]` instead of `options.key? :polymorphic` and then reuse the method `polymorphic?` method instead of constantly checking the same `options[:polymorphic]`.
* call `capture` fewer times from `form_for`Aaron Patterson2014-06-022-4/+4
|
* drastically reduce object allocationsAaron Patterson2014-06-022-8/+15
| | | | | | | | | | before this change, we were allocating AS::SafeBuffer objects that were being interpolated in to a string, so the safe buffer object was being thrown away. This change only allocates a string (vs a string *and* a safebuffer) and interpolates the string. On my test application, this reduced the AS::SafeBuffer objects from 1527k per request to about 500 per request.
* reduce AS::SafeBuffer allocationsAaron Patterson2014-06-021-1/+2
| | | | | | | | | | | | html_escape_interpolated_argument is only used in mutation methods: https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L174 https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L179 The return value doesn't need to be converted to an AS::SafeBuffer since we know that the current object is an AS::SafeBuffer and will be mutated, and the return value from html_escape_interpolated_argument will be thrown away
* Merge pull request #15475 from sgrif/sg-initialize-attributesGuillermo Iguaran2014-06-023-11/+3
|\ | | | | Remove unused `initialize_attributes` method
| * Remove unused `initialize_attributes` methodSean Griffin2014-06-023-11/+3
| | | | | | | | | | This was previously a hook for a special case related to `serialize`, which has since been removed.
* | concat is a hotspot (via AV#append=), so just directly define the methodsAaron Patterson2014-06-021-4/+6
| |
* | Merge pull request #15477 from aripollak/actioncontroller-overview-typoArthur Nogueira Neves2014-06-021-2/+2
|\ \ | | | | | | Fix typo in ActionController Overview
| * | Fix typo in ActionController OverviewAri Pollak2014-06-021-2/+2
|/ / | | | | | | * Should say "sensitive" instead of "sensible"
* | Merge pull request #15474 from unixmonkey/masterRafael Mendonça França2014-06-021-1/+1
|\ \ | | | | | | File.exist? instead of File.exists? in bin/setup
| * | File.exist? instead of File.exists? in bin/setupDavid Jones2014-06-021-1/+1
| |/ | | | | | | | | File.exists? is deprecated in Ruby 2.1+ https://github.com/ruby/ruby/blob/v2_1_2/file.c#L1413
* | Merge pull request #15473 from sgrif/sg-missing-colonZachary Scott2014-06-021-1/+1
|\ \ | |/ |/| Add missing colon to internal [ci skip]
| * Add missing colon to internalSean Griffin2014-06-021-1/+1
|/
* just use `assert`Aaron Patterson2014-06-021-1/+1
|
* Merge pull request #15379 from xuanxu/rational_precisionRafael Mendonça França2014-06-024-5/+17
|\ | | | | Fix AS::NumberHelper results with rationals
| * Fix AS::NumberHelper results with rationalsJuanjo Bazán2014-05-314-5/+17
| | | | | | | | | | | | | | | | | | | | :precision was incorrectly being applied to Rationals before: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.3" after: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.33"
* | Merge pull request #15464 from tgxworld/improve_notifications_logicMatthew Draper2014-06-032-8/+18
|\ \ | | | | | | Improvements to ActiveSupport::Notifications.
| * | Avoid looping through subscribers when unsubscribing with a subscriber object.Guo Xiang Tan2014-06-011-5/+10
| | |
| * | Update documentation to reflect unsubscription with name.Guo Xiang Tan2014-06-012-4/+9
| | |
* | | docs, fix typo [ci skip]Yves Senn2014-06-021-2/+2
| | |
* | | test pg, add basic test cases for point datatype.Yves Senn2014-06-021-0/+45
| | |
* | | pg, inline casting methods into `OID::Type` objects.Yves Senn2014-06-024-44/+25
| | | | | | | | | | | | | | | | | | | | | | | | This inlines casting for the most obvious types. The rest will follow eventually. I need to put some tests in place, to make sure that the inlining is not causing regressions. /cc @sgrif
* | | Feature requests should be made on the mailing list, not submitted toZachary Scott2014-06-017-7/+40
| | | | | | | | | | | | the issue tracker. See also #15455 [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 15:40:55 +0000