| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Remove unused table
|
| |
| |
| |
| | |
`postgresql_xml_data_type` table is used from nowhere.
|
|\ \
| |/
|/|
| |
| | |
kamipo/move_back_new_column_definition_into_table_definition
Move back `new_column_definition` into `TableDefinition`
|
|/
|
|
|
|
|
|
|
| |
Only `primary_key` should be extracted by d47357e in #19030, but
`new_coclumn_definition` was also extracted because #17631 is merged
previously, then #19030 is auto merged without conflicts.
This commit is for move back `new_column_definition` into
`TableDefinition`.
|
| |
|
|\
| |
| | |
`ActiveJob::QueueAdapters::TestAdapter` is now a singleton
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since `ActiveJob::TestHelper` globally sets
`ActiveJob::Base.queue_adapter` on setup, there is no benefit in
instantiating a new `TestAdapter` per tests. The original rationale was
to allow parallel tests to run without interference, but since they'd
all mutate the global `ActiveJob::Base.queue_adapter`, that was never
realized.
|
|\ \
| |/
|/| |
Extract the short-hand column methods into `ColumnMethods`
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Cleaning actionpack tests
|
| | | |
|
| | | |
|
| | | |
|
| |/ |
|
|\ \
| | |
| | | |
Allow limit option for MySQL bigint primary key support.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Example:
create_table :foos, id: :primary_key, limit: 8 do |t|
end
# or
create_table :foos, id: false do |t|
t.column :id, limit: 8
end
|
|\ \ \
| |/ /
|/| | |
Fix typo
|
|/ /
| |
| |
| | |
I think this was supposed to be "roundTrip".
|
| | |
|
|\ \
| | |
| | | |
Improve generator name suggestions a bit.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously, the Levenshtein distances to most commands were wrongly
calculated due to a big shortcut. This might be included in the original
code for the performance sake, but I'm not sure that's something we should
take over accuracy in Rails.
Before
'foo' to 'assets' #=> 3
'foo' to 'controller' #=> 3
'foo' to 'generator' #=> 3
'foo' to 'helper' #=> 3
'foo' to 'integration_test' #=> 3
'foo' to 'jbuilder' #=> 3
'foo' to 'job' #=> 2
'foo' to 'mailer' #=> 3
'foo' to 'migration' #=> 3
'foo' to 'model' #=> 3
'foo' to 'resource' #=> 3
'foo' to 'resource_route' #=> 3
'foo' to 'scaffold' #=> 3
'foo' to 'scaffold_controller' #=> 3
'foo' to 'task' #=> 4
'foo' to 'active_record:migration' #=> 3
'foo' to 'active_record:model' #=> 3
'foo' to 'coffee:assets' #=> 3
'foo' to 'css:assets' #=> 3
'foo' to 'css:scaffold' #=> 3
'foo' to 'erb:controller' #=> 3
'foo' to 'erb:mailer' #=> 3
'foo' to 'erb:scaffold' #=> 3
'foo' to 'js:assets' #=> 3
'foo' to 'scss:assets' #=> 3
'foo' to 'scss:scaffold' #=> 3
'foo' to 'test_unit:controller' #=> 3
'foo' to 'test_unit:generator' #=> 3
'foo' to 'test_unit:helper' #=> 3
'foo' to 'test_unit:integration' #=> 3
'foo' to 'test_unit:job' #=> 3
'foo' to 'test_unit:mailer' #=> 3
'foo' to 'test_unit:model' #=> 3
'foo' to 'test_unit:plugin' #=> 3
'foo' to 'test_unit:scaffold' #=> 3
After
'foo' to 'assets' #=> 6
'foo' to 'controller' #=> 8
'foo' to 'generator' #=> 8
'foo' to 'helper' #=> 6
'foo' to 'integration_test' #=> 15
'foo' to 'jbuilder' #=> 8
'foo' to 'job' #=> 2
'foo' to 'mailer' #=> 6
'foo' to 'migration' #=> 8
'foo' to 'model' #=> 4
'foo' to 'resource' #=> 7
'foo' to 'resource_route' #=> 12
'foo' to 'scaffold' #=> 6
'foo' to 'scaffold_controller' #=> 16
'foo' to 'task' #=> 4
'foo' to 'active_record:migration' #=> 21
'foo' to 'active_record:model' #=> 17
'foo' to 'coffee:assets' #=> 12
'foo' to 'css:assets' #=> 10
'foo' to 'css:scaffold' #=> 10
'foo' to 'erb:controller' #=> 12
'foo' to 'erb:mailer' #=> 10
'foo' to 'erb:scaffold' #=> 10
'foo' to 'js:assets' #=> 9
'foo' to 'scss:assets' #=> 11
'foo' to 'scss:scaffold' #=> 11
'foo' to 'test_unit:controller' #=> 18
'foo' to 'test_unit:generator' #=> 18
'foo' to 'test_unit:helper' #=> 16
'foo' to 'test_unit:integration' #=> 20
'foo' to 'test_unit:job' #=> 12
'foo' to 'test_unit:mailer' #=> 16
'foo' to 'test_unit:model' #=> 14
'foo' to 'test_unit:plugin' #=> 16
'foo' to 'test_unit:scaffold' #=> 16
Besides that, the conjunction "or" of the message now appears only between
the last two suggestions.
|
|\ \ \
| | | |
| | | | |
[ci skip] Fix `Object-Relational` to `Object Relational`
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Require `belongs_to` by default.
|
| | |/
| |/|
| | |
| | | |
Deprecate `required` option in favor of `optional` for belongs_to.
|
|\ \ \
| | | |
| | | | |
Changed the AJADAPTER to AJ_ADAPTER
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* This allows for easier reading, since those are two words, so they should be
split by _
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
|
|\ \ \ \
| |_|/ /
|/| | | |
fix method name in mime type example. `Mime::Type.[]` doesn't exist. [ci skip]
|
|/ / / |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Improve wording on find_by note regarding returning only one record [ci skip]
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The Engines guide used an inline namespace, `Blorgh::ApplicationController`, which caused problems for users using an
explicit module namespace because the `ApplicationController` inherited from wasn't fully qualified.
The controller qualification was fixed in 661479324d573d419d8e15a1ea257e01856084af.
This ditches the inline namespace and makes the example more consistent with others in the guide.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fix #has_secure_token documentation
|
|/ / /
| | |
| | |
| | |
| | | |
It's actually #validates_uniqueness_of that can generate a race condition
rather than #validates_presence_of.
|
|\ \ \
| | | |
| | | |
| | | | |
Error message testing fix
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The testing of error messages have been implemented wrongly a few times.
This is an attempt to fix it.
For example, some of these test should have failed with the new code.
The reason they are not failling with the new string is the fact they
were not being tested beforehand.
|
| | | |
|
| | |
| | |
| | |
| | | |
ActiveModel::Errors
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Fixes #16518
|
| | | | |
|
|/ / /
| | |
| | |
| | | |
ActionDispatch::Request#request_id
|
|\ \ \
| | | |
| | | | |
move cache_digests rake methods into their own namespace
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Don't use shorthand match on routes with inappropriate symbols
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Shorthand route match is when controller and action are taken literally from path.
E.g.
get '/foo/bar' # => will use 'foo#bar' as endpoint
get '/foo/bar/baz' # => will use 'foo/bar#baz' as endpoint
Not any path with level two or more of nesting can be used as shortcut.
If path contains any characters outside of /[\w-]/ then it can't be
used as such.
This commit ensures that invalid shortcuts aren't used.
':controller/:action/postfix' - is an example of invalid shortcut
that was previosly matched and led to exception:
"ArgumentError - ':controller/:action' is not a supported controller name"
|