aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Error message should advice to use 'mysql2' gem.Neeraj Singh2010-09-221-2/+2
| | | | | | | | | | | | | If I create a new app using command rails new demo -d mysql then Gemfile contains 'mysql2' gem by default. However if mysql gem is missing then error message says raise "!!! Missing the mysql gem. Add it to your Gemfile: gem 'mysql', '2.8.1'" [#5569 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* avoid a proc objectAaron Patterson2010-09-221-1/+1
|
* avoid creating a range objectAaron Patterson2010-09-221-1/+1
|
* form_for with file_field docs fixedSantiago Pastorino2010-09-221-2/+2
|
* drying up construct_associationAaron Patterson2010-09-211-15/+15
|
* dry up some conditionalsAaron Patterson2010-09-211-3/+4
|
* fixing case / when indentationAaron Patterson2010-09-211-19/+19
|
* fix case / when indentationAaron Patterson2010-09-211-18/+18
|
* avoid a hash lookupAaron Patterson2010-09-211-2/+2
|
* remove more codesAaron Patterson2010-09-211-6/+4
|
* deleting more codeAaron Patterson2010-09-211-4/+1
|
* use each properly to avoid splatting a variableAaron Patterson2010-09-211-2/+1
|
* deleting repeated codesAaron Patterson2010-09-211-13/+10
|
* do not pass nil values to arelAaron Patterson2010-09-211-1/+1
|
* refacoring duplicate code. <3 <3 <3Aaron Patterson2010-09-211-2/+3
|
* this reject can be replaced with compactAaron Patterson2010-09-211-1/+1
|
* removing unused codeAaron Patterson2010-09-211-2/+1
|
* remove some repeated codeAaron Patterson2010-09-211-2/+2
|
* break up giant methodAaron Patterson2010-09-211-62/+72
|
* api guidelines: adds Test::Unit and RSpec as examples of correct spelling, ↵Xavier Noria2010-09-211-1/+3
| | | | also advice when in doubt
* removing lolinjectAaron Patterson2010-09-211-1/+1
|
* fixing tests. wooAaron Patterson2010-09-211-4/+7
|
* remove join table rows before removing owner row for habtm associations, ↵Hemant Kumar2010-09-212-2/+2
| | | | fixes#5674
* providing arel with column information when possible [#5392 state:resolved]Aaron Patterson2010-09-213-3/+29
|
* un-nodocs AR::BatchesXavier Noria2010-09-211-1/+1
|
* Remove helper methods that were moved to helper.rbEmilio Tagua2010-09-211-15/+0
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Move helper methods to helper.rb. Make test not depend on local TZ to pass ↵Emilio Tagua2010-09-212-9/+27
| | | | | | or fail. Signed-off-by: José Valim <jose.valim@gmail.com>
* List all of isolated engine changesPiotr Sarnacki2010-09-201-3/+21
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* use instance_eval, reduce method calls.Stevie Graham2010-09-211-15/+7
| | | | | | | | | | | | | | | | execution time in seconds for `rake test_sqlite3`: ruby 1.9.2p0 (2010-08-18 revision 29036) [x86_64-darwin10.4.0] - before: 52.771426, 52.159505, 52.937056 - after: 51.452584, 51.897017, 51.584431 rubinius 1.0.1 (1.8.7 release 2010-06-03 JI) [x86_64-apple-darwin10.4.0] - before: 284.334076 - after: 285.753028 ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0] - before: 75.811548, 75.533153, 75.353122 - after: 75.244243, 75.19226, 75.256925
* Strengthen documantation on engine's migrations and seed dataPiotr Sarnacki2010-09-201-0/+15
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add helper for loading seed data for engine and applicationPiotr Sarnacki2010-09-204-2/+30
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* file_field propagates up multipart property even inside of fields_forSantiago Pastorino2010-09-202-8/+34
|
* Updating error message on ruby_version_check.rbThiago Pradi2010-09-191-2/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Send 'rails runner' help message to stdout instead of stderr.rohit2010-09-192-3/+2
| | | | | | [#5661 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* application.js should be the last file on javascript_include_tag(:all)Santiago Pastorino2010-09-192-9/+9
|
* Exception handling more readableThiago Pradi2010-09-198-26/+26
| | | | | | [#5601 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Use `Time.current` to maintain consistency with AS::DurationPrem Sichanugrist2010-09-192-2/+40
| | | | | | | | | | In [32b82e4c6f5523cdf5ee78c3022c50b46e018351], the committer has switch methods in AS::Duration to use `Time.current` to return the correct duration based on the `Time.default_zone` instead of using `Time.now`. [#5607 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Fix running engine_test in isolationPiotr Sarnacki2010-09-192-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Remove unnecessary putsPiotr Sarnacki2010-09-191-1/+0
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* adds to the API guidelines the proper spelling of ArelXavier Noria2010-09-193-4/+4
|
* removing some warningsAaron Patterson2010-09-183-8/+8
|
* freeze is not necessaryAaron Patterson2010-09-181-3/+3
|
* argument error is done for usAaron Patterson2010-09-183-3/+8
|
* [CI] Remove RailTies temporary directory on every runPrem Sichanugrist2010-09-181-0/+1
| | | | | | There was an error on CI regarding unable to require `arel` gem from source when testing application build for a while ago. It seems to me like there's a permission problem on the process of cloning the application and removing Gemfile. This would make sure that the temporary application got removed every time the build is run. Signed-off-by: José Valim <jose.valim@gmail.com>
* file_field makes the enclosing form multipartSantiago Pastorino2010-09-183-19/+56
|
* Remove existing migration when using 'rails generate model' with --force ↵David Trasbo2010-09-182-1/+14
| | | | | | [#5526 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix header capitalization by explicitly upcasing first letter of every word, ↵Maxim Chernyak2010-09-182-1/+12
| | | | and avoiding capitalize. [#5636 state:resolved]
* make sure a Content-Length header exists and that the response.body is not ↵Mike Abner2010-09-181-1/+1
| | | | nil before trying to call methods on it. Rack does not allow HTTP 204 responses to have a content-length header set. [#5038 state:resolved]
* test for #5038Neeraj Singh2010-09-181-0/+8
|
* Move capture to Kernel. [#5641 state:resolved]Krekoten' Marjan2010-09-184-32/+26
|