| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fixes bug introduced by #3329
These are the conditions necessary to reproduce the bug:
- For an association, autosave => true.
- An association record is being destroyed
- A new association record is being created.
- There is a unique index one of the association's fields.
- The record being created has the same value as the record being
destroyed on the indexed field.
Before, the deletion of records was postponed until after all
insertions/saves. Therefore the new record with the identical value in
the indexed field caused a non-unique value error to be thrown at the database
level.
With this fix, the deletions happen first, before the insertions/saves.
Therefore the record with the duplicate value is gone from the database
before the new record is created, thereby avoiding the non-uniuqe value
error.
|
| |
|
| |
|
|\
| |
| | |
Extract tests code out from AR's base_test.rb to integration_test.rb
|
| |
| |
| |
| |
| |
| | |
`AR::Base#to_param` and `AR::Base#cache_key` is defined at
active_record/integration.rb, so tests for those methods should be at
integration_test.rb
|
|\ \
| | |
| | |
| | |
| | | |
patricksrobertson/convert_activemodel_to_new_hash_syntax
Convert ActiveModel to 1.9 hash syntax.
|
|/ /
| |
| |
| |
| | |
I also attempted to fix other styleguide violations such as
{ a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ).
|
|\ \
| | |
| | |
| | |
| | | |
chancancode/handle_aliased_attributes_in_ar_relation
Handle aliased attributes in AR::Relation
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When using symbol keys, ActiveRecord will now translate aliased attribute names to the actual column name used in the database:
With the model
class Topic
alias_attribute :heading, :title
end
The call
Topic.where(heading: 'The First Topic')
should yield the same result as
Topic.where(title: 'The First Topic')
This also applies to ActiveRecord::Relation::Calculations calls such as `Model.sum(:aliased)` and `Model.pluck(:aliased)`.
This will not work with SQL fragment strings like `Model.sum('DISTINCT aliased')`.
Github #7839
*Godfrey Chan*
|
| | |
| | |
| | |
| | | |
Introduced in 09ac1776abc0d3482f491f2d49f47bcb3d9a4ad7.
|
|\ \ \
| |/ /
|/| | |
Use constant for encoding
|
| | | |
|
|\ \ \
| | | |
| | | | |
Allow override of PostgreSQL UUID primary key default
|
| |/ /
| | |
| | |
| | | |
without this, it's not possible to use UUID primary keys without uuid-ossp installed and activated
|
|\ \ \
| |/ /
|/| | |
Make railties version match RAILS_VERSION
|
|/ / |
|
|\ \
| | |
| | | |
Remove varargs from `Object#in?`
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit ebf69ab1636df74c76332c53bcd3d8494fb91b45.
`in?` must not take multiple parameters because its behavior would be
ambiguous:
# Test if "B" is included in a list of names with `"B".in?(*names)`:
names = ["BMorearty"]
"B".in?(*names) # => true
names = ["BMorearty","rubyduo"]
"B".in?(*names) # => false
Conflicts:
activesupport/lib/active_support/core_ext/object/inclusion.rb
activesupport/test/core_ext/object/inclusion_test.rb
|
| |/
|/| |
|
| |
| |
| |
| |
| |
| | |
Same rationale as previous revert.
This reverts commit 887225e69b6cdd27f00cf043c4ac918ca5e18cbf.
|
|/
|
|
|
|
|
| |
It is not in the contract that flags have to be singletons,
the use of regular font indicates that.
This reverts commit 80036f9a5341bd831d125dc684841a8433d92070.
|
|\ |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
* it's Action Mailer not ActionMailer
* it's Action Pack not ActionPack
* it's Active Support not ActiveSupport
/cc @fxn
|
| |
| |
| |
| | |
/cc @fxn
|
| | |
|
| |
| |
| |
| | |
guide already in this folder.
|
| | |
|
| | |
|
| |\ |
|
| | | |
|
| |/ |
|
| | |
|
| |
| |
| | |
rake assets:precompile will work if config.assets.precompile is in config/application.rb and not in config/environment/production.rb
|
| |
| |
| |
| |
| |
| | |
Notation with `self` was sugestted at 0b05acd, when self.defaults was
extlib_inheritable_accessor. But now all Action Mailer examples are
without this self. It's nicer.
|
| |
| |
| |
| |
| |
| | |
enumerations.
Injected at a1639ad.
|
| | |
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
At 4a6eba32 mail sending example was rewrited from rails 2 format to
modern rails 3 approach. But passing parameter `recipient` to method
Notifier#welcome was lost.
Passing email as parameter makes this example more solid.
|
| |/
| |
| |
| | |
description in validations
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
According to the rationale at https://github.com/rails/rails/pull/7833#issuecomment-9141908, we should recommend new users to follow DHH's approach outlined at http://37signals.com/svn/posts/3113-how-key-based-cache-expiration-works.
This is the first step, and perhaps in the future we can write some specific recommendations out.
|
| | |
|
| | |
|