aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add multiple expected calls to assert_called_with.Kasper Timm Hansen2015-07-102-1/+13
|
* we don't really need an extra method to set the script nameAaron Patterson2015-07-101-5/+1
|
* Remove useless conditionalAaron Patterson2015-07-101-12/+0
| | | | PATH_INFO is already set, so this branch will never execute.
* default `PATH_INFO` to the generated pathAaron Patterson2015-07-101-1/+2
| | | | | | we were already generating a path in the previous code (it was just not returned), so lets just use the already computed path to popluate the PATH_INFO header
* always default the SCRIPT_NAME to whatever is on the controllerAaron Patterson2015-07-101-1/+1
|
* remove useless ivar clearingAaron Patterson2015-07-101-6/+0
| | | | Since we only work with new instances, these ivars will not be set.
* call the `path_parameters=` setter rather than rely on mutationsAaron Patterson2015-07-101-1/+3
| | | | | We should call the setter on `path_parameters` so that we know the hash will only contain the values that we've set.
* start collecting `env` mutationsAaron Patterson2015-07-101-5/+3
| | | | | I'd like to put all env mutations together so we can understand how to change this code to call `call` on the controller
* Parameters are converted to a query stringAaron Patterson2015-07-101-17/+0
| | | | | Since parameters are converted to a query string, they will automatically be turned in to strings by the query parser
* no more HWIAAaron Patterson2015-07-101-1/+1
| | | | | non_path_parameters is used internally (it never escapes this method) so we should be able to safely use a regular hash.
* remove param dup'ing logicAaron Patterson2015-07-101-8/+0
| | | | | since we are serializing parameters, we don't need to do all the dup checks on each object.
* encode / decode parameters before assigning them to the requestAaron Patterson2015-07-101-5/+58
| | | | | | We should roundtrip the parameters through their respective encoders / decoders so that the controller will get parameters similar to what they actually get in a real world situation
* Merge pull request #20836 from sikachu/fix-time-zone-testRafael Mendonça França2015-07-101-0/+1
|\ | | | | Require yaml for time_with_zone isolation test
| * Require yaml for time_with_zone isolation testPrem Sichanugrist2015-07-101-0/+1
|/ | | | | Same fix as 109e71d2bb6d2305a091fe7ea96d4f6e9c7cd52d but after mocha got removed in 2f28e5b6417fd4e5d6060983b36262737558b613.
* start disconnecting the parameter parser from the instanceAaron Patterson2015-07-101-3/+3
| | | | | pass in the instance variable to start decoupling the meat of the parser from the instance of the middleware
* drop a conditional by always assigningAaron Patterson2015-07-101-6/+5
| | | | | We will always make an assignment to the env hash and eliminate a conditional
* Reuse the same test for HWIA reverse_merge!Rafael Mendonça França2015-07-101-3/+1
|
* Merge pull request #20828 from Sirupsen/hash-indifferent-dup-default-procRafael Mendonça França2015-07-104-13/+58
|\ | | | | active_support/indifferent_access: fix not raising when default_proc does
| * test/hash: move lonely indifferent hash testSimon Eskildsen2015-07-102-11/+6
| |
| * active_support/indifferent_hash: dont raise on to_hash when default_proc raisesSimon Eskildsen2015-07-103-1/+22
| |
| * active_support/indifferent_hash: fix cloning default_proc on dupSimon Eskildsen2015-07-103-1/+30
| |
* | drop runtime conditionals in parameter parsingAaron Patterson2015-07-091-13/+9
| | | | | | | | | | If we only deal with proc objects, then we can eliminate type checking in the parameter parsing middleware
* | Merge pull request #20457 from ronakjangir47/remove_mocha_activesupportKasper Timm Hansen2015-07-098-65/+87
|\ \ | | | | | | Removed use of mocha in Active Support
| * | Removed use of mocha in active_supportRonak Jangir2015-07-108-65/+87
| | |
* | | Merge pull request #20813 from noniq/locale-argument-for-pluralize-helperKasper Timm Hansen2015-07-092-2/+22
|\ \ \ | | | | | | | | Allow `pluralize` helper to take a locale.
| * | | Allow `pluralize` helper to take a locale.Stefan Daschek2015-07-092-2/+22
| | | | | | | | | | | | | | | | This is already supported in `ActiveSupport::Inflector#pluralize` and `String#pluralize`, so we just forward the locale.
* | | | use `Rack::Test::UploadedFile` when uploading filesAaron Patterson2015-07-091-2/+2
| | | | | | | | | | | | | | | | | | | | We should use rack-test's upload file objects on the test side so that we will be able to correctly generate mime blob posts in the future
* | | | set parameters as a query stringAaron Patterson2015-07-092-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | We should convert request parameters to a query string, then let the request object parse that query string. This should give us results that are more similar to the real-world
* | | | use JSON to communicate between the controller and the testsAaron Patterson2015-07-091-12/+12
| | | |
* | | | Merge pull request #20765 from maurogeorge/activejob-exceptionRobin Dupret2015-07-091-0/+7
|\ \ \ \ | |_|/ / |/| | | Add Deserialization section on guides at ActiveJob Exception [ci skip]
| * | | Add Deserialization section on guides at ActiveJob ExceptionMauro George2015-07-081-0/+7
| | | | | | | | | | | | | | | | [ci skip]
* | | | build and assign parameters rather than rely on mutationsAaron Patterson2015-07-082-4/+18
| | | | | | | | | | | | | | | | | | | | We should assign parameters to the request object rather than mutate the hash that is returned by `query_parameters` or `request_parameters`
* | | | use new constructor. (Oops! :bomb:)Aaron Patterson2015-07-082-2/+2
| | | |
* | | | assign the cookie hash on request allocationAaron Patterson2015-07-082-2/+2
| | | | | | | | | | | | | | | | this prevents mutations from being available globally
* | | | request objects are no longer recycledAaron Patterson2015-07-082-16/+8
| | | | | | | | | | | | | | | | | | | | | | | | Instead of trying to manually clear out a request object, lets just allocate a new one. The rack ENV is reused and cleaned (still), but the request object is not.
* | | | pass the variant as a parameter to more reflect real world appsAaron Patterson2015-07-081-3/+3
| | | |
* | | | add a new constructor for allocating test requestsAaron Patterson2015-07-084-29/+31
| | | |
* | | | make `env` a required parameterAaron Patterson2015-07-082-7/+7
| | | |
* | | | pass the starting env and session to build_requestAaron Patterson2015-07-082-4/+4
| | | |
* | | | remove call to build_requestAaron Patterson2015-07-081-1/+0
| | | |
* | | | pass the session and env in to the test requestAaron Patterson2015-07-081-4/+8
| | | |
* | | | let the superclass build the request and responseAaron Patterson2015-07-0811-48/+14
| | | | | | | | | | | | | | | | | | | | We should leverage the request / response objects that the superclass has already allocated for us.
* | | | Merge pull request #20781 from dubek/collection-cache-explicitKasper Timm Hansen2015-07-085-9/+47
|\ \ \ \ | | | | | | | | | | Support explicit defintion of resource name for collection caching.
| * | | | Support explicit defintion of resouce name for collection caching.Dov Murik2015-07-075-9/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a template includes `# Template Collection: ...` anywhere in its source, that name will be used as the cache name for the partial that is rendered for the collection. This allows users to enable collection caching even if the template doesn't start with `<% cache ... do %>`. Moreover, the `# Template Collection: ...` notation is recognized in all template types (and template types other than ERB can define a resource_cache_call_pattern method to allow the `cache ... do` pattern to be recognized too).
* | | | | Merge pull request #20784 from kaspth/great-expectationsKasper Timm Hansen2015-07-082-0/+121
|\ \ \ \ \ | | | | | | | | | | | | Add method call assertions for internal use.
| * | | | | Add method call assertions for internal use.Kasper Timm Hansen2015-07-082-0/+121
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `assert_called` and `assert_not_called` to boil down the boilerplate we need to write to assert methods are called certain number of times.
* | | | | | remove useless `new` implementationAaron Patterson2015-07-081-4/+0
| | | | | |
* | | | | | allocate new responses rather than recycling themAaron Patterson2015-07-081-12/+5
| |_|_|/ / |/| | | | | | | | | | | | | | | | | | | There is no reason to "recycle" response objects when we can just allocate a new one.
* | | | | Merge pull request #20805 from yui-knk/fix/how_to_run_testYves Senn2015-07-081-1/+1
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Add `bundle exec` to Running a Single Test
| * | | | | [ci skip] Add `bundle exec` to Running a Single Testyui-knk2015-07-081-1/+1
|/ / / / /
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-23 01:12:36 +0000