| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
|
|\ \ \
| | | |
| | | | |
Fix occurrences Fixnum|Bignum
|
| | | |
| | | |
| | | |
| | | | |
Related to https://github.com/rails/rails/commit/d4eb0dc89ee6b476e2e10869dc282a96f956c6c7#r27830891
|
|\ \ \ \
| |_|/ /
|/| | | |
Fix actionview tests execution
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
On my local environment execution of `cd actionview/ && bin/test` raises error:
```
(snip)
rails/actionview/test/template/render_test.rb:6:in `<top (required)>': superclass mismatch for class TestController (TypeError)
```
In some test files `TestController` inherited from `ActionController::Base`,
but in `test/actionpack/controller/render_test.rb` file `TestController`
inherited from `ApplicationController`.
This produces error `superclass mismatch for class TestController (TypeError)`
Step to reproduce this on any environment:
`cd actionview/ && bin/test test/template/streaming_render_test.rb test/actionpack/controller/render_test.rb`
|
|\ \ \
| |_|/
|/| | |
Fix links in the psql guide [ci skip]
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
kaspth/ast-unify-preview-variant-routes-and-controllers
Merge Previews/Variants controller into one Representations controller.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
Since ActiveStorage::Blob::Representable unifies the idea of previews and
variants under one roof as representation, we may as well have the
controllers follow suit.
Thus ActiveStorage::RepresenationsController enters the fray. I've copied
the old tests for both previews and variants and unified those as well.
|
|/
|
|
|
| |
This removes `|| id` which were added in #9963 and #23887 since it is no
longer necessary.
|
|
|
|
|
|
|
|
|
|
| |
This reverts ignoring polymorphic error introduced at 02da8ae.
What the ignoring want to solve was caused by force eager loading
regardless of whether it is necessary, but it has been fixed by #29043.
The ignoring is now only causing a mismatch of `exists?` behavior with
`to_a`, `count`, etc. It should behave consistently.
|
|
|
|
|
|
|
| |
This is an alternative of #29722, and follow up of #32048.
This does not change the current behavior, but makes it easier to modify
all polymorphic names consistently.
|
|
|
|
| |
The `+` does not work if the string contains spaces.
|
|
|
|
|
|
| |
Numeric#positive? and Numeric#negative? was added to Ruby since 2.3,
see https://github.com/ruby/ruby/blob/ruby_2_3/NEWS
Rails 6 requires Ruby 2.4.1+ since https://github.com/rails/rails/pull/32034
|
|
|
|
|
| |
Ruby 2.4+ provides `Hash#compact` and `Hash#compact!` natively,
so `active_support/core_ext/hash/compact` is no longer necessary.
|
|
|
|
| |
Since Rails 6 requires Ruby 2.4.1+.
|
|
|
|
|
| |
https://bugs.ruby-lang.org/issues/12752
https://ruby-doc.org/core-2.4.0/String.html#method-i-unpack1
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This comment was added at 070dda2. That arguments has already been
changed since those are internal nodoc classes, but the comment does not
reflect the current state.
I decided to remove the staled comment since it is not useful for
understanding what the class does.
[ci skip]
|
|
|
|
|
|
| |
Follow up of b988ecb99ff6c8854e4b74ef8a7ade8d9ef5d954.
This was added for internal usage, it doesn't need to be public.
|
|
|
|
| |
Duplicated method name list is no longer needed.
|
|
|
|
| |
It is used as a namespace for `Sheet` and `Expanded`.
|
|
|
|
|
|
| |
* Remove unused require
* Remove redundant `test`
* Change `rake` to `rails`
|
|\
| |
| | |
Add "rails routes --expanded" mode
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When using rails routes with small terminal or complicated routes it can be
very difficult to understand where is the element listed in header. psql
had the same issue, that's why they created "expanded mode" you can
switch using `\x` or by starting psql with
```
-x
--expanded
Turn on the expanded table formatting mode. This is equivalent to the \x command.
```
The output is similar to one implemented here for rails routes:
db_user-# \du
List of roles
-[ RECORD 1 ]----------------------------------------------
Role name | super
Attributes | Superuser, Create role, Create DB
Member of | {}
-[ RECORD 2 ]----------------------------------------------
Role name | role
Attributes | Superuser, Create role, Create DB, Replication
Member of | {}
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
There is no reason `attributes=` doesn't take `assign_attributes`.
|
| |
| |
| |
| | |
This was added in 9bfa13b, but it is never used from the beginning.
|
|\ \
| | |
| | | |
Add separate test to ensure that `delegate` with `:private` option returns correct value
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
correct value
Remove extra comments `# Asking for private method` in activesupport/test/core_ext/module_test.rb
Improve docs of using `delegate` with `:private`
Update changelog of #31944
|
|\ \
| | |
| | | |
Fix a typo in activerecord/CHANGELOG.md
|
|/ /
| |
| |
| | |
columsn ->
columns
|
|\ \
| | |
| | | |
Add ActiveModel::Attributes#attributes
|
| | |
| | |
| | |
| | |
| | |
| | | |
This starts to fix #31832.
ActiveModel::Attributes includes ActiveModel::AttributeMethods,
which requires an `#attributes` method that returns a hash with string keys.
|
|\ \ \
| | | |
| | | | |
Let select render default selected option for required field
|
| | |/
| |/| |
|
|\ \ \
| | | |
| | | | |
Fix `new_framework_defaults_6_0.rb`
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`default_enforce_utf8` belongs to `config.action_view`
Update info about `:skip_enforcing_utf8` since we can change default
behavior via `config.action_controller.default_enforce_utf8`
Related to #32125
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Expand AR::Base.abstract_class documentation
[ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The previous documentation is somewhat unclear about the use case for an
abstract ActiveRecord class.
This clears it up by highlighting the following points:
- table_name is not derived from the abstract class' name
- type is not derived on direct descendants of the abstract class
- validations, not abstract_class, should be used to specify whether
the parent model can be instantiated or not
|
|\ \ \ \
| |_|/ /
|/| | | |
Use `with_partial_writes` helper in `activerecord/test/cases/dirty_test.rb`
|
|/ / /
| | |
| | |
| | | |
Related to 948b931925febac3c965ab13470065ced68f7b53
|
|\ \ \
| | | |
| | | | |
Uses the absolute path for system test screenshots
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Why:
* When getting an error that generates a screenshot it would be helpful
to be able to ctrl+click it to quickly open it in the browser, which
does not work with relative paths
This change addresses the need by:
* Changing `image_path` to disregard the relative path and use the
absolute one instead
|
|\ \ \ \
| | | | |
| | | | | |
Move rake routes task to rails command
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
After a discussion with matthewd. It was mentioned that rake tasks need
to be moved to rails command.
See: https://github.com/rails/rails/issues/32117
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Don't enforce UTF-8 by default
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
With the disabling of TLS 1.0 by most major websites, continuing to run
IE8 or lower becomes increasingly difficult so default to not enforcing
UTF-8 encoding as it's not relevant to other browsers.
|