aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Match domain languageDavid Heinemeier Hansson2017-07-012-2/+2
| |/
| * Sort out circular dependency for nowDavid Heinemeier Hansson2017-07-013-3/+3
| |
| * Test blobs with real db backendDavid Heinemeier Hansson2017-07-016-7/+32
| |
| * Test checksummingDavid Heinemeier Hansson2017-07-011-0/+4
| |
| * Update README.mdDavid Heinemeier Hansson2017-07-011-0/+2
| |
| * Autoload siteDavid Heinemeier Hansson2017-07-011-0/+1
| |
| * Implied well enoughDavid Heinemeier Hansson2017-07-011-2/+2
| |
| * Underscore its an interfaceDavid Heinemeier Hansson2017-07-011-0/+9
| |
| * Ignore byebug historyDavid Heinemeier Hansson2017-07-011-0/+1
| |
| * Test DiskSiteDavid Heinemeier Hansson2017-07-011-0/+39
| |
| * Quote this!David Heinemeier Hansson2017-07-013-6/+8
| |
| * StyleDavid Heinemeier Hansson2017-07-011-6/+10
| |
| * Actual dependenciesDavid Heinemeier Hansson2017-07-011-10/+18
| |
| * Switch to double quotes for Rails linterDavid Heinemeier Hansson2017-07-011-12/+12
| |
| * Require what we needDavid Heinemeier Hansson2017-07-012-0/+7
| |
| * Right pathsDavid Heinemeier Hansson2017-07-011-2/+2
| |
| * Don't give return guarenteesDavid Heinemeier Hansson2017-07-011-1/+0
| |
| * No need to normalize since we generate our own keysDavid Heinemeier Hansson2017-07-012-7/+1
| |
| * Space to breatheDavid Heinemeier Hansson2017-07-011-0/+2
| |
| * Its a key nowDavid Heinemeier Hansson2017-07-011-1/+1
| |
| * Go with site instead of storeDavid Heinemeier Hansson2017-07-013-3/+68
| | | | | | | | Better fit for upload/download terminology.
| * No need for rails prefixDavid Heinemeier Hansson2017-07-012-2/+2
| | | | | | | | active_file is specific enough.
| * Use key instead of tokenDavid Heinemeier Hansson2017-07-011-2/+2
| | | | | | | | More familiar in this context
| * First sketchingDavid Heinemeier Hansson2017-06-3015-0/+289
|
* Merge pull request #30016 from ↵Guillermo Iguaran2017-07-315-0/+25
|\ | | | | | | | | albertoalmagro/set-ruby-version-in-gemfile-and-ruby-version-by-default Set Ruby version in Gemfile and .ruby-version by default
| * Set Ruby version in Gemfile and .ruby-version by defaultAlberto Almagro2017-07-315-0/+25
|/
* Merge pull request #29950 from MaxLap/avoid_or_clause_duplicatesSean Griffin2017-07-313-6/+66
|\ | | | | Avoid duplicate clauses when using #or
| * Edits following the reviewsMaxime Lapointe2017-07-282-27/+43
| |
| * Avoid duplicate clauses when using #orMaxime Lapointe2017-07-253-9/+53
| | | | | | | | | | Condenses the clauses that are common to both sides of the OR and put them outside, before the OR This fix the current behavior where the number of conditions is exponential based on the number of times #or is used.
* | Merge pull request #30001 from y-yagi/fix_test_directoryKasper Timm Hansen2017-07-303-3/+3
|\ \ | | | | | | Fix test directory to correct path
| * | Fix test directory to correct pathyuuji.yaginuma2017-07-303-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Together, fix to the following lint violation. ``` rails/actionview/test/ujs/public/test/data-confirm.js 303:11 error Strings must use singlequote quotes rails/actionview/test/ujs/public/test/data-remote.js 414:32 error Extra semicolon semi ✖ 2 problems (2 errors, 0 warnings) ```
* | | Merge pull request #29951 from georgeclaghorn/action-view-test-flowKasper Timm Hansen2017-07-302-0/+10
|\ \ \ | | | | | | | | Fix testing helpers that use Action View's capturing helpers (e.g. content_for)
| * | | Fix testing helpers that use Action View's capturing helpers (e.g. content_for)George Claghorn2017-07-252-0/+10
| | |/ | |/|
* | | Fix github user output.Kasper Timm Hansen2017-07-301-1/+1
| | | | | | | | | | | | [ Orhan Toy & Kasper Timm Hansen ]
* | | Merge pull request #29963 from y-yagi/fix_ruby_warningsKasper Timm Hansen2017-07-301-3/+3
|\ \ \ | | | | | | | | Fix `warning: method redefined;`
| * | | Fix `warning: method redefined;`yuuji.yaginuma2017-07-281-3/+3
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following warning: ``` /tmp/d20170727-7039-kmdtb1/app/app/models/user.rb:5: warning: method redefined; discarding old model_name rails/activemodel/lib/active_model/naming.rb:222: warning: previous definition of model_name was here ```
* | | Merge pull request #30002 from y-yagi/change_http_postgresql_links_to_httpsVipul A M2017-07-308-32/+32
|\ \ \ | |_|/ |/| | Change http postgresql.org links to https [ci skip]
| * | Change http postgresql.org links to https [ci skip]yuuji.yaginuma2017-07-308-32/+32
|/ / | | | | | | | | It seems that it accepts only HTTPS connections. Ref: https://github.com/postgres/postgres/commit/7f77cbd996855a06fb742ea11adbe55c42b48fe2
* | Merge pull request #29933 from kirs/frozen-actionpackMatthew Draper2017-07-29281-3/+563
|\ \ | | | | | | Use frozen string literal in actionpack/
| * | Use frozen string literal in actionpack/Kir Shatrov2017-07-29281-3/+563
|/ /
* | Merge pull request #29946 from kamipo/passing_arel_to_where_is_boundableSean Griffin2017-07-281-4/+1
|\ \ | | | | | | Building `where_clause` in `UniquenessValidator` is no longer needed
| * | Building `where_clause` in `UniquenessValidator` is no longer neededRyuta Kamizono2017-07-261-4/+1
| | | | | | | | | | | | | | | | | | Building `where_clause` manually was introduced at #26073 to include both `comparison` and `binds` in `where_clause`. Since 213796f, `comparison` includes `binds`, so it is enough to use `where` simply.
* | | Merge pull request #29979 from kamipo/use_build_bind_attributeSean Griffin2017-07-284-8/+7
|\ \ \ | | | | | | | | Use `predicate_builder.build_bind_attribute` wherever possible
| * | | Use `predicate_builder.build_bind_attribute` wherever possibleRyuta Kamizono2017-07-284-8/+7
| | | | | | | | | | | | | | | | For less duplicated code.
* | | | Add missing support for modulo operations on durationsSayan Chakraborty2017-07-283-14/+131
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails 5.1 introduce an `ActiveSupport::Duration::Scalar` class as a wrapper around a numeric value as a way of ensuring a duration was the outcome of an expression. However the implementation was missing support for modulo operations. This commit adds support for those operations and should result in a duration being returned from expressions involving them. Fixes #29603 and #29743.
* | | | Merge pull request #29982 from ydakuka/patch-1Robin Dupret2017-07-281-3/+3
|\ \ \ \ | | | | | | | | | | [ci skip] update routing guide
| * | | | Squashed commit of the following:ydakuka2017-07-281-3/+3
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | commit 4a3d295f3011e771cddead80de7497ca15d15c13 Author: Yauheni Dakuka <yauheni.dakuka@gmail.com> Date: Fri Jul 28 14:31:35 2017 +0300 Update routing.md commit 620a4ce47288e3ef6504290c78f931214968e7e3 Author: Yauheni Dakuka <yauheni.dakuka@gmail.com> Date: Fri Jul 28 14:19:29 2017 +0300 [ci skip] update routing guide
* | | | Merge pull request #29980 from ydakuka/patch-1Robin Dupret2017-07-281-1/+1
|\ \ \ \ | |/ / / |/| | | [ci skip] update routing guide
| * | | [ci skip] update routing guideYauheni Dakuka2017-07-281-1/+1
|/ / /
* | | Eager load the association classes on bootRafael Mendonça França2017-07-271-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were expecting those classes to be loaded when an association is defined but they are not. If you add a debugger on the first line of any of those classes and try to define the corresponding association you will see that the classes are not loaded. Fixes #26273