aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Make sure create! raises errors on validation when creating multiple ↵Michael Koziarski2007-08-282-1/+7
| | | | | | records. [hasmanyjosh] Closes #8952 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7361 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Back out of [7300] -- it screwed up nested XMLDavid Heinemeier Hansson2007-08-211-3/+0
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7357 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix spacingDavid Heinemeier Hansson2007-08-212-2/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7356 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that eager loading queries and with_scope should respect the :group ↵David Heinemeier Hansson2007-08-213-8/+17
| | | | | | option [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that eager loading queries should respect the :group option as well [DHH]David Heinemeier Hansson2007-08-212-1/+6
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* correct the ActionCacheTest from [7346]Rick Olson2007-08-201-0/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix bug where action caching sets the content type to the ActionCachePath ↵Rick Olson2007-08-203-1/+8
| | | | | | object. Closes #9282 [mindforge] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add missing sentenceMichael Koziarski2007-08-171-3/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7332 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Improve url_for documentation for ActionController::Base and UrlRewriter. ↵Michael Koziarski2007-08-172-15/+32
| | | | | | Closes #9022. Closes #9077. [juanjo.bazan] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7331 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Improve performance and functionality of the postgresql adapter. Closes ↵Michael Koziarski2007-08-168-225/+673
| | | | | | #8049 [roderickvd] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7329 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Don't clobber :includes passed to count on has_many association. Closes ↵Michael Koziarski2007-08-163-1/+9
| | | | | | #9175 [danger] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7326 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make sure has_many associations honour :include when counting. Closes #9167 ↵Michael Koziarski2007-08-164-1/+11
| | | | | | [danger] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* add missing layouts from [7321]Rick Olson2007-08-151-0/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Find layouts even if they're not in the first view_paths directory. Closes ↵Rick Olson2007-08-153-6/+19
| | | | | | #9258 [caio] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix failing active record store testsMichael Koziarski2007-08-141-1/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add forgotten changelog entryMichael Koziarski2007-08-141-0/+7
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Change the implementation of ActiveRecord's attribute reader and writer methods:Michael Koziarski2007-08-146-243/+249
| | | | | | | | | | | * Generate Reader and Writer methods which cache attribute values in hashes. This is to avoid repeatedly parsing the same date or integer columns. * Move the attribute related methods out to attribute_methods.rb to de-clutter base.rb * Change exception raised when users use find with :select then try to access a skipped column. Plugins could override missing_attribute() to lazily load the columns. * Move method definition to the class, instead of the instance * Always generate the readers, writers and predicate methods. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Send freshness information when sending Etags. Without this internet ↵Michael Koziarski2007-08-122-1/+2
| | | | | | explorer will not send conditional gets for a resource, but instead hold on to the responses for the current browser session. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Ignore processing instructions when parsing htmlMichael Koziarski2007-08-101-0/+3
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7300 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Raise ActiveResource::Redirection on 301,302 http codeTobias Lütke2007-08-092-4/+11
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7297 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make habtm respect the :select option. Closes #9207. [Aleksey Kondratenko]Michael Koziarski2007-08-073-1/+15
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Let inspect on AR classes work when the table doesn't exist. Closes #9194 ↵Michael Koziarski2007-08-062-1/+7
| | | | | | [tarmo, nzkoz] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Major improvement to the documentation for the options / select form ↵Michael Koziarski2007-08-052-31/+75
| | | | | | helpers. Closes #9038 [kampers, jardeon, wesg] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7276 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix number_to_human_size when using different precisions. Closes #7536. ↵Michael Koziarski2007-08-053-2/+8
| | | | | | [RichardStrand, mpalmer] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Performance enhancement for Base.exists?. CLoses #8769. [hasmanyjosh]Michael Koziarski2007-08-051-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make the utf-handler return the correct value for non-matching regular ↵Michael Koziarski2007-08-053-2/+6
| | | | | | expressions. Closes #9049 [manfred] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7273 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add ljust, rjust and center to utf8-handler. Closes #9165 [manfred]Michael Koziarski2007-08-053-0/+119
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7272 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix Time#advance bug when trying to advance a year from leap day. Closes ↵Rick Olson2007-08-038-11/+23
| | | | | | #8655 [gbuesing] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7262 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added partial layouts (see example in action_view/lib/partials.rb) [DHH]David Heinemeier Hansson2007-08-028-2/+95
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add support for []= on ActiveSupport::Multibyte::Chars. Closes #9142. [ewan, ↵Marcel Molina2007-07-313-0/+74
| | | | | | manfred] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* dont call #collect on a string when returning query cache results. Closes ↵Rick Olson2007-07-252-1/+7
| | | | | | #9099 [norbert] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Perform a deep #dup on query cache results so that modifying activerecord ↵Rick Olson2007-07-253-20/+29
| | | | | | attributes does not modify the cached attributes. [Rick] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7238 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Ensure that has_many :through associations use a count query instead of ↵Rick Olson2007-07-253-0/+15
| | | | | | loading the target when #size is called. Closes #8800 [lifo] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* tiny doc patches [lifo]Rick Olson2007-07-252-2/+3
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7236 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* misc doc fixes + Add ActiveResource to Rails::Info. Closes #8741, #9008, ↵Rick Olson2007-07-255-48/+57
| | | | | | #9089 [kampers] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Allow you to set custom :conditions on resource routes. [Rick]Rick Olson2007-07-253-10/+25
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Use Gem.find_name instead of search when freezing gems. Prevent false ↵Michael Koziarski2007-07-242-2/+4
| | | | | | positive for other gems with rails in the name. Closes #8729 [wselman] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7233 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix load-order inconsistency (closes #9081) [themug]David Heinemeier Hansson2007-07-241-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7225 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Refactored in use of extract_options! (closes #9079) [josh]David Heinemeier Hansson2007-07-2418-32/+24
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7220 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added Array#extract_options! to encapsulate the pattern of getting an ↵David Heinemeier Hansson2007-07-244-0/+32
| | | | | | options hash out of a variable number of parameters (closes #8759) [norbert] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7217 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Automatically generate add/remove column commands in specially named ↵Rick Olson2007-07-244-2/+31
| | | | | | migrations like AddLocationToEvent. Closes #9006 [zenspider] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7216 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added :unless clause to validations (closes #8003) [monki]David Heinemeier Hansson2007-07-243-9/+105
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7215 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* assert_difference belongs in Assertions, not forced onto TestCase (closes ↵David Heinemeier Hansson2007-07-241-1/+1
| | | | | | #8894) [norbert] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that file.content_type for uploaded files would include a trailing \r ↵David Heinemeier Hansson2007-07-243-4/+6
| | | | | | #9053 [bgreenlee] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Its just ERb nowDavid Heinemeier Hansson2007-07-241-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix #count on a has_many :through association so that it recognizes the ↵Rick Olson2007-07-203-1/+22
| | | | | | :uniq option. Closes #8801 [lifofifo] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7199 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* * url_for now accepts a series of symbols representing the namespace of the ↵Tobias Lütke2007-07-194-4/+76
| | | | | | record [Josh Knowles]. Closes #8640 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7197 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* fix one line formatting bugMichael Koziarski2007-07-191-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7196 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Let alias_attribute work with attributes with initial capital letters ↵Michael Koziarski2007-07-193-3/+28
| | | | | | (legacy columns etc). Closes #8596 [mpalmer] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix and properly document/test count(column_name) usage. Closes #8999 [lifofifo]Rick Olson2007-07-173-10/+26
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7192 5ecf4fe2-1ee6-0310-87b1-e25e094e27de