aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Uninterned Symbol can be duped since ruby 2.4.1Akira Matsuda2017-01-261-1/+4
| | | | | | https://github.com/ruby/ruby/commit/11e6bd5ac2a2eebfa589bd6db8c9c4daa337733e Leaving the 2.4.0 conditional for now, in order never to forget backporting r57407 to 2.4.1
* Merge pull request #27804 from scottgonzalez/action-mailer-guideArthur Nogueira Neves2017-01-251-2/+2
|\ | | | | Action Mailer Basics clean up [ci skip]
| * Action Mailer Basics clean up [ci skip]Scott González2017-01-251-2/+2
|/
* s/an/a/Akira Matsuda2017-01-263-3/+3
| | | | [ci skip]
* Merge pull request #27799 from kenta-s/fix-grammar-in-number_helperVipul A M2017-01-252-2/+2
|\ | | | | Fix grammar 'an hyphen' -> 'a hyphen' [ci skip]
| * Fix grammar 'an hyphen' -> 'a hyphen' [ci skip]kenta-s2017-01-252-2/+2
|/
* Add assertion messagesAkira Matsuda2017-01-252-2/+2
| | | | | This message could be generated by `assert_predicate`, https://github.com/rails/rails/commit/1853a4f2c8b2bddfbde6aae80abb08310295201c#commitcomment-20546113 but I'd rather handwrite the message string if I could reduce magic from the code by doing so.
* Merge pull request #27796 from yui-knk/keep_separator_wasAndrew White2017-01-251-1/+2
|\ | | | | Keep the value of `$,` and restore it
| * Keep the value of `$,` and restore ityui-knk2017-01-251-1/+2
| | | | | | | | | | | | As unit tests, we do not know the value of `$,` when this test case started. It' better to keep the value when the test case fnished.
* | This seems to be working on JRuby 9KAkira Matsuda2017-01-251-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | % ruby -ve "p 'ほげ'.encode(Encoding::UTF_8_MAC)" jruby 1.7.26 (1.9.3p551) 2016-08-26 69763b8 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_45-b14 +jit [darwin-x86_64] "\u307B\u3052" % ruby -ve "p 'ほげ'.encode(Encoding::UTF_8_MAC)" jruby 9.1.7.0 (2.3.1) 2017-01-11 68056ae Java HotSpot(TM) 64-Bit Server VM 25.45-b02 on 1.8.0_45-b14 +jit [darwin-x86_64] "\u307B\u3051\u3099" % ruby -ve "p 'ほげ'.encode(Encoding::UTF_8_MAC)" ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin14] "\u307B\u3051\u3099"
* | Merge pull request #27798 from yui-knk/give_message_to_test_duplicableRichard Schneeman2017-01-251-1/+1
|\ \ | | | | | | Give a message to `#test_duplicable` assertion
| * | Give a message to `#test_duplicable` assertionyui-knk2017-01-251-1/+1
| |/ | | | | | | | | Giving a message helps us to know what happened when we look at Travis CI.
* | Change ActionView ERB Handler from Erubis to ErubiJeremy Evans2017-01-2513-81/+214
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Erubi offers the following advantages for Rails: * Works with ruby's --enable-frozen-string-literal option * Has 88% smaller memory footprint * Does no freedom patching (Erubis adds a method to Kernel) * Has simpler internals (1 file, <150 lines of code) * Has an open development model (Erubis doesn't have a public source control repository or bug tracker) * Is not dead (Erubis hasn't been updated since 2011) Erubi is a simplified fork of Erubis that contains just the parts that are generally needed (which includes the parts that Rails uses). The only intentional difference in behavior is that it does not include support for <%=== tags for debug output. That could be added to the ActionView ERB handler if it is desired. The Erubis template handler remains in a deprecated state so that code that accesses it directly does not break. It can be removed after Rails 5.1.
* | Merge pull request #27772 from y-yagi/remove_unreachable_codeSantiago Pastorino2017-01-242-8/+0
|\ \ | |/ |/| remove unreachable code
| * remove unreachable codeyuuji.yaginuma2017-01-232-8/+0
| | | | | | | | | | | | `app_path` is a required argument. Therefore, if `app_path` is not specified, it becomes an error in thor's option parsing, does not reach this check.
* | Merge pull request #27791 from ↵Kasper Timm Hansen2017-01-241-2/+2
|\ \ | | | | | | | | | | | | kenta-s/fix-sample-code-for-expand_cache_key-usage Fix sample code for `expand_cache_key` usage [ci skip]
| * | Fix sample code for `expand_cache_key` usage [ci skip]kenta-s2017-01-241-2/+2
|/ /
* | Merge pull request #27775 from domcleal/27774-format-resetEileen M. Uchitelle2017-01-232-0/+15
|\ \ | | | | | | Delete PATH_INFO after each controller test request
| * | Delete PATH_INFO after each controller test requestDominic Cleal2017-01-232-0/+15
|/ / | | | | | | | | | | | | | | | | | | Prevents PATH_INFO from being used to infer the request format in later test requests when no explicit format is given. As the request PATH_INFO may be set before a request, it can't be deleted during pre-request scrubbing. Fixes #27774
* | Bundler 1.14 compatMatthew Draper2017-01-231-1/+4
| |
* | Merge pull request #27771 from ↵Santiago Pastorino2017-01-232-1/+2
|\ \ | | | | | | | | | | | | y-yagi/do_not_run_git_init_when_specify_the_pretent_option do not run `git init` when specify the `pretend` option
| * | do not run `git init` when specify the `pretend` optionyuuji.yaginuma2017-01-232-1/+2
|/ / | | | | | | | | When specifying the `pretend` option, expect that no processing will be done, so do not execute `git init` as well.
* | Merge two tests that needs to initialize Rails before accessing `Rails`Akira Matsuda2017-01-231-16/+1
| | | | | | | | | | Fixes "NameError: uninitialized constant ApplicationTests::ConfigurationTests::CustomTest::Rails" when run individually
* | Merge pull request #27766 from ↵Jon Moss2017-01-221-1/+1
|\ \ | | | | | | | | | | | | kenta-s/add-module-name-to-backtrace-cleaner-sample-code Add module name to BacktraceCleaner usage example [ci skip]
| * | Add module name to BacktraceCleaner usage example [ci skip]kenta-s2017-01-221-1/+1
| |/
* | Merge pull request #27768 from kirs/am-decimal-castGuillermo Iguaran2017-01-221-1/+2
|\ \ | | | | | | Make BigDecimal casting consistent on different platforms
| * | Make BigDecimal casting consistent on different platformsKir Shatrov2017-01-221-1/+2
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Right now it behaves differently on JRuby: ``` --- expected +++ actual @@ -1 +1 @@ -#<BigDecimal:5f3c866c,'0.333333333333333333',18(20)> +#<BigDecimal:16e0afab,'0.3333333333333333',16(20)> ``` My initial PR (https://github.com/rails/rails/pull/27324) offered to let the precision to be decided by the platform and change the test expection, but other contributors suggested that we should change the default precision in Rails to be consistent of all platforms. The value (18) comes from the max default precision that comes from casting Rational(1/3) to BigDecimal.
* | Merge pull request #27763 from y-yagi/move_db_migrate_path_to_migration_moduleEileen M. Uchitelle2017-01-223-16/+8
|\ \ | | | | | | move `db_migrate_path` method to `Migration` module
| * | move `db_migrate_path` method to `Migration` moduleyuuji.yaginuma2017-01-223-16/+8
| |/ | | | | | | | | Since `Migration` module is included in both `MigrationGenerator` and `ModelGenerator`, no need to define a common method for each class.
* | Merge pull request #27764 from matrix9180/add_changelog_entry_for_27425Eileen M. Uchitelle2017-01-221-0/+6
|\ \ | |/ |/| Add changelog entry for #27425 [ci skip]
| * Add changelog entry for #27425 [ci skip]Chad Ingram2017-01-211-0/+6
|/
* Merge pull request #27760 from ↵Kasper Timm Hansen2017-01-211-2/+0
|\ | | | | | | | | kenta-s/remove-unnecessary-comments-in-cache_helper Remove unnecessary comments in cache_helper.rb [ci skip]
| * Remove unnecessary comments in cache_helper.rb [ci skip]kenta-s2017-01-211-2/+0
| |
* | Merge pull request #27761 from scottgonzalez/action-mailer-guideVipul A M2017-01-211-2/+2
|\ \ | | | | | | Clean up wording in Action Mailer Basics [ci skip]
| * | Clean up wording in Action Mailer Basics [ci skip]Scott González2017-01-211-2/+2
|/ /
* / Add examples for behaviour about redirection with and without options. Fixes ↵Vipul A M2017-01-211-0/+8
|/ | | | #27715 [ci skip] (#27730)
* Merge pull request #27751 from bogdanvlviv/add_missing_comment_outRafael França2017-01-201-1/+1
|\ | | | | add missing comment out [ci skip]
| * add missing comment out [ci skip]bogdanvlviv2017-01-201-1/+1
|/
* Merge pull request #27748 from y-yagi/add_missing_comment_outVipul A M2017-01-201-7/+7
|\ | | | | add missing comment out [ci skip]
| * add missing comment out [ci skip]yuuji.yaginuma2017-01-201-7/+7
| |
* | Merge pull request #27624 from elfassy/assert_enqueued_jobs_with_queue_levelGuillermo Iguaran2017-01-192-10/+45
|\ \ | | | | | | Specify the queue to be used with assert_enqueued_jobs
| * | assert_enqueued_jobs with queue optionMichael Elfassy2017-01-182-10/+45
| | |
* | | Merge pull request #27746 from kenta-s/add-missing-tests-for-template-textRafael França2017-01-191-0/+16
|\ \ \ | |_|/ |/| | Add missing tests for ActionView::Template::Text
| * | Add missing tests for ActionView::Template::Textkenta-s2017-01-201-0/+16
|/ /
* | Merge pull request #27742 from olivierlacan/patch-1Jon Moss2017-01-191-4/+6
|\ \ | | | | | | Mention ActiveRecord's config.example.yml
| * | Mention ActiveRecord's config.example.ymlOlivier Lacan2017-01-191-4/+6
|/ / | | | | | | This will help people figure out what credentials and tables are required to run ActiveRecord specs.
* | Merge pull request #27734 from y-yagi/update_create_table_statements_in_sqlite3Andrew White2017-01-191-2/+2
|\ \ | | | | | | update CREATE TABLE statements generated by `sqlite3` command
| * | update CREATE TABLE statements generated by `sqlite3` commandyuuji.yaginuma2017-01-191-2/+2
| | | | | | | | | | | | | | | | | | | | | From SQLite 3.16.0, `IF NOT EXISTS` set to CREATE TABLE statements. Ref: https://www.sqlite.org/src/info/c7021960f5c070fb Fixes #27635.
* | | Merge pull request #27733 from kenta-s/add-missing-argument-to-find_templatesAndrew White2017-01-191-2/+2
|\ \ \ | | | | | | | | `find_templates` should be able to handle 5 arguments
| * | | `find_templates` should be able to handle 5 argumentskenta-s2017-01-191-2/+2
| |/ /
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 16:00:20 +0000