aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | | move options_constraints tests next to each otherAaron Patterson2014-06-031-2/+2
| | | | | | | | | |
* | | | | | | | | | only do is_a checks on `formatted` onceAaron Patterson2014-06-031-9/+5
| | | | | | | | | |
* | | | | | | | | | push options_constraints processing upAaron Patterson2014-06-031-22/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this lets us reduce is_a checks on the options_constraints and push "callable constraints" verification to the right place.
* | | | | | | | | | remove options as an ivarAaron Patterson2014-06-031-6/+8
| | | | | | | | | |
* | | | | | | | | | only do Regexp === option onceAaron Patterson2014-06-031-3/+4
| | | | | | | | | |
* | | | | | | | | | return early from add_request_methodAaron Patterson2014-06-031-11/+11
| | | | | | | | | |
* | | | | | | | | | only loop over `options` once (hopefully)Aaron Patterson2014-06-031-13/+11
| | | | | | | | | |
* | | | | | | | | | only loop through constraints onceAaron Patterson2014-06-031-19/+15
| | | | | | | | | |
* | | | | | | | | | change defaults allocation to a one-linerAaron Patterson2014-06-031-3/+2
| | | | | | | | | |
* | | | | | | | | | no longer need the scope ivarAaron Patterson2014-06-031-2/+1
| | | | | | | | | |
* | | | | | | | | | only look up scope[:module] onceAaron Patterson2014-06-031-6/+6
| | | | | | | | | |
* | | | | | | | | | remove IGNORE_OPTIONSAaron Patterson2014-06-031-4/+8
| | | | | | | | | |
* | | | | | | | | | :only is never used in Mapping, so rm the keyAaron Patterson2014-06-031-1/+2
| | | | | | | | | |
* | | | | | | | | | remove :defaults from the IGNORE_OPTIONS listAaron Patterson2014-06-031-4/+4
| | | | | | | | | |
* | | | | | | | | | remove :constraints from IGNORE_OPTIONSAaron Patterson2014-06-031-4/+5
| | | | | | | | | |
* | | | | | | | | | disconnect normalize_defaults! from options[:constraints]Aaron Patterson2014-06-031-6/+6
| | | | | | | | | |
* | | | | | | | | | disconnect options and scope from the `blocks` methodAaron Patterson2014-06-031-7/+8
| | | | | | | | | |
* | | | | | | | | | disconnect the constraints method from the options and scope hashesAaron Patterson2014-06-031-12/+15
| | | | | | | | | |
* | | | | | | | | | :on is removed from options before the Mapping is instantiated, so remove it ↵Aaron Patterson2014-06-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from IGNORE_OPTIONS
* | | | | | | | | | pull up via extraction and remove it from options / IGNORE_OPTIONSAaron Patterson2014-06-031-8/+6
| | | | | | | | | |
* | | | | | | | | | always make :via a listAaron Patterson2014-06-031-3/+2
| | | | | | | | | |
* | | | | | | | | | always pull out a via variable and simplify logicAaron Patterson2014-06-031-12/+15
| | | | | | | | | |
* | | | | | | | | | test with an empty viaAaron Patterson2014-06-031-0/+8
| | | | | | | | | |
* | | | | | | | | | add a test for missing "via" parameterAaron Patterson2014-06-032-1/+9
| | | | | | | | | |
* | | | | | | | | | remove :as and :anchor from IGNORE_OPTIONSAaron Patterson2014-06-031-3/+5
| | | | | | | | | |
* | | | | | | | | | remove another value from IGNORE_OPTIONSAaron Patterson2014-06-031-2/+2
| | | | | | | | | |
* | | | | | | | | | shorten up IGNORE_OPTIONSAaron Patterson2014-06-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | since we are now passing the format value around, we can remove it from the options hash, which means we don't need to consult as many values from IGNORE_OPTIONS
* | | | | | | | | | only look up the format option from the hash onceAaron Patterson2014-06-031-16/+18
| | | | | | | | | |
* | | | | | | | | | Merge pull request #15486 from sgrif/sg-binary-quotingMatthew Draper2014-06-045-47/+83
|\ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / |/| | | | | | | | | Refactor quoting of binary data to not be based on the column type
| * | | | | | | | | Refactor quoting of binary data to not be based on the column typeSean Griffin2014-06-035-47/+83
| | |/ / / / / / / | |/| | | | | | |
* | | | | | | | | test pg, remove unused column assignments. Follow up to 254cdf47Yves Senn2014-06-035-12/+0
| | | | | | | | |
* | | | | | | | | pg, preserve money type when dumping schema and extract money default.Yves Senn2014-06-037-22/+39
| | | | | | | | |
* | | | | | | | | test pg, rm unused requires.Yves Senn2014-06-0311-27/+0
| |_|_|_|/ / / / |/| | | | | | |
* | | | | | | | Merge pull request #15487 from sgrif/sg-bit-limitYves Senn2014-06-033-32/+32
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Respect limit for PG bit strings
| * | | | | | | | Respect limit for PG bit stringsSean Griffin2014-06-033-32/+32
| | | | | | | | |
* | | | | | | | | Merge pull request #15442 from sgrif/sg-refactor-field-changedYves Senn2014-06-036-36/+39
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | Refactor determination of whether the field has changed
| * | | | | | | | Refactor determination of whether the field has changedSean Griffin2014-06-036-36/+39
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The types know more about what is going on than the dirty module. Let's ask them!
* | | | | | | | pg, preserve type when schema dumping bit and bit varying columns.Yves Senn2014-06-037-12/+44
| | | | | | | |
* | | | | | | | test pg, move bit string type tests into `bit_string_test.rb`.Yves Senn2014-06-033-42/+80
| | | | | | | |
* | | | | | | | test pg, we don't care about the internal state of `column#default`.Yves Senn2014-06-035-9/+0
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | That data is internal to Active Record. What we care about is that new records have the right default value.
* | | | | | | pg, preserve point type when schema dumping.Yves Senn2014-06-036-11/+24
| | | | | | |
* | | | | | | pg test, examples for default values and schema dumping of point types.Yves Senn2014-06-032-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | /cc @sgrif
* | | | | | | Merge pull request #15483 from ↵Yves Senn2014-06-034-11/+11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | eileencodes/reuse-available-reflection-polymorphic-methods fix polymorphic? method and reuse it
| * | | | | | | fix polymorphic? method and reuse iteileencodes2014-06-024-11/+11
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix polymorphic to check for `options[:polymorphic]` instead of `options.key? :polymorphic` and then reuse the method `polymorphic?` method instead of constantly checking the same `options[:polymorphic]`.
* | | | | | | call `capture` fewer times from `form_for`Aaron Patterson2014-06-022-4/+4
| | | | | | |
* | | | | | | drastically reduce object allocationsAaron Patterson2014-06-022-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | before this change, we were allocating AS::SafeBuffer objects that were being interpolated in to a string, so the safe buffer object was being thrown away. This change only allocates a string (vs a string *and* a safebuffer) and interpolates the string. On my test application, this reduced the AS::SafeBuffer objects from 1527k per request to about 500 per request.
* | | | | | | reduce AS::SafeBuffer allocationsAaron Patterson2014-06-021-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | html_escape_interpolated_argument is only used in mutation methods: https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L174 https://github.com/rails/rails/blob/c07d09559ec171e1904b55c7ad7e8c7d586ca51b/activesupport/lib/active_support/core_ext/string/output_safety.rb#L179 The return value doesn't need to be converted to an AS::SafeBuffer since we know that the current object is an AS::SafeBuffer and will be mutated, and the return value from html_escape_interpolated_argument will be thrown away
* | | | | | | Merge pull request #15475 from sgrif/sg-initialize-attributesGuillermo Iguaran2014-06-023-11/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Remove unused `initialize_attributes` method
| * | | | | | | Remove unused `initialize_attributes` methodSean Griffin2014-06-023-11/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was previously a hook for a special case related to `serialize`, which has since been removed.
* | | | | | | | concat is a hotspot (via AV#append=), so just directly define the methodsAaron Patterson2014-06-021-4/+6
| |_|_|_|_|_|/ |/| | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-31 21:21:16 +0000