aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Merge pull request #20106 from claudiob/finder-rails3Yves Senn2015-05-111-14/+2
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Stop explaining finders for Rails 3
| * | | | | [ci skip] Stop explaining finders for Rails 3claudiob2015-05-101-14/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that master points at Rails 5, we might not need to explain how things used to work in Rails 3. Or we might… up to you :grin:
* | | | | | Merge pull request #20100 from claudiob/don-t-skip-rbx-testCarlos Antonio da Silva2015-05-101-2/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | Stop skipping a test that now works on Rubinius
| * | | | | | Stop skipping a test that now works on Rubiniusclaudiob2015-05-101-2/+0
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test was skipped because of an issue that, in the meantime, has been fixed: https://github.com/rubinius/rubinius/issues/3328. Using the latest Rubinius (the one currently on Travis CI), this is the result: ```sh $ ruby --version rubinius 2.5.3 (2.1.0 2482b093 2015-05-10 3.5.1 JI) [x86_64-darwin14.3.0] ``` **Before this PR** ```sh $ ruby -Itest test/cases/attribute_assignment_test.rb Run options: --seed 58569 .....S... Finished in 0.048278s, 186.4203 runs/s, 269.2738 assertions/s. 9 runs, 13 assertions, 0 failures, 0 errors, 1 skips You have skipped tests. Run with --verbose for details. ``` **After this PR** $ ruby -Itest test/cases/attribute_assignment_test.rb Run options: --seed 35720 ......... Finished in 0.029441s, 305.6961 runs/s, 475.5273 assertions/s. 9 runs, 14 assertions, 0 failures, 0 errors, 0 skips ```
* | | | | | Merge pull request #20101 from imtayadeway/tw/active-record-querying-docsZachary Scott2015-05-101-2/+3
|\ \ \ \ \ \ | |/ / / / / |/| | | | | [ci skip] Improve phrasing on #explain pretty printing.
| * | | | | [ci skip] Improve phrasing on #explain pretty printing.Tim Wade2015-05-101-2/+3
|/ / / / /
* | | | | Merge pull request #20099 from yui-knk/fix/comment_association_cacheAbdelkader Boudih2015-05-101-1/+1
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Fix comment of `ActiveRecord::Associations#association_inst…
| * | | | | [ci skip] Fix comment of `ActiveRecord::Associations#association_instance_get`yui-knk2015-05-111-1/+1
| |/ / / /
* | | | | Merge pull request #20097 from ankit8898/refac_test_amSantiago Pastorino2015-05-102-2/+0
|\ \ \ \ \ | | | | | | | | | | | | not needed require's
| * | | | | not needed require'sAnkit Gupta2015-05-102-2/+0
| |/ / / / | | | | | | | | | | | | | | | | | | | | - as core_ext is not used and test pass locally - mail is already required in abstract_unit
* | | | | Merge pull request #20096 from yui-knk/fix/testing_guideEileen M. Uchitelle2015-05-101-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | [ci skip] Fix purpose of `assert_kind_of`
| * | | | [ci skip] Fix purpose of `assert_kind_of`yui-knk2015-05-101-1/+1
|/ / / /
* | | | Merge pull request #20094 from vngrs/refactor_railties_commandsRafael Mendonça França2015-05-104-109/+103
|\ \ \ \ | | | | | | | | | | Refactor railties console and dbconsole commands
| * | | | Refactor railties console and dbconsole commandsMehmet Emin İNAÇ2015-05-104-109/+103
|/ / / / | | | | | | | | | | | | fix minor convention problems
* | | | Merge pull request #20087 from kuldeepaggarwal/fix-engine-guidesYves Senn2015-05-091-2/+2
|\ \ \ \ | | | | | | | | | | correct error text message in engines.md [ci skip]
| * | | | [CI SKIP] correct error text messagekuldeepaggarwal2015-05-091-2/+2
| | | | |
* | | | | Merge pull request #20086 from farukaydin/before-action-docEileen M. Uchitelle2015-05-091-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | promote :except option instead of :only for before action docs [ci skip]
| * | | | promote :except option instead of :only for before action docs [ci skip]Faruk AYDIN2015-05-091-1/+1
| | | | |
* | | | | Move `TemplateAssertions` to their own fileeileencodes2015-05-092-188/+189
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This moves `TemplateAssertions` out of the `test_case.rb` file and into it's own `template_assertions` file. It still inherits from `ActionController`.` This is in preparation for combining the code for Integration tests and Controller tests. This will need to be it's own file to be added to the `requires` for Integration tests. This does not currently change ANY behavior, just moving it for access later on.
* | | | | Merge pull request #20085 from y-yagi/improve_assert_emails_msgYves Senn2015-05-093-1/+17
|\ \ \ \ \ | |/ / / / |/| | | | `assert_emails` in block form use the given number as expected value
| * | | | `assert_emails` in block form use the given number as expected valueyuuji.yaginuma2015-05-093-1/+17
|/ / / /
* | | | Merge pull request #20081 from gouravtiwari/patch-3Arun Agrawal2015-05-081-2/+2
|\ \ \ \ | | | | | | | | | | minor rdoc syntax fix [ci skip]
| * | | | minor rdoc syntax fix [ci skip]Gourav Tiwari2015-05-081-2/+2
|/ / / /
* | | | Merge pull request #20079 from ankit8898/aj_allArun Agrawal2015-05-081-0/+1
|\ \ \ \ | | | | | | | | | | docs: syncing with the code, adding aj [ci skip]
| * | | | docs: syncing with the code, adding aj [ci skip]Ankit Gupta2015-05-081-0/+1
| | | | |
* | | | | Merge pull request #20078 from robertjlooby/fix_generated_features_methods_docsRafael Mendonça França2015-05-081-1/+1
|\ \ \ \ \ | | | | | | | | | | | | change GeneratedFeatureMethods to GeneratedAssociationMethods in docs
| * | | | | change GeneratedFeatureMethods to GeneratedAssociationMethods in docsRob Looby2015-05-081-1/+1
|/ / / / / | | | | | | | | | | | | | | | the module name was changed in 8e814a0ac0768816974d2bfd68d33d931592751e
* | | | | Merge pull request #20064 from kddeisz/qu_provider_job_idRafael Mendonça França2015-05-084-9/+16
|\ \ \ \ \ | | | | | | | | | | | | Provide provider_job_id to qu adapter.
| * | | | | Provide provider_job_id to qu adapter.Kevin Deisz2015-05-074-9/+16
| | | | | | | | | | | | | | | | | | | | | | | | Further work to provide provider_job_id for queue adapters.
* | | | | | Merge pull request #20074 from ankit8898/as_core_ext_req_notRafael Mendonça França2015-05-082-2/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | as/core_ext require's not used
| * | | | | | as/core_ext require's not usedAnkit Gupta2015-05-082-2/+0
| | |/ / / / | |/| | | |
* | | | | | Merge pull request #20075 from gouravtiwari/patch-2Rafael Mendonça França2015-05-081-8/+12
|\ \ \ \ \ \ | | | | | | | | | | | | | | Better formatted documents [ci skip]
| * | | | | | Better formatted documents [ci skip]Gourav Tiwari2015-05-081-8/+12
|/ / / / / /
* | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-05-087-14/+15
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | |
| * | | | | [ci skip] Add an example to ActionView::Helpers::FormBuilder#labelyui-knk2015-05-081-0/+1
| | | | | |
| * | | | | Updated titles of headers in Action Mailer guidePrathamesh Sonpatki2015-04-281-2/+2
| | | | | |
| * | | | | Replaced Javascript with JavaScript in guidesPrathamesh Sonpatki2015-04-282-2/+2
| | | | | |
| * | | | | Add missing "of" to RequestForgeryProtection doc.Hendy Tanata2015-04-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
| * | | | | Fix method name for building associated object in nested_model_forms guidePrathamesh Sonpatki2015-04-251-1/+1
| | | | | |
| * | | | | [ci skip] fix count of options for `find_each`Mikhail Dieterle2015-04-231-1/+1
| | | | | |
| * | | | | [ci skip] `deep_dup` is instance method of `Hash`yui-knk2015-04-221-1/+1
| | | | | |
| * | | | | [ci skip] `deep_dup` is instance method of `Array`yui-knk2015-04-211-1/+1
| | | | | |
| * | | | | [ci skip] Fix returned values of code sampleyui-knk2015-04-191-6/+6
| | | | | |
* | | | | | Merge pull request #20072 from vngrs/refactor_active_job_sidekiq_adapterYves Senn2015-05-081-6/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Refactor sidekiq adapter enqueue and enqueue_at methods
| * | | | | | Refactor sidekiq adapter enqueue and enqueue_at methodsMehmet Emin İNAÇ2015-05-081-6/+2
| | |/ / / / | |/| | | |
* | | | | | Merge pull request #20073 from ↵Yves Senn2015-05-081-2/+0
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | vngrs/remove_test_order_from_activejob_test_helper Don't need to explicitly set test_order it's :random default
| * | | | | Don't need to explicitly set test_order it's :random defaultMehmet Emin İNAÇ2015-05-081-2/+0
|/ / / / /
* | | | | Merge pull request #20068 from mcfiredrill/nodoc-postgresql-rename-columnYves Senn2015-05-081-1/+1
|\ \ \ \ \ | | | | | | | | | | | | :nodoc: rename_column in postgresql/schema_statements.rb [ci skip]
| * | | | | :nodoc: rename_column in postgresql/schema_statements.rbTony Miller2015-05-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Its already doc'ed in activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
* | | | | | remove duplicate test.Yves Senn2015-05-081-10/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The old `test_create_bang_returns_falsy_when_join_record_has_errors` had a missleading name and was a duplicate of `test_save_should_not_raise_exception_when_join_record_has_errors`. Since it had an assertion on the return value I renamed it accordingly and got rid of the duplicate test.
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-21 18:43:25 +0000