aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | push parent up to the superclassAaron Patterson2013-10-093-7/+11
| | | | | | | | | | | | | | | | We always want a linked list back to the root node.
| * | | convert JoinBase to a tree and remove the Node classAaron Patterson2013-10-092-42/+30
| | | |
| * | | names are guaranteed to be symbolsAaron Patterson2013-10-081-1/+1
| | | |
| * | | eliminate function that is only used in one placeAaron Patterson2013-10-081-7/+2
| | | |
| * | | we will always detect the same node, so just pass the node inAaron Patterson2013-10-081-7/+2
| | | |
| * | | we do not need to to_s the name all the timeAaron Patterson2013-10-081-5/+3
| | | |
| * | | parent is guaranteed to be the sameAaron Patterson2013-10-081-4/+1
| | | | | | | | | | | | | | | | | | | | since we are searching a tree, the current level should be consistent, so we don't have to inspect the parent class / table
| * | | reduce number of comparisons and array allocationsAaron Patterson2013-10-081-11/+10
| | | | | | | | | | | | | | | | | | | | Just inspecting the children nodes will reduce the number of comparisons we have to do (since it is limited to the child size)
| * | | rename the variable to make more sense with a treeAaron Patterson2013-10-081-7/+7
| | | |
| * | | walk the tree rather than generating a hash and walking itAaron Patterson2013-10-081-21/+10
| | | |
| * | | do not convert the tree to a list just for the first nodeAaron Patterson2013-10-081-1/+1
| | | |
| * | | generate the association hash from the top downAaron Patterson2013-10-081-17/+15
| | | | | | | | | | | | | | | | | | | | This prevents us from walking back up the parent tree once for each leaf.
| * | | store join parts in a treeAaron Patterson2013-10-081-16/+45
| | | |
* | | | Merge pull request #12485 from arunagw/code-removalRafael Mendonça França2013-10-092-35/+0
|\ \ \ \ | | | | | | | | | | viewpathtests file moved
| * | | | Moved viewpathstest into actionview/test/actionpack/controllerArun Agrawal2013-10-091-0/+0
| | | | | | | | | | | | | | | | | | | | These test were not running at all, Now it will run as a tests part.
| * | | | FakeController is not required in AVArun Agrawal2013-10-091-35/+0
|/ / / /
* | | | Merge pull request #12482 from francisgo/patch-11Yves Senn2013-10-091-1/+1
|\ \ \ \ | | | | | | | | | | [Validations Guide] Add full stop to the end of sentence [ci skip]
| * | | | [Validations Guide] Add full stop to the end of sentence [ci skip]Francis Go2013-10-101-1/+1
|/ / / /
* | | | Merge pull request #12481 from arunagw/fixesRafael Mendonça França2013-10-096-10/+11
|\ \ \ \ | | | | | | | | | | Few fixes which includes revert fixes
| * | | | Added ActionView in rake about [ci skip]Arun Agrawal2013-10-091-5/+6
| | | | |
| * | | | Minor align BR tags with HTML void - with reference to the generators code ↵AvnerCohen2013-10-092-2/+2
| | | | | | | | | | | | | | | | | | | | change - https://github.com/rails/rails/commit/f038d4cc5fe1ac21f92c7e32c61ff85a0c816f3f
| * | | | Using flat_map instead of map and flattenArun Agrawal2013-10-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | original commit 8998441967a8cfc6e4302c29664ab9d0acd77704 Reverted here ec8ef1e1055c4e1598da13f49d30261f07f4a9b4
| * | | | Typo fix [ci skip]Arun Agrawal2013-10-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixing the typo which is formed a not required link. Check here http://api.rubyonrails.org/classes/ActionController/Base.html under paramters section keeping it under tt tag gets reverted here ec8ef1e1055c4e1598da13f49d30261f07f4a9b4
| * | | | observers are not part of ActiveModel [ci skip]Arun Agrawal2013-10-091-1/+1
|/ / / /
* | | | Merge pull request #12283 from JuanitoFatas/rails-on-rackYves Senn2013-10-091-1/+5
|\ \ \ \ | | | | | | | | | | [ci skip] Add explanation on Rack::Sendfile middleware in rails_on_rack.md.
| * | | | [ci skip] Add explanation on Rack::Sendfile and fix serve static files setting.Juanito Fatas2013-10-041-1/+5
| | | | |
* | | | | Merge pull request #12479 from benpickles/unshift-middlewareJosé Valim2013-10-093-0/+14
|\ \ \ \ \ | | | | | | | | | | | | Expose MiddlewareStack#unshift to environment configuration
| * | | | | Expose MiddlewareStack#unshift to environment configuration.Ben Pickles2013-10-093-0/+14
| | |_|/ / | |/| | |
* | | | | add dots after `Fixes #YYYYY` in actionpack CHANGELOG. [ci skip]Yves Senn2013-10-091-12/+12
| | | | |
* | | | | Merge pull request #12083 from BlueHotDog/fixing_respond_withYves Senn2013-10-094-0/+25
|\ \ \ \ \ | | | | | | | | | | | | Fixing repond_with working directly on the options hash
| * | | | | Fixing repond_with working directly on the options hashBlueHotDog2013-10-094-0/+25
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes an issue where the respond_with worked directly with the given options hash, so that if a user relied on it after calling respond_with, the hash wouldn't be the same. Fixes #12029
* | | | | Merge pull request #12473 from claudiob/document-after-touchYves Senn2013-10-092-2/+6
|\ \ \ \ \ | |/ / / / |/| | | | Add documentation for after_touch [ci skip]
| * | | | Add documentation for after_touch [ci skip]claudiob2013-10-082-2/+6
| | |/ / | |/| |
* | | | :scissors:Rafael Mendonça França2013-10-092-2/+2
| | | |
* | | | Push define_accessors to class level since we don't need anythig fromRafael Mendonça França2013-10-083-8/+8
| | | | | | | | | | | | | | | | the instance
* | | | Use the reflection name instead of the accessorRafael Mendonça França2013-10-082-1/+2
| | | |
* | | | Move add_counter_cache_methods to class levelRafael Mendonça França2013-10-081-2/+2
| | | |
* | | | Move define_constructors to class levelRafael Mendonça França2013-10-081-3/+2
| | | |
* | | | Move define_writers to class level since we don't need anything from theRafael Mendonça França2013-10-082-3/+3
| | | | | | | | | | | | | | | | instance
* | | | Move define_readers to class method since it doesn't need nothing fromRafael Mendonça França2013-10-082-5/+3
| | | | | | | | | | | | | | | | the instance
* | | | Fix the indentationRafael Mendonça França2013-10-081-12/+13
|/ / /
* | | join parts in `build` are *always* new, so don't bother checkingAaron Patterson2013-10-081-1/+2
| | |
* | | stop looking up the reflection multiple timesAaron Patterson2013-10-081-6/+5
| | |
* | | Merge pull request #12470 from nameisvijay/activemodel_example_fixRafael Mendonça França2013-10-081-0/+1
|\ \ \ | | | | | | | | adding load_path to include active_model in the load path of example
| * | | adding load_path to include active_model in the load path of exampleVijay Ubuntu2013-10-091-0/+1
| | |/ | |/| | | | | | | similar to activerecord/examples/simple.rb
* | | cache join associations and join base on the stackAaron Patterson2013-10-081-4/+11
| | | | | | | | | | | | No reason to decompose the join objects on every iteration
* | | use the API rather than accessing underlying data structuresAaron Patterson2013-10-081-1/+1
| | |
* | | associations is always a hashAaron Patterson2013-10-081-19/+13
| | |
* | | keys are always symbolsAaron Patterson2013-10-081-2/+4
| | |
* | | we can get a list of reflections from the join parts, so let's removeAaron Patterson2013-10-081-3/+5
| | | | | | | | | | | | the @reflections ivar.