| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Use more semantic method to authenticate password in SecurePassword
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
prathamesh-sonpatki/fix-application-name-description
Fix description for application_name method - change simple to simply [ci skip]
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
Better docs for AV::RecordIdentifier [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit intends to clarify the scope of ActionView::RecordIdentifier
methods `dom_id` and `dom_class`.
Most of the current documentation comes from da257eb8 (7 years ago) when
the decoupling of ActionView, ActiveRecord and ActiveModel was not a concern.
Since then, steps have been taken to reach such decoupling, especially
8ca17926 which duplicated ActionController::ModelNaming into
ActionView::ModelNaming explaining that:
> These are just a simple helpers for decoupling Active Model, so it does not
> make sense to extract it to Active Support, but the point is to decouple also
> Action View and Action Pack
As of today, ActionView::RecordIdentifier only includes `dom_id` and `dom_class`
so it makes sense to explicitly document those two methods, and leaving the
details of helpers like `div_for` in the corresponding files.
Moreover, I think it's important to mention in the documentation that
ActionView::RecordIdentifier **does not strictly depend on the ActiveRecord API**: any class `Post` implementing `post.to_key` and `post.model_name.param_key` will work.
[ci skip]
|
|\ \ \ \
| |_|_|/
|/| | | |
Remove single space response body for head request
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- The single space response was added due to a bug in safari
in https://github.com/rails/rails/commit/cb0f8fda9652c4d24d04693bdb82cecd3b067e5c
and
https://github.com/rails/rails/commit/807df4fcf021fc4d15972aa1c17ba7398d43ab0d.
- This was removed from the `render nothing: true` in
https://github.com/rails/rails/pull/14883.
- Removing it from response of :head also. As :head is more obvious
alternative to call `render nothing:
true`(http://guides.rubyonrails.org/layouts_and_rendering.html#using-head-to-build-header-only-responses),
removing it from head method also.
- Closes #18253.
|
|\ \ \
| | | |
| | | |
| | | | |
Fix form_for to work with objects that implement to_model
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously, if you tried to use form_for with a presenter object
that implements to_model, it would crash in
action_dispatch/routing/polymorphic_routes.rb when asking the presenter
whether it is .persisted?
Now, we always ask .persisted? of the to_model object instead.
This seems to been an issue since 1606fc9d840da869a60213bc889da6fcf1fdc431
Signed-off-by: Eugenia Dellapenna <eugenia.dellapenna@gmail.com>
|
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | | |
Closes #7247.
Conflicts:
activerecord/CHANGELOG.md
activerecord/test/models/owner.rb
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Given the following templates:
mailer/demo.html.erb
mailer/demo.en.html.erb
mailer/demo.pt.html.erb
Before this change for a locale that doesn't have its related file
the `mailer/demo.html.erb` will
be rendered even if `en` is the default locale.
Now `mailer/demo.en.html.erb` has precedence over the file without
locale.
Also, it is possible to give a fallback.
mailer/demo.pt.html.erb
mailer/demo.pt-BR.html.erb
So if the locale is `pt-PT`, `mailer/demo.pt.html.erb` will be
rendered given the right I18n fallback configuration.
Fixes #11884.
|
| | |
| | |
| | |
| | |
| | | |
It makes more sense here, rather than after explaining all of the testing
facilities of Rails. [ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
82b75eda70f8c30f7c418e7350532a3a0ed2a8c3
Also explain how Rails inherits capabilities from Minitest. Test classes should
be roughly the same based on this information, we can address them at a high
level when introducing the first test case. [ci skip]
|
|/ /
| |
| |
| | |
assertions are introduced. [ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| | |
existing example. [ci skip]
My reasoning is that this is probably too much information for the complete
Rails testing guide, as we're trying to cover testing all aspects of the
framework.
|
| | |
|
| |
| |
| |
| |
| | |
before this PR IDENTIFIER_ERROR_MESSAGE could lead to misunderstand the convention of partial name.
Added OPTION_AS_ERROR_MESSAGE for unvalid charter in as option.
|
|\ \ |
|
| |\ \
| | | |
| | | | |
Add doc for `:touch` option of AR::Base#save
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
ActiveRecord::Base `save` and `save!` take an option boolean
`:touch` parameter since #18225 (stems from #18202).
This commit document that parameter.
[ci skip]
|
| | | | |
|
| | | | |
|
|/ / / |
|
| | | |
|
| | | |
|
| | | |
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
use-cases.
Briefly explain difference between Functional and Request type tests. [ci skip]
|
|\ \
| | |
| | | |
Document the include_all_helpers config setting
|
| | |
| | |
| | |
| | |
| | | |
This config setting has been available for quite a while but was not
documented.
|
|\ \ \
| |/ /
|/| | |
Removed Object#itself as it's implemented in ruby 2.2
|
| | | |
|
|/ /
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | | |
Guide for Action Mailer Basics: Un-inline if statement
|
|/ /
| |
| |
| |
| | |
The single line was long enough that it rendered on two lines,
causing the example to look like syntactically invalid code.
|
|\ \
| | |
| | | |
plugin's gemfile also needs tzinfo-data in Windows
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Fixes #18237
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is no longer required now that we are injecting a type caster
object into the Arel table, with the exception of uniqueness
validations. Since it calls `ConnectionAdapter#type_cast`, the value has
already been cast for the database. We don't want Arel to attempt to
cast it further, so we need to continue wrapping it in a quoted node.
This can potentially go away when this validator is refactored to make
better use of `where` or the predicate builder.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This API will require much less consuming code to change to accomodate
the removal of automatic type casting from Arel. As long as the
predicates are constructed using the `arel_table` off of an AR subclass,
there will be no changes that need to happen.
|
|\ \ \
| | | |
| | | | |
`eager_load` preserves readonly flag for associations
|
| | | | |
|
| |/ /
|/| |
| | |
| | |
| | |
| | | |
It is already docummented at persistence.rb.
[ci skip]
|