| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | | | Fix for relative url root in assets | Guillermo Iguaran | 2011-09-13 | 1 | -4/+2 | |
| |/ / / | ||||||
| * | | | Merge pull request #2996 from guilleiguaran/move-assets-tests | Santiago Pastorino | 2011-09-13 | 2 | -31/+31 | |
| |\ \ \ | | | | | | | | | Move asset tests to assets_test file | |||||
| | * | | | Move asset tests to assets_test file | Guillermo Iguaran | 2011-09-13 | 2 | -31/+31 | |
| | | | | | ||||||
| * | | | | always rewrite_relative_url_root | Santiago Pastorino | 2011-09-13 | 2 | -6/+2 | |
| |/ / / | ||||||
| * | | | Merge pull request #2993 from deepakprasanna/generator_test_fix | Santiago Pastorino | 2011-09-12 | 1 | -1/+1 | |
| |\ \ \ | | | | | | | | | fixed the failing generators_test in railties. | |||||
| | * | | | fixed the failing generators_test | Deepak Prasanna | 2011-09-13 | 1 | -1/+1 | |
| |/ / / | ||||||
| * | | | Merge pull request #2977 from guilleiguaran/fix-relative-root-in-assets | Santiago Pastorino | 2011-09-12 | 3 | -3/+22 | |
| |\ \ \ | | | | | | | | | Set relative url root in assets when controller isn't available for Sprockets | |||||
| | * | | | Set relative url root in assets when controller isn't available for ↵ | Guillermo Iguaran | 2011-09-13 | 3 | -3/+22 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Sprockets. Fix #2435 See https://github.com/rails/sass-rails/issues/42 for details | |||||
| * | | | | Merge pull request #2987 from kennyj/master | Santiago Pastorino | 2011-09-12 | 2 | -0/+19 | |
| |\ \ \ \ | | | | | | | | | | | fix https://github.com/rails/rails/issues/2947 (with testcase) | |||||
| | * | | | | fix https://github.com/rails/rails/issues/2947 (with testcase) | kennyj | 2011-09-13 | 2 | -0/+19 | |
| | | | | | | ||||||
| * | | | | | removing backwards compatibility module | Aaron Patterson | 2011-09-12 | 3 | -9/+8 | |
| | | | | | | ||||||
| * | | | | | point rails at Journey for dev and edge | Aaron Patterson | 2011-09-12 | 2 | -0/+3 | |
| | | | | | | ||||||
| * | | | | | partially expand the parameters to `match` | Aaron Patterson | 2011-09-12 | 1 | -3/+3 | |
| | | | | | | ||||||
| * | | | | | unfactor the Route class to private factory methods | Aaron Patterson | 2011-09-12 | 2 | -45/+42 | |
| | | | | | | ||||||
| * | | | | | reduce dependencies of external objects in the Route class | Aaron Patterson | 2011-09-12 | 2 | -16/+18 | |
| | | | | | | ||||||
| * | | | | | delete unused code, pass path explicitly to journey | Aaron Patterson | 2011-09-12 | 2 | -28/+7 | |
| | | | | | | ||||||
| * | | | | | adjust route inspection to work with Journey | Aaron Patterson | 2011-09-12 | 1 | -1/+2 | |
| | | | | | | ||||||
| * | | | | | all routes can be stored in the Journey Routes object | Aaron Patterson | 2011-09-12 | 3 | -6/+6 | |
| | | | | | | ||||||
| * | | | | | clear! does not need to be called from initialize | Aaron Patterson | 2011-09-12 | 1 | -4/+3 | |
| | | | | | | ||||||
| * | | | | | reuse the route collection and formatter by clearing them | Aaron Patterson | 2011-09-12 | 1 | -6/+10 | |
| | | | | | | ||||||
| * | | | | | Instantiate each part of our routing system: | Aaron Patterson | 2011-09-12 | 1 | -7/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * A collection of Routes * The Router, which consults the collection of routes * A formatter that consults the collection of routes | |||||
| * | | | | | stop freezing the routes | Aaron Patterson | 2011-09-12 | 1 | -1/+0 | |
| | | | | | | ||||||
| * | | | | | stop using a hash for parameterizing | Aaron Patterson | 2011-09-12 | 1 | -11/+9 | |
| | | | | | | ||||||
| * | | | | | Switching rack-mount to journey. | Aaron Patterson | 2011-09-12 | 3 | -2/+10 | |
| | | | | | | ||||||
| * | | | | | Deprecate using method_missing for attributes that are columns. | Jon Leighton | 2011-09-13 | 2 | -0/+30 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This shouldn't ever happen unless people are doing something particularly weird, but adding a deprecation in case there are bugs not caught by our tests. | |||||
| * | | | | | Add an attribute_missing method to ActiveModel::AttributeMethods. | Jon Leighton | 2011-09-13 | 2 | -8/+26 | |
| | | | | | | | | | | | | | | | | | | | | | This can be overloaded by implementors if necessary. | |||||
| * | | | | | Avoid double super call in some cases. | Jon Leighton | 2011-09-13 | 1 | -5/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | If super was false earlier, it is still going to be false, so we don't need to call it again at the end of the method. | |||||
| * | | | | | Let Ruby deal with method visibility. | Jon Leighton | 2011-09-13 | 4 | -23/+60 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Check respond_to_without_attributes? in method_missing. If there is any method that responds (even private), let super handle it and raise NoMethodError if necessary. | |||||
| * | | | | | Reset column info when messing with columns. | Jon Leighton | 2011-09-13 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are subclassing Session here, but messing with the columns will affect the attribute methods defined on the Session superclass, and therefore other tests, unless we properly isolate it by resetting column info before and after the test run. | |||||
| * | | | | | Always generate attribute methods on the base class. | Jon Leighton | 2011-09-13 | 4 | -6/+36 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a situation I encountered where a subclass would cache the name of a generated attribute method in @_defined_class_methods. Then, when the superclass has it's attribute methods undefined, the subclass would always have to dispatch through method_missing, because the presence of the attribute in @_defined_class_methods would mean that it is never generated again, even if undefine_attribute_methods is called on the subclass. There various other confusing edge cases like this. STI classes share columns, so let's just keep all the attribute method generation state isolated to the base class. | |||||
| * | | | | | Raise error when using write_attribute with a non-existent attribute. | Jon Leighton | 2011-09-13 | 8 | -25/+47 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing. | |||||
| * | | | | | Make protected method public so we avoid method_missing. | Jon Leighton | 2011-09-13 | 1 | -4/+5 | |
| | | | | | | ||||||
| * | | | | | Fix warnings. | Jon Leighton | 2011-09-13 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | Make sure we don't redefine an already-defined attribute method. | |||||
| * | | | | | Add deprecation for doing `attribute_method_suffix ''` | Jon Leighton | 2011-09-13 | 3 | -8/+22 | |
| | | | | | | ||||||
| * | | | | | refactoring | Jon Leighton | 2011-09-13 | 1 | -19/+11 | |
| | | | | | | ||||||
| * | | | | | Use an empty AttributeMethodMatcher by default. | Jon Leighton | 2011-09-13 | 2 | -2/+26 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This means that attribute methods which don't exist will get generated when define_attribute_methods is called, so we don't have to use hacks like `attribute_method_suffix ''`. | |||||
| * | | | | | Alias id= if necessary, rather than relying on method_missing | Jon Leighton | 2011-09-13 | 1 | -0/+4 | |
| | | | | | | ||||||
| * | | | | | Merge pull request #2988 from guilleiguaran/remove-extra-line | Santiago Pastorino | 2011-09-12 | 1 | -1/+0 | |
| |\ \ \ \ \ | | | | | | | | | | | | | Remove odd asignation | |||||
| | * | | | | | Remove odd asignation | Guillermo Iguaran | 2011-09-12 | 1 | -1/+0 | |
| |/ / / / / | ||||||
| * | | | | | Use the proper executable on tests. | José Valim | 2011-09-12 | 1 | -1/+1 | |
| | | | | | | ||||||
| * | | | | | Merge pull request #2985 from kennyj/master | Santiago Pastorino | 2011-09-12 | 2 | -1/+17 | |
| |\| | | | | | | | | | | | | | | fix https://github.com/rails/rails/issues/2582 (with testcase) | |||||
| | * | | | | fix https://github.com/rails/rails/issues/2582 (with testcase) | kennyj | 2011-09-13 | 2 | -2/+18 | |
| | | | | | | ||||||
| * | | | | | Merge pull request #2678 from jmileham/ares_content_length_bug | Jon Leighton | 2011-09-12 | 2 | -4/+36 | |
| |\ \ \ \ \ | | | | | | | | | | | | | ActiveResource shouldn't rely on the presence of Content-Length | |||||
| | * | | | | | ActiveResource shouldn't rely on the presence of Content-Length | John Mileham | 2011-09-11 | 1 | -1/+9 | |
| | | | | | | | ||||||
| | * | | | | | Failing test: ActiveResource shouldn't rely on the presence of Content-Length | John Mileham | 2011-09-09 | 1 | -3/+27 | |
| | | | | | | | ||||||
| * | | | | | | Just provide the executable for railtie. This should be fine since Rubygems ↵ | José Valim | 2011-09-12 | 3 | -9/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | now warns before overriding them. | |||||
| * | | | | | | Merge pull request #2984 from jrgifford/master | Xavier Noria | 2011-09-12 | 89 | -0/+1417 | |
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | Added getting_started application to railties/guides/code/getting_started | |||||
| | * | | | | | | Added getting_started code, updated guide with link to rails github repo and ↵ | James Gifford | 2011-09-12 | 89 | -0/+1417 | |
| |/ / / / / / | | | | | | | | | | | | | | | | | | | path to code | |||||
| * | | | / / | Merge pull request #2936 from joelmoss/migration_status | Santiago Pastorino | 2011-09-11 | 1 | -5/+7 | |
| | |_|_|/ / |/| | | | | | | | | | | | | | | db:migrate:status not looking at all migration paths | |||||
| * | | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-09-11 | 4 | -10/+10 | |
| |\ \ \ \ \ | |_|_|/ / |/| | | | | ||||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |