| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
`scaffold_stylesheet` was added in #20479.
|
|\
| |
| | |
Changed behaviour of timestamps helper by create_table migration generator [ci skip]
|
|/
|
|
| |
[ci skip]
|
|\
| |
| | |
Fix a small template misrender in ActiveRecord::Persistence
|
|/
|
|
|
|
|
|
| |
See the end of [this] page.
[ci skip]
[this]: http://edgeapi.rubyonrails.org/classes/ActiveRecord/Persistence/ClassMethods.html#method-i-create
|
|\
| |
| | |
Deprecate `{insert|update|delete}_sql` in `DatabaseStatements`
|
| |
| |
| |
| |
| | |
Originally, `{insert|update|delete}_sql` is protected methods.
We can use the `{insert|update|delete}` public methods instead.
|
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts changes made to integration tests in PR #23807.
The issue happens when using capybara with a driver that needs to start a
server in a separate thread like (poltergeist, selenium, etc).
Both threads the capybara server one and the test thread end running
syncronize over the interlock.
|
| | |
|
| | |
|
|\ \
| | |
| | | |
[ci skip] Add `bundle exec` for ActiveRecord unit tests
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Fix description in cookies_serializer.rb being corrupted by gsub when updating
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fix typo in app_generator_test.rb
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Fix typo in implicit_render
|
| | | |
| | | |
| | | | |
When trying to make a request and the request doesn't have a suitable template, the new error messages are really helpful but there's a small (and I mean, VERY small) typo that has been bugging me for the last few days. This adds the space and restores order to the universe. :heart:
|
|\ \ \ \
| | | | |
| | | | | |
Remove not needed `exec_insert` in mysql2 adapter
|
| | |_|/
| |/| |
| | | |
| | | | |
Simply it is sufficient to use the method in the super class.
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] Use rails routes instead of rake routes in inspector test …
|
| | |/ /
| |/| | |
|
|\ \ \ \
| |/ / /
|/| | | |
Accept channel identifiers with no backslashes/escaping
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes #22675
Allow channel identifiers and also data with no backslahes/escaping to be accepted by
the subscription storer.
|
|\ \ \
| |_|/
|/| |
| | | |
ActionCable: Add a "welcome" and "ping" message type
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This change makes ping into a message type, which
makes the whole protocol a lot more consistent.
Also fixes hacks on the client side to make this all
work.
|
| | | |
|
|\ \ \
| |_|/
|/| | |
Remove requiring load_paths from tools/test.rb
|
|/ /
| |
| |
| |
| |
| |
| | |
- Instead require and setup Bundler
- `tools/test.rb` is used internally from all `bin/test` scripts inside
component gems.
- Followup of https://github.com/rails/rails/commit/2abcdfd978fdcd491576a237e8c6be04ddaf884d.
|
|\ \
| | |
| | | |
Fix `ActiveSupport::Reloader.check!`
|
| | |
| | |
| | |
| | |
| | | |
The test failure in `bug_report_templates/action_controller_master.rb`
is due to `app.reloader.check` is `nil`.
|
|\ \ \
| | | |
| | | | |
Remove load_paths file
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
Remove duplicated `test_` prefix [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Add a test for primary key should be not null
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
kamipo/exclude_name_and_type_from_prepare_column_options
Exclude `:name` and `:type` from `prepare_column_options`
|
| |/ / /
| | | |
| | | |
| | | | |
Actually `:name` and `:type` are not column options.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
kamipo/fix_tests_failure_with_prepared_statements_false
Fix tests failure with `prepared_statements: false`
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Some tests does not work for unprepared statements.
Add `if ActiveRecord::Base.connection.prepared_statements` and fix a
regex for fix tests failure with `prepared_statements: false`.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The error occurs with `prepared_statements: false`:
```
$ ARCONN=postgresql bundle exec ruby -w -Itest test/cases/associations_test.rb
Using postgresql
Run options: --seed 27753
...E....................................
Finished in 0.713115s, 56.0919 runs/s, 91.1494 assertions/s.
1) Error:
AssociationsTest#test_force_reload_is_uncached:
NoMethodError: undefined method `preparable' for #<Arel::Visitors::PostgreSQL:0x007f8699702570>
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:68:in `block in select_all'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:83:in `cache_sql'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:68:in `select_all'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/querying.rb:39:in `find_by_sql'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/relation.rb:699:in `exec_queries'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/association_relation.rb:32:in `exec_queries'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/relation.rb:580:in `load'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/relation.rb:260:in `records'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/relation.rb:256:in `to_a'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/associations/collection_association.rb:458:in `get_records'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/associations/collection_association.rb:473:in `find_target'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/associations/collection_association.rb:412:in `load_target'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/associations/collection_proxy.rb:45:in `load_target'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/associations/collection_proxy.rb:983:in `records'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/relation/delegation.rb:39:in `each'
test/cases/associations_test.rb:116:in `block (2 levels) in test_force_reload_is_uncached'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:32:in `cache'
/Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/query_cache.rb:9:in `cache'
test/cases/associations_test.rb:115:in `block in test_force_reload_is_uncached'
/Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/deprecation/reporting.rb:36:in `silence'
/Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/deprecation/instance_delegator.rb:19:in `silence'
test/cases/associations_test.rb:114:in `test_force_reload_is_uncached'
```
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix `NoMethodError: undefined method `fields' for nil:NilClass`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Currently `exec_query` raises `NoMethodError` when executing no result
queries (`INSERT`, `UPDATE`, `DELETE`, and all DDL) in mysql2 adapter.
```
irb(main):002:0> conn.execute("create table t(a int)")
(43.3ms) create table t(a int)
=> nil
irb(main):003:0> conn.execute("insert into t values (1)")
(19.3ms) insert into t values (1)
=> nil
irb(main):004:0> conn.exec_query("insert into t values (1)")
SQL (28.6ms) insert into t values (1)
NoMethodError: undefined method `fields' for nil:NilClass
```
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit ddb7be50e8a0946d29fbe66537f845b8369413b7, reversing
changes made to ee4a1462e97f26bd480352468efab5b9c18aa8de.
Reason: It is givin us a lot of timeouts in travis because JRuby 9.0.5.0
needs to be build in every run
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
convert cable.coffee to cable.js
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In order to eliminate the dependecy of CoffeeScript.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Deprecate `Module.local_constants`
|