Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| | * | | | adds test coverage for with_output_buffer | Xavier Noria | 2010-03-15 | 1 | -3/+45 | |
| | | | | | | | | | | | | | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
| | * | | | Reinstate old default_url_options method signature | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 | |
| | | | | | ||||||
| | * | | | Allow memcache-client 1.8.0 | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 | |
| | | | | | ||||||
| | * | | | Add deprecation notices for <% %>. | Carlhuda | 2010-03-15 | 15 | -97/+88 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * The approach is to compile <% %> into a method call that checks whether the value returned from a block is a String. If it is, it concats to the buffer and prints a deprecation warning. * <%= %> uses exactly the same logic to compile the template, which first checks to see whether it's compiling a block. * This should have no impact on other uses of block in templates. For instance, in <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array, not a String, so the result is not concatenated * In two cases (#capture and #cache), a String can be returned that should *never* be concatenated. We have temporarily created a String subclass called NonConcattingString which behaves (and is serialized) identically to String, but is not concatenated by the code that handles deprecated <% %> block helpers. Once we remove support for <% %> block helpers, we can remove NonConcattingString. | |||||
| | * | | | Hack to keep column metadata queries out of test query counts | Jeremy Kemper | 2010-03-15 | 1 | -0/+5 | |
| | | | | | ||||||
* | | | | | AS guide: warns about the singleton classes of nil, true, and false ↵ | Xavier Noria | 2010-03-28 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | according to what http://redmine.ruby-lang.org/repositories/diff/ruby-19/object.c?rev=27022 blesses | |||||
* | | | | | Adding the initialization guide to docrails. | Ryan Bigg | 2010-03-28 | 1 | -0/+3095 | |
|/ / / / | ||||||
* | | | | Add debugging documentation for _callback_chain to ActiveRecord::Callback | chrisfinne | 2010-03-26 | 1 | -0/+10 | |
| | | | | | | | | | | | | | | | | Signed-off-by: Rizwan Reza <rizwanreza@gmail.com> | |||||
* | | | | fix habtm documentation to correct typo | Jeremy Roman | 2010-03-26 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | Signed-off-by: Rizwan Reza <rizwanreza@gmail.com> | |||||
* | | | | Updated ActionController::Base.asset_host example | retr0h | 2010-03-25 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The example provided contrived. It is not useful when wanting to use 1-based asset hosts (since it would generate a random asset host for the same asset). Signed-off-by: Rizwan Reza <rizwanreza@gmail.com> | |||||
* | | | | Routes guide being rewritten, done till :singular. | Rizwan Reza | 2010-03-25 | 1 | -16/+14 | |
| | | | | ||||||
* | | | | Fixing spelling error in activerecord guide in the validation callbacks ↵ | Brian Doll | 2010-03-24 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | section, closing issue #2 | |||||
* | | | | AS guide: documents Module#remove_possible_method | Xavier Noria | 2010-03-23 | 1 | -0/+19 | |
| | | | | ||||||
* | | | | normalizes titles of release notes guides, and adds them to the home page | Xavier Noria | 2010-03-19 | 3 | -1/+22 | |
| | | | | ||||||
* | | | | s/guides.rails.info/edgeguides.rubyonrails.org/ in a few places, and makes ↵ | Xavier Noria | 2010-03-19 | 6 | -7/+7 | |
| | | | | | | | | | | | | | | | | some links relative to work in either site | |||||
* | | | | guides generator skips untouched guides by default, override with ALL=1 | Xavier Noria | 2010-03-17 | 1 | -7/+15 | |
| | | | | ||||||
* | | | | AS guide: completes section about loading AS core extensions within a Rails ↵ | Xavier Noria | 2010-03-16 | 1 | -4/+10 | |
| | | | | | | | | | | | | | | | | application | |||||
* | | | | AS guide: adds extension to file name | Xavier Noria | 2010-03-16 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | guides generation: undoes output buffer workaround, more refactors | Xavier Noria | 2010-03-15 | 2 | -23/+17 | |
| | | | | ||||||
* | | | | Merge remote branch 'mainstream/master' | Pratik Naik | 2010-03-15 | 53 | -288/+339 | |
|\| | | | ||||||
| * | | | with_output_buffer cannot assume there's an output_buffer | Xavier Noria | 2010-03-15 | 2 | -1/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | [#4182 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
| * | | | to_str works here | Jeremy Kemper | 2010-03-15 | 2 | -6/+2 | |
| | | | | ||||||
| * | | | CI: sudo rm to sledgehammer bad perms | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Hack to keep column metadata queries out of test query counts | Jeremy Kemper | 2010-03-15 | 1 | -3/+7 | |
| | | | | ||||||
| * | | | cleaning up many more warnings in activerecord [#4180 state:resolved] | Aaron Patterson | 2010-03-15 | 4 | -3/+17 | |
| | | | | | | | | | | | | | | | | Signed-off-by: wycats <wycats@gmail.com> | |||||
| * | | | Don't force singularization of singleton resource names, e.g. /preferences ↵ | Andrew White | 2010-03-15 | 2 | -8/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | [#4089 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| * | | | read_ and write_fragment cache preserve html safety yet cache strings only | Jeremy Kemper | 2010-03-14 | 2 | -6/+19 | |
| | | | | ||||||
| * | | | speeding up clone_attributes, changing readonly to be initialized in def ↵ | Aaron Patterson | 2010-03-14 | 1 | -8/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | initialize Signed-off-by: wycats <wycats@gmail.com> | |||||
| * | | | cleaning up some test warnings | Aaron Patterson | 2010-03-14 | 4 | -5/+16 | |
| | | | | | | | | | | | | | | | | Signed-off-by: wycats <wycats@gmail.com> | |||||
| * | | | There's a Ruby issue with File.basename different versions returns different ↵ | Santiago Pastorino | 2010-03-14 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | things, so we shouldn't test that | |||||
| * | | | Making escaped things more readable | Santiago Pastorino | 2010-03-14 | 3 | -3/+3 | |
| | | | | ||||||
| * | | | Optimize DetailsKey generation. | José Valim | 2010-03-14 | 1 | -4/+5 | |
| | | | | ||||||
| * | | | restricts a test to < 1.9, and rewrites it using a proper expectation | Xavier Noria | 2010-03-13 | 2 | -11/+6 | |
| | | | | | | | | | | | | | | | | Signed-off-by: wycats <wycats@gmail.com> | |||||
| * | | | Ensure controller filters are executed before stuff starts to happen. | José Valim | 2010-03-13 | 3 | -3/+21 | |
| | | | | ||||||
| * | | | Remove formats setters from render template, speeding up partial and ↵ | José Valim | 2010-03-13 | 1 | -2/+1 | |
| | | | | | | | | | | | | | | | | collection renderings. | |||||
| * | | | adds coverage for the issue addressed in fe43bbd | Xavier Noria | 2010-03-12 | 1 | -0/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | [#4166 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
| * | | | In app_generator, fix hardcoded `bundle` call to derive the bundle ↵ | Caio Chassot | 2010-03-12 | 2 | -3/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | executable name from Thor::Util.ruby_command. This ensures that eg. when `rails` is called from `ruby1.9`, `bundle1.9` is called. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | | | Add a check to ensure that the application name does not already exist, i.e. ↵ | Kieran Pilkington | 2010-03-12 | 2 | -0/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | String or Module are part of ruby [#3872 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | | | Made asset_tag_helper use config.perform_caching instead of ↵ | Denis Odorcic | 2010-03-12 | 2 | -32/+32 | |
| | | | | | | | | | | | | | | | | | | | | | | | | ActionController::Base.perform_caching Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | | | Prettify generators description whenever using the default stack [#4143 ↵ | José Valim | 2010-03-12 | 2 | -2/+20 | |
| | | | | | | | | | | | | | | | | status:resolved] | |||||
| * | | | keep AssociationProxy#to_a to avoid warning in Array(post.author), and ↵ | Xavier Noria | 2010-03-12 | 2 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | delegate it to @target in association collections [#4165 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
| * | | | Load the environment before executing rails console. [#3905 status:resolved] | José Valim | 2010-03-12 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Revert "Always load the environment before executing any command. [#3905 ↵ | José Valim | 2010-03-12 | 2 | -6/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | status:resolved]" This reverts commit 16846553b8866eab2aa3b128a2a23a221a25f7e3. | |||||
| * | | | Finish cleaning up rendering stack from views and move assigns evaluation to ↵ | José Valim | 2010-03-12 | 15 | -75/+68 | |
| | | | | | | | | | | | | | | | | controller (so plugins and/or controllers can overwrite just one method). | |||||
| * | | | Allow anything that responds to render to be given as :template and use ↵ | José Valim | 2010-03-12 | 9 | -120/+65 | |
| | | | | | | | | | | | | | | | | find_template instead of find in views. | |||||
* | | | | AS guide: documents a use case for :instance_writer, based on a remark of Jeremy | Xavier Noria | 2010-03-15 | 1 | -0/+2 | |
| | | | | ||||||
* | | | | refactors some bits of the guides generator, ONLY selection accepts ↵ | Xavier Noria | 2010-03-15 | 1 | -39/+51 | |
| | | | | | | | | | | | | | | | | prefixes, guides generation fixed for 1.9, revised string safety in a few spots | |||||
* | | | | Update of block helpers examples in form_helper.rb | Jeroen van Dijk | 2010-03-13 | 1 | -32/+32 | |
| | | | | ||||||
* | | | | Updated documentation for block helpers in render/layouts.rb | Jeroen van Dijk | 2010-03-12 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | Merge remote branch 'mainstream/master' | Pratik Naik | 2010-03-12 | 361 | -4154/+5293 | |
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/base.rb railties/lib/rails/configuration.rb railties/lib/rails/log_subscriber.rb |