| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| |
| |
| |
| | |
CLUSTERfoo/fix/adding_timestamps_migration_not_reversible
Failure to rollback t.timestamps when within a change_table migration
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When running the following migration:
change_table(:table_name) { |t| t/timestamps }
The following error was produced:
wrong number of arguments (2 for 1) .... /connection_adapters/abstract/schema_statements.rb:851:in `remove_timestamps'
This is due to `arguments` containing an empty hash as its second
argument.
|
|/
|
|
|
|
|
|
| |
[ci skip]
This is due to the fact that `.delete` is directly translated to SQL.
It tries to follow the same rules as `.delete_all` which is not able
to verify that records are `#readonly?`.
|
| |
|
|\
| |
| | |
remove useless methods
|
| | |
|
|\ \
| | |
| | | |
[ci skip] remove references to `Numeric#from_now`
|
| | | |
|
|\ \ \
| |_|/
|/| | |
Fix "nonexistent" typo in tests
|
| | | |
|
|/ / |
|
|\ \
| | |
| | | |
Refactor `build_from_hash` to convert dot notation to hash first
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This ensures that we're handling all forms of nested tables the same way.
We're aware that the `convert_dot_notation_to_hash` method will cause a
performance hit, and we intend to come back to it once we've refactored some of
the surrounding code.
[Melissa Xie & Melanie Gilman]
|
|/ /
| |
| |
| |
| |
| | |
Without this,
% rails r "require 'rails/tasks'"
would cause a NoMethodError: undefined method `desc' for main:Object
|
|\ \
| | |
| | | |
Refactor `PredicateBuilder` from singleton to instance
|
| | | |
|
| | |
| | |
| | |
| | | |
We should remove this dependency later.
|
|\ \ \
| | | |
| | | | |
Allow to unscope where conditions by arel_table with symbol
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
This commit fixes the following case.
User.where(User.arel_table[:created_at].lteq(1.year.ago)).unscope(where :created_at)
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add additional information to the release notes to explain the requirement
for paths in integration tests to start with a leading slash.
Fixes #17870.
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is the project guideline and the reasons are:
* That follows standard Ruby semantics.
* Allows the implementation to avoid artificial code like !! or something ? true : false
* You do not need to rely on the exact type of 3rd party code. For
example, if your method returns str.end_with?('foo') you do not need to
make sure end_with? returns a singleton. Your predicate just propagates
predicate semantics up regardless of what end_with? returns.
|
|\ \
| | |
| | | |
Refactor debug view
|
| | |
| | |
| | | |
Avoid logic in ERB and use helpers
|
|\ \ \
| | | |
| | | | |
Add new methods to MessageVerifier
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit adds a `#verified` method to
`ActiveSupport::MessageVerifier` which will return either `false` when
it encounters an error or the message. `#verify` continues to raise an
`InvalidSignature` exception on error.
This commit also adds a convenience boolean method on `MessageVerifier`
as a way to check if a message is valid without performing the
decoding.
|
|\ \ \
| | | |
| | | | |
Silence Minitest for plugin tests.
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes https://github.com/rails/rails/issues/17340.
Use Minitest::BacktraceFilter instead of removing all silencers. This
will allow the backtrace for all libraries in the plugin to be shown
while removing noise generated by Minitest's backtrace.
|
| | |
| | |
| | |
| | | |
`_generate_paths_by_default` should always be private.
|
| | | |
|
|\ \ \
| | | |
| | | | |
no need to pass native_database_types around
|
|/ / / |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Remove unused AV/test/fixtures/scope
|
| |/ /
| | |
| | |
| | |
| | | |
The file `modgreet.erb` was added 8 years ago in 21187c0
and is not used anymore by any test.
|
|\ \ \
| |/ /
|/| | |
Remove unused AV/test/fixtures/happy_path
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The `test/fixtures/happy_path/render_action/hello_world.erb` file was
introduced in 8ab37c7 for the `TestRenderAction` test.
That test was subsequently removed in 34f058e, so the fixture is not
used anymore.
If Travis CI is happy, then you can be sure the fixture can be removed.
|
|\ \
| | |
| | | |
Remove unused AV/test/fixtures/blog_public
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The fixtures were added to support StaticTests in 401cd97 but
those tests were then removed in d5ad92ce.
If Travis CI is happy with this PR, then you can be sure that
those fixtures are not needed anymore.
|
|\ \ \
| |_|/
|/| |
| | |
| | | |
claudiob/remove-duplicate-functional-caching-fixture
Remove one AV fixture (duplicate of an AP fixture)
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Both ActionPack and ActionView include `test/fixtures/functional_caching/fragment_cached_without_digest.html.erb`.
The [ActionPack file](https://github.com/rails/rails/blob/master/actionpack/test/fixtures/functional_caching/fragment_cached_without_digest.html.erb) is used by the tests.
The [ActionView file](https://github.com/rails/rails/blob/master/actionview/test/fixtures/functional_caching/fragment_cached_without_digest.html.erb) is not: it was introduced in eb23754e when some tests and
fixtures were moved from AP to AV, but no tests in AV uses the fixture.
Long story short: if Travis CI is happy with removing the fixture, you can
be sure that is not needed anymore!
|
|\ \
| |/
|/| |
Bugfix config.action_view.default_form_builder option
|
| | |
|
| | |
|