| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| | | | |
| | | | | |
also rename indexes when a table or column is renamed
|
|/ / / /
| | | |
| | | |
| | | | |
When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed.
|
| | | | |
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
deal with long index names and internal sqlite3 operations
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Some adapter (SQLite3) need to perform renaming operations to support
the rails DDL. These rename prefixes operate with prefixes. When an
index name already uses up the full space provieded by
`index_name_length` these internal operations will fail. This patch
introduces `allowed_index_name_length` which respects the amount of
characters used for internal operations. It will always be <=
`index_name_length` and every adapter can define how many characters
need to be reserved.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
wangjohn/adding_documentation_to_error_raising_in_query_methods
Tests to make sure empty arguments in WhereChain raise errors
|
| | | |
| | | |
| | | |
| | | |
| | | | |
for query methods in a where_clause. Also, modified the CHANGELOG entry
because it had false information and added tests.
|
|\ \ \ \
| | | | |
| | | | | |
Fix ActiveRecord::ConnectionAdapters::ConnectionSpecification::ResolverTest
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Reduced memory leak problem in transactions by lazily updating AR objects
|
| |/ / /
| | | |
| | | |
| | | | |
with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks.
|
|\ \ \ \
| |/ / /
|/| | | |
move config.assets.precompile into config/application.rb
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
fix rake db:migrate when used with ENV['DATABASE_URL']
|
| | | | |
|
| | | | |
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
make connection_url_to_hash a class method
This als prevents loading database.yml if it doesn't exist
but DATABASE_URL does
|
|\ \ \
| | | |
| | | | |
Remove XML Parser from ActionDispatch
|
|/ / /
| | |
| | |
| | |
| | | |
If you want an ability to parse XML parameters, please install
`actionpack-xml_parser` gem.
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
senny/7313_descriptive_error_message_for_missing_adapter
descriptive error message when AR adapter was not found. Closes #7313
|
|/ / |
|
|\ \
| | |
| | | |
Fix time_zone_options_for_select to not mutate TimeZones array
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previous implementation of time_zone_options_for_select did not dup the
ActiveSupport::TimeZone.all array. When :priority_zones were provided
the method would reject! the zones from the memoized TimeZones array
thus affecting future requests to the server. Essentially whatever
zones were specified as :priority_zones would show up for the first
request but then disappear from the time zone options on future
requests.
|
|\ \ \
| |/ /
|/| | |
Improve upgrading guide with ActionDispatch::BestStandardsSupport remova...
|
|/ / |
|
| | |
|
|\ \
| | |
| | | |
added more accurate test for add_on_empty
|
| | |
| | |
| | |
| | |
| | | |
with the current tests, if delete the assignment of is_empty in add_on_empty method
the tests not fail. With this test, if we delete is_empty, the test fails
|
| | | |
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
Takehiro-Adachi/remove-unecessary-tests-from-ar-base_testrb
delete duplicated tests in AR base_test.rb
|
| | |
| | |
| | |
| | | |
These are duplicated with the tests which are in relations_test.rb
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Raising an error when query methods have blank arguments.
|
|/ / /
| | |
| | |
| | | |
arguments are meaningless.
|
| | |
| | |
| | |
| | | |
Closes #9302
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Require ActiveSupport dependencies in ActionDispatch::Http::URL
|
| | | |
| | | |
| | | |
| | | | |
Allows us to use url_for and friends in isolation.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Most application developers shouldn't be adding paths to
`config.autoload_paths` as it won't be eagerly loaded so
remove it from the generated config/application.rb file.
If a developer does want to autoload from paths outside of the app
directory then they should add the path to `config.eager_load_paths`
as these paths are also autoloaded as well.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Whilst autoloading is known to be not threadsafe, leaving it in place
is a softer solution than failing hard when an application is deployed.
Many older applications will have paths added to `autoload_paths` and
ideally these should be eagerly loaded to be threadsafe. However one
of these paths is quite often lib which could lead to unintended
consequences due to the 'junk drawer' nature of this directory.
Developers should refrain from adding paths to `autoload_paths` or
`eager_load_paths` and use custom folders inside app for code that
needs to be eagerly loaded and use `require` or `require_dependency`
to explicitly load code from other locations.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Because of the possibility of lib being unintentionally eager loaded
it's been agreed that we'll leave autoload paths and eager load paths
separate for Rails 4.0.
This reverts commit 0757b3388ffe4f44b60de950d40e18ef05055931.
Conflicts:
railties/CHANGELOG.md
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Somehow I missed this method, which was then throwing an error
when viewing routes as HTML.
Make @rubys happy: ✔
|